From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MMC: pxamci: call pdata->setpower even when regulator is used
Date: Wed, 2 Dec 2009 12:34:53 +0800 [thread overview]
Message-ID: <f17812d70912012034t57ebde8fmb7f7971109436775@mail.gmail.com> (raw)
In-Reply-To: <1259233813-2724-1-git-send-email-daniel@caiaq.de>
On Thu, Nov 26, 2009 at 7:10 PM, Daniel Mack <daniel@caiaq.de> wrote:
> On platforms where the vmmc regulator is used, it might still be
> necessary to call the platform data's setpower() callback in order to
> drive GPIOs to power up hardware.
>
> I can't see any pxamci user with power regulators enabled, hence this
> shouldn't break anything.
>
I was thinking about this for quite a time, and I'm afraid that this patch
solves only one corner case - that some specific actions need to be
taken _after_ mmc regulator is adjusted, while excluding the possibility
for that to happen _before_. I wonder maybe for those corner cases,
if one can just manipulate the vmmc regulator and other specific stuffs
within ->setpower().
next prev parent reply other threads:[~2009-12-02 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 11:10 [PATCH] MMC: pxamci: call pdata->setpower even when regulator is used Daniel Mack
2009-12-02 0:52 ` Daniel Mack
2009-12-02 4:34 ` Eric Miao [this message]
2010-08-27 19:00 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70912012034t57ebde8fmb7f7971109436775@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).