From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] [ARM] locomo: remove unused IRQs and avoid unnecessary cascade
Date: Fri, 1 Jan 2010 10:59:05 +0800 [thread overview]
Message-ID: <f17812d70912311859w597e4174s6c0101b670d758a@mail.gmail.com> (raw)
In-Reply-To: <4B3CAA54.1040301@gmx.de>
On Thu, Dec 31, 2009 at 9:42 PM, Thomas Kunze <thommycheck@gmx.de> wrote:
> Eric Miao wrote:
>>
>> IRQ_LOCOMO_* are never used elsewhere, remove these definitions. As well
>> as the cascade of these IRQs. IRQ_LOCOMO_*_BASE changed to IRQ_LOCOMO_*.
>>
>> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>>
>
> Unlike poodle which AFAIK only uses locomo for keyboard Collie needs most of
> these irqs for various subdevices (for example SD-Card on SPI bus) . The
> drivers for these devices
> will find their way into mainline as time permits. So please don't remove
> this functionality.
>
The LoCoMo driver is really weird, it has a second cascade of the IRQ
which looks to me unnecessary.
Could you look into the possibility that the subdevices driver on collie
can make use only of the first level IRQ?
The GPIO IRQs, which I'm seeking alternate solution with dynamic IRQ.
next prev parent reply other threads:[~2010-01-01 2:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 5:18 [PATCH 0/7] pxa/sa1100: irqs.h cleanup Eric Miao
2009-12-28 5:18 ` [PATCH 1/7] [ARM] sa1100: remove unreferenced IRQ definitions Eric Miao
2009-12-31 13:23 ` Thomas Kunze
2010-01-10 17:04 ` Marek Vasut
2010-01-21 18:01 ` Thomas Kunze
2009-12-28 5:18 ` [PATCH 2/7] [ARM] locomo: avoid the unnecessary cascade of keyboard IRQ Eric Miao
2009-12-31 13:47 ` Thomas Kunze
2010-01-01 3:35 ` Eric Miao
2010-01-02 11:43 ` Russell King - ARM Linux
2010-01-03 8:07 ` Eric Miao
2009-12-28 5:18 ` [PATCH 3/7] [ARM] locomo: remove unused IRQs and avoid unnecessary cascade Eric Miao
2009-12-31 13:42 ` Thomas Kunze
2010-01-01 2:59 ` Eric Miao [this message]
2010-01-10 14:31 ` Thomas Kunze
2010-01-02 11:45 ` Russell King - ARM Linux
2009-12-28 5:18 ` [PATCH 4/7] [ARM] locomo: allow cascaded IRQ base to be specified by platforms Eric Miao
2009-12-28 21:14 ` Pavel Machek
2009-12-29 1:07 ` Eric Miao
2009-12-28 5:18 ` [PATCH 5/7] [ARM] sa1111: avoid using hardcoded IRQ numbers for PCMCIA driver Eric Miao
2009-12-28 5:18 ` [PATCH 6/7] [ARM] sa1111: allow cascaded IRQs to be used by platforms Eric Miao
2009-12-28 5:18 ` [PATCH 7/7] [ARM] pxa: move board board IRQ definitions out of irqs.h Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70912311859w597e4174s6c0101b670d758a@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).