From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric.y.miao@gmail.com (Eric Miao) Date: Fri, 1 Jan 2010 10:59:05 +0800 Subject: [PATCH 3/7] [ARM] locomo: remove unused IRQs and avoid unnecessary cascade In-Reply-To: <4B3CAA54.1040301@gmx.de> References: <1261977488-18271-1-git-send-email-eric.y.miao@gmail.com> <1261977488-18271-4-git-send-email-eric.y.miao@gmail.com> <4B3CAA54.1040301@gmx.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 31, 2009 at 9:42 PM, Thomas Kunze wrote: > Eric Miao wrote: >> >> IRQ_LOCOMO_* are never used elsewhere, remove these definitions. As well >> as the cascade of these IRQs. IRQ_LOCOMO_*_BASE changed to IRQ_LOCOMO_*. >> >> Signed-off-by: Eric Miao >> > > Unlike poodle which AFAIK only uses locomo for keyboard Collie needs most of > these irqs for various subdevices (for example SD-Card on SPI bus) . The > drivers for these devices > will find their way into mainline as time permits. So please don't remove > this functionality. > The LoCoMo driver is really weird, it has a second cascade of the IRQ which looks to me unnecessary. Could you look into the possibility that the subdevices driver on collie can make use only of the first level IRQ? The GPIO IRQs, which I'm seeking alternate solution with dynamic IRQ.