From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH - 2nd attempt] ARM: Support for Embedian MXM-8x10 eval kit
Date: Thu, 14 Jan 2010 09:12:18 +0800 [thread overview]
Message-ID: <f17812d71001131712i72e62565ob1afab8542efb966@mail.gmail.com> (raw)
In-Reply-To: <20100113155454.GC28292@n2100.arm.linux.org.uk>
> > +
> > +static void __init capc7117_ide_init(void)
> > +{
> > + ? ? pxa3xx_mfp_write(MFP_PIN_GPIO76, 0xa0c0); ? ? ? /* EXT_IRQ3 */
>
> I'm not sure that pxa3xx_mfp_write is supposed to be used. ?Eric?
>
No, we don't. Having magic number there is really painful to
understand and maintain. I guess for the statement above, one
can easily write this in a pin config array with macro:
GPIO76_GPIO, /* EXT_IRQ3 */
next prev parent reply other threads:[~2010-01-14 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 15:30 [PATCH - 2nd attempt] ARM: Support for Embedian MXM-8x10 eval kit Edwin Peer
2010-01-13 15:54 ` Russell King - ARM Linux
2010-01-14 1:12 ` Eric Miao [this message]
2010-01-14 2:29 ` Eric Miao
2010-01-14 9:09 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d71001131712i72e62565ob1afab8542efb966@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).