[PATCH] locomo.c: make irq register access typesafe

[eric.y.miao@gmail.com (Eric Miao)]

On Thu, Jan 21, 2010 at 10:31 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> On Wednesday, January 20, 2010 7:13 PM, Eric Miao wrote:
>> On Thu, Jan 21, 2010 at 2:10 AM, H Hartley Sweeten
>> <hartleys@visionengravers.com> wrote:
>>> In locomo_setup_irq a void __iomem * is stored by set_irq_chip_data
>>> to hold the base address for the irq registers. ?Unfortunately chip_data
>>> is a void *. This will cause a number of (different address space) sparse
>>> warnings.
>>>
>>
>> That's actually been fixed as a side effect in my previous proposed
>> irq cleanup patches. The way is to pass locomo chip as the data
>> instead of a raw pointer. Please let me know how you think, the
>> specific patch follows:
>
> There must be some other patches to locomo.c that remove the locomo_key_*,
> locomo_gpio_*, locomo_lt_*, and locomo_spi_* related stuff. ?Were all of
> them merged into common code? ?Where can I find a reference to the
> original patches?
>

Cannot find the reference atm but they were posted weeks ago.

> Other than that it looks good to me.

Thanks.