linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] pxa: match camera clock by struct device
Date: Tue, 2 Feb 2010 01:50:38 +0800	[thread overview]
Message-ID: <f17812d71002010950v2bff262j43700d2be04da3e3@mail.gmail.com> (raw)
In-Reply-To: <1264931178-29177-1-git-send-email-mike@compulab.co.il>

On Sun, Jan 31, 2010 at 5:46 PM, Mike Rapoport <mike@compulab.co.il> wrote:
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> ---
> ?arch/arm/mach-pxa/pxa3xx.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
> index fcb0721..9d338a7 100644
> --- a/arch/arm/mach-pxa/pxa3xx.c
> +++ b/arch/arm/mach-pxa/pxa3xx.c
> @@ -257,7 +257,7 @@ static struct clk_lookup pxa3xx_clkregs[] = {
> ? ? ? ?/* Power I2C clock is always on */
> ? ? ? ?INIT_CLKREG(&clk_dummy, "pxa3xx-pwri2c.1", NULL),
> ? ? ? ?INIT_CLKREG(&clk_pxa3xx_lcd, "pxa2xx-fb", NULL),
> - ? ? ? INIT_CLKREG(&clk_pxa3xx_camera, NULL, "CAMCLK"),
> + ? ? ? INIT_CLKREG(&clk_pxa3xx_camera, "pxa27x-camera.0", NULL),

Interesting, but not keeping an eye on pxa27x camera driver for a while,
does that support pxa3xx as well? I seem to remember the DMA logic
is a bit different, making it quite difficult to support both in a
single driver.

And the hardware in pxa320 differs from the one in pxa310 as well.

> ? ? ? ?INIT_CLKREG(&clk_pxa3xx_ac97, NULL, "AC97CLK"),
> ? ? ? ?INIT_CLKREG(&clk_pxa3xx_ffuart, "pxa2xx-uart.0", NULL),
> ? ? ? ?INIT_CLKREG(&clk_pxa3xx_btuart, "pxa2xx-uart.1", NULL),
> --
> 1.6.4.4
>
>

  reply	other threads:[~2010-02-01 17:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-31  9:46 [PATCH] [ARM] pxa: match camera clock by struct device Mike Rapoport
2010-02-01 17:50 ` Eric Miao [this message]
     [not found] <1264930332-28775-1-git-send-email-mike@compulab.co.il>
2010-01-31 11:03 ` Mike Rapoport
  -- strict thread matches above, loose matches on Subject: below --
2010-01-31  9:50 Mike Rapoport
2010-01-31  9:34 Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17812d71002010950v2bff262j43700d2be04da3e3@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).