From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric.y.miao@gmail.com (Eric Miao) Date: Thu, 4 Feb 2010 04:47:41 -0800 Subject: [PATCH 1/1] fix i2c_msg.len not aligning with i2c_master_send In-Reply-To: <309424b61002040438i2fae055dt2d3ef528eae99b48@mail.gmail.com> References: <309424b61002032204y37307236q94ab3a502b0526e0@mail.gmail.com> <20100204103530.65429c04@hyperion.delvare> <309424b61002040438i2fae055dt2d3ef528eae99b48@mail.gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > How about return error in i2c_master_send & i2c_master_recv when count > is bigger than 64K, as suggested by Ben. I think that's more preferable. Making the count parameter as u16, though is going to generate a warning, yet that's usually ignored by careless programmer, screaming out when this happens might be more useful sometimes. > The device I used could receive 32K one time instead, the firmware > download only takes place on-demand in fact. > However, it took some time to debug, since no error info come out. > Add error msg may notify users, though transfering more than 64K data > one time is rarely happen. > > Thanks > Zhangfei >