From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] pxa/zeus: Allow usage of 8250-compatible UART in uncompress
Date: Fri, 19 Feb 2010 15:38:10 +0800 [thread overview]
Message-ID: <f17812d71002182338t1a03d69r58ebb5dcf78eb414@mail.gmail.com> (raw)
In-Reply-To: <20100219071335.6b893aa7@taxman.wild-wind.fr.eu.org>
On Fri, Feb 19, 2010 at 3:13 PM, Marc Zyngier <maz@misterjones.org> wrote:
> On Fri, 19 Feb 2010 14:17:52 +0800
> Eric Miao <eric.y.miao@gmail.com> wrote:
>
>> On Fri, Feb 19, 2010 at 4:26 AM, Marc Zyngier <maz@misterjones.org> wrote:
>> > Zeus console port is wired to a 8250-compatible device
>> > (pxa UARTs are reserved to other uses). This patch
>> > allows such a configuration in the uncompress sequence.
>> >
>> > It has been regression-tested on a Viper using FFUART.
>> >
>> > Signed-off-by: Marc Zyngier <maz@misterjones.org>
>>
>> Hi Marc,
>>
>> I would like to modify the patch a little bit as follows (and into two),
>> please let me know if you are OK (better to go with your Ack):
>>
>> ? ? [ARM] pxa: refactor uncompress.h for non-PXA uarts
>>
>> ? ? The original patch came from Marc Zyngier where support of 8250-compatible
>> ? ? UART is required to show the uncompress information. Modified a little bit
>> ? ? here, including changes below:
>>
>> ? ? 1. #include <mach/regs-uart.h> is actually not necessary
>> ? ? 2. introduced uart_{read,write}() for different base and shift
>> ? ? 3. introduced uart_is_enabled() and assumed enabled always for
>> ? ? ? ?non-PXA uarts
>>
>> ? ? Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>
> Hi Eric,
>
> Looks very good to me. Please find my
>
> Acked-by: Marc Zyngier <maz@misterjones.org>
>
Thanks. Will push the merged result (together with the rest of
your patches) after a while.
next prev parent reply other threads:[~2010-02-19 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 20:26 [PATCH 1/5] pxa/zeus: Allow usage of 8250-compatible UART in uncompress Marc Zyngier
2010-02-19 6:17 ` Eric Miao
2010-02-19 7:13 ` Marc Zyngier
2010-02-19 7:38 ` Eric Miao [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-18 20:27 Marc Zyngier
2010-02-18 20:34 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d71002182338t1a03d69r58ebb5dcf78eb414@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).