From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric.y.miao@gmail.com (Eric Miao) Date: Fri, 19 Feb 2010 15:38:10 +0800 Subject: [PATCH 1/5] pxa/zeus: Allow usage of 8250-compatible UART in uncompress In-Reply-To: <20100219071335.6b893aa7@taxman.wild-wind.fr.eu.org> References: <20100218202612.6d6385e6@taxman.wild-wind.fr.eu.org> <20100219071335.6b893aa7@taxman.wild-wind.fr.eu.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 19, 2010 at 3:13 PM, Marc Zyngier wrote: > On Fri, 19 Feb 2010 14:17:52 +0800 > Eric Miao wrote: > >> On Fri, Feb 19, 2010 at 4:26 AM, Marc Zyngier wrote: >> > Zeus console port is wired to a 8250-compatible device >> > (pxa UARTs are reserved to other uses). This patch >> > allows such a configuration in the uncompress sequence. >> > >> > It has been regression-tested on a Viper using FFUART. >> > >> > Signed-off-by: Marc Zyngier >> >> Hi Marc, >> >> I would like to modify the patch a little bit as follows (and into two), >> please let me know if you are OK (better to go with your Ack): >> >> ? ? [ARM] pxa: refactor uncompress.h for non-PXA uarts >> >> ? ? The original patch came from Marc Zyngier where support of 8250-compatible >> ? ? UART is required to show the uncompress information. Modified a little bit >> ? ? here, including changes below: >> >> ? ? 1. #include is actually not necessary >> ? ? 2. introduced uart_{read,write}() for different base and shift >> ? ? 3. introduced uart_is_enabled() and assumed enabled always for >> ? ? ? ?non-PXA uarts >> >> ? ? Signed-off-by: Eric Miao > > Hi Eric, > > Looks very good to me. Please find my > > Acked-by: Marc Zyngier > Thanks. Will push the merged result (together with the rest of your patches) after a while.