linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] locomo.c: spi register offset bugfix
Date: Mon, 22 Mar 2010 10:36:27 +0800	[thread overview]
Message-ID: <f17812d71003211936m33d39380l2b5c2638015b295e@mail.gmail.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269763683A71C0@AUSP01VMBX24.collaborationhost.net>

On Thu, Mar 11, 2010 at 1:11 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> The locomo spi registers are all defined in locomo.h as offsets
> from the first spi register LOCOMO_SPI (0x60), which is itself
> an offset from the locomo base address. ?To correctly access
> these registers LOCOMO_SPI must always be included in the
> address calculation.
>
> There are two places in locomo.c where this is not done. ?The
> first one, in locomo_suspend, actually results in a write to
> LOCOMO_ST instead of LOCOMO_SPICT. ?The second is in __locomo_probe
> and results in a write to LOCOMO_MCSX2 instead of LOCOMO_SPIIE.
>
> Fix these by including LOCOMO_SPI in the calculation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Eric Miao <eric.y.miao@gmail.com>
>

Applied to 'fix'.

      reply	other threads:[~2010-03-22  2:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 17:11 [PATCH] locomo.c: spi register offset bugfix H Hartley Sweeten
2010-03-22  2:36 ` Eric Miao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17812d71003211936m33d39380l2b5c2638015b295e@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).