From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA287C433DF for ; Fri, 14 Aug 2020 16:32:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 817BF2074D for ; Fri, 14 Aug 2020 16:32:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SmZ1HIy9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 817BF2074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lucaceresoli.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=obb9G3HXS1UYjUv2qcWxRBnXnRV5xExb1hcKUY58zio=; b=SmZ1HIy9fb1xbapEQEwia7n81 lHNh6zyS+dJz/cxmJF6UhuXMkiO3lRu7L5VbeJIVwTXcOIRK1l8HBZAhi+eBXvcYEU5EKWtv2UvoD HqxpvGPA4t7FRb3p/iM25sIsRnaSYhSId7JY19t7NoimnoYxql2w1i2hYuGWH+Mxd5kX4fiReJk8R eNC6tXt9GEB2Ob4XdlQC/inJBqDzpog6fhD9/asFJgcL648D5m1O5HwrMObxtLNNao0ePjkBAcddv dnzv9ZK+bvewF+IHJd0yKF2aRsCgMzFgwnhkfocNpVR/VWcVubHARbO9CZOG3ImL2xCUqOb3JdKIT DbOVt6bMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6cbA-0004nc-Ks; Fri, 14 Aug 2020 16:30:32 +0000 Received: from hostingweb31-40.netsons.net ([89.40.174.40]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6cb3-0004h2-LH; Fri, 14 Aug 2020 16:30:27 +0000 Received: from [37.160.38.175] (port=40734 helo=[192.168.42.162]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1k6cay-0001mB-F9; Fri, 14 Aug 2020 18:30:20 +0200 Subject: Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files To: Rob Herring References: <20200812203618.2656699-1-robh@kernel.org> From: Luca Ceresoli Message-ID: Date: Fri, 14 Aug 2020 18:30:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200814_123025_848770_5246D6A4 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Fbdev development list , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list:REMOTE PROCESSOR \(REMOTEPROC\) SUBSYSTEM" , Linux-ALSA , dri-devel , MTD Maling List , Linux I2C , linux-clk , "open list:REAL TIME CLOCK \(RTC\) SUBSYSTEM" , "open list:SERIAL DRIVERS" , Linux Input , Linux Media Mailing List , devicetree@vger.kernel.org, "open list:THERMAL" , "open list:GPIO SUBSYSTEM" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Linux HWMON List , netdev , Linux USB List , linux-mmc , "linux-kernel@vger.kernel.org" , linux-spi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 14/08/20 16:51, Rob Herring wrote: > On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: >> >> Hi Rob, >> >> On 12/08/20 22:36, Rob Herring wrote: >>> Clean-up incorrect indentation, extra spaces, long lines, and missing >>> EOF newline in schema files. Most of the clean-ups are for list >>> indentation which should always be 2 spaces more than the preceding >>> keyword. >>> >>> Found with yamllint (which I plan to integrate into the checks). >> >> [...] >> >>> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml >>> index 3d4e1685cc55..28c6461b9a9a 100644 >>> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml >>> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml >>> @@ -95,10 +95,10 @@ allOf: >>> # Devices without builtin crystal >>> properties: >>> clock-names: >>> - minItems: 1 >>> - maxItems: 2 >>> - items: >>> - enum: [ xin, clkin ] >>> + minItems: 1 >>> + maxItems: 2 >>> + items: >>> + enum: [ xin, clkin ] >>> clocks: >>> minItems: 1 >>> maxItems: 2 >> >> Thanks for noticing, LGTM. >> >> [...] >> >>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml >>> index d7dac16a3960..36dc7b56a453 100644 >>> --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml >>> +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml >>> @@ -33,8 +33,8 @@ properties: >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> >>> touchscreen-min-pressure: >>> - description: minimum pressure on the touchscreen to be achieved in order for the >>> - touchscreen driver to report a touch event. >>> + description: minimum pressure on the touchscreen to be achieved in order >>> + for the touchscreen driver to report a touch event. >> >> Out of personal taste, I find the original layout more pleasant and >> readable. This third option is also good, especially for long descriptions: >> >> description: >> minimum pressure on the touchscreen to be achieved in order for the >> touchscreen driver to report a touch event. >> >> At first glance yamllint seems to support exactly these two by default: >> >>> With indentation: {spaces: 4, check-multi-line-strings: true} > > Turning on check-multi-line-strings results in 10K+ warnings, so no. > > The other issue is the style ruamel.yaml wants to write out is as the > patch does above. This matters when doing some scripted > transformations where we read in the files and write them back out. I > can somewhat work around that by first doing a pass with no changes > and then another pass with the actual changes, but that's completely > scriptable. Hopefully, ruamel learns to preserve the style better. Kind of sad, but I understand the reason as far as my understanding of the yaml world allows. Thanks for the explanation. [For idt,versaclock5.yaml, plus an overview of whole patch] Reviewed-by: Luca Ceresoli -- Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel