From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FF59C43334 for ; Wed, 15 Jun 2022 03:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xDVqJk3b+g7duFLCNlFQXAmEgXAy1Nad+NqDXyBg1R8=; b=e2n6KrRmP5wd6X yNqDf1K/tXuvsf70CtUueThKfQbFmkGt/D6GHX9KBFgws3w48eX2RtsdyMS6HzwXQlbQYr/kpuwvR BzFwT0hA5NUNXbzMMrA05BgQ6XCTbe4jsrLhMVG71ZccKWf0V1/KhRO3p4petEEfd9rHsijDsSH02 tG53rzoXUXgbmnhvtnZbGQ/9rkOluhtt8yzd0GBVsvafjCkquc/XPuvtxZYhNVIpUkEvC67+iKcmZ raV+e6CtNpVog1oiprT+/whZzWO3WYFvDAnPsZZY82qn3AOibkyyVzmD9JWdcaLkdVQtarsRXEPAM 4m5fsO/FzBAm8Mi/Z2ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Js5-00CNQZ-EE; Wed, 15 Jun 2022 03:39:09 +0000 Received: from mx1.cqplus1.com ([113.204.237.245]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Js1-00CNPo-BS for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 03:39:07 +0000 X-MailGates: (flag:1,DYNAMIC,RELAY,NOHOST,LAN:PASS)(compute_score:DELIVE R,40,3) Received: from 172.27.96.203 by mx1.cqplus1.com with MailGates ESMTP Server V5.0(28649:0:AUTH_RELAY) (envelope-from ); Wed, 15 Jun 2022 11:31:54 +0800 (CST) Received: from CQEXMAIL01.cqplus1.com (172.27.96.203) by CQEXMAIL01.cqplus1.com (172.27.96.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Wed, 15 Jun 2022 11:31:50 +0800 Received: from CQEXMAIL01.cqplus1.com ([::1]) by CQEXMAIL01.cqplus1.com ([::1]) with mapi id 15.01.2507.006; Wed, 15 Jun 2022 11:31:50 +0800 From: =?utf-8?B?cWluamlhblvopoPlgaVd?= To: Arnd Bergmann CC: Stephen Boyd , Krzysztof Kozlowski , Rob Herring , Michael Turquette , Russell King - ARM Linux , Olof Johansson , SoC Team , Linux ARM , DTML , Linux Kernel Mailing List , linux-clk Subject: RE: [PATCH v18 10/10] ARM: dts: Add Sunplus SP7021-Demo-V3 board device tree Thread-Topic: [PATCH v18 10/10] ARM: dts: Add Sunplus SP7021-Demo-V3 board device tree Thread-Index: AQHYf8r27MMUrQucmUWH+5A1oaj77q1OMQ+AgAGftCA= Date: Wed, 15 Jun 2022 03:31:50 +0000 Message-ID: References: <0574ed0ad1e9ec4c12645fe2d2dde8f701d285e5.1655194858.git.qinjian@cqplus1.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.110.18] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_203905_782182_5750D4AD X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > I'll wait for a final Ack from Krzysztof before applying this. > > > A few more details I noticed: > > > > +/ { > > + compatible = "sunplus,sp7021"; > > + model = "Sunplus SP7021"; > > + > > + aliases { > > + serial0 = &uart0; > > + serial1 = &uart1; > > + serial2 = &uart2; > > + serial3 = &uart3; > > + serial4 = &uart4; > > + }; > > Some of these are disabled, presumably because they are not > actually connected on all boards. Better move the aliases to the .dts file > and only list the ports that are in fact used, using the numbering that > matches the labels on the board, not the numbers inside of the SoC > > > + > > + soc { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + interrupt-parent = <&intc>; > > + > > + intc: interrupt-controller@9c000780 { > > + compatible = "sunplus,sp7021-intc"; > > + reg = <0x9c000780 0x80>, <0x9c000a80 0x80>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > All child nodes below /soc have registers in the 0x9c000000 range. I would > suggest you use a matching 'ranges' property to translate these into a > zero-based > address like > > /soc { > ranges = <0 0x9c000000 0x10000>; > > interrupt-controller@780 { > reg = <0x780 0x80>, <0xa80 0x80>; > ... > }; > }; > > > + clkc: clock-controller@9c000004 { > > + compatible = "sunplus,sp7021-clkc"; > > + reg = <0x9c000004 0x28>, > > + <0x9c000200 0x44>, > > + <0x9c000268 0x04>; > > + clocks = <&extclk>; > > + #clock-cells = <1>; > > + }; > > + > > + rstc: reset@9c000054 { > > + compatible = "sunplus,sp7021-reset"; > > + reg = <0x9c000054 0x28>; > > + #reset-cells = <1>; > > + }; > > > Maybe sort the nodes by address, or possibly by name. > > Arnd Thanks for your comments, I'll fix these in next patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel