From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1227ECAAD5 for ; Mon, 29 Aug 2022 16:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F91NF7aTMvUnGxn0MYpwQX3MIT3OxhJxOXHZmsmxGj4=; b=zKp08vq6QFtsQ3tPVoipIGcR8x HCuB3AsZVRgLbJh0dy9c/2Vgma2WP42Ge8XG7ue70GY+1qaf5E2gwAK5n5eH4JJs9Gx2ojjcfXUjv Ioa+brG63PH9LSxHHw8GvFhO+ov0avZ4uRCg3ApILdOlq52LhxdgbLrXMdIHVUNxttL2LD7m7HecW cNNk3zhQEMWnybNgVB2sjyacgUDFiKLd9ltndXY95NJQWggYu5E/mGAH1JcbbC+/fY2V1KLps7LhQ N3CLfQSTM1SvPqaEVzpL+yzF6hPUG83nheSyhD8qQzHKCUPm4/TsPBllDoaMN2I3+/oaF9HNPCYaC AuQCbffQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oShTJ-00BgQX-Bk; Mon, 29 Aug 2022 16:18:46 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oShO4-00BdwF-Ge; Mon, 29 Aug 2022 16:13:22 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 3FDD418848CD; Mon, 29 Aug 2022 16:13:15 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 36E6B25032B7; Mon, 29 Aug 2022 16:13:15 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 26D919EC0004; Mon, 29 Aug 2022 16:13:15 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Mon, 29 Aug 2022 18:13:14 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests In-Reply-To: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-7-netdev@kapio-technology.com> <7654860e4d7d43c15d482c6caeb6a773@kapio-technology.com> <2967ccc234bb672f5440a4b175b73768@kapio-technology.com> <9e1a9eb218bbaa0d36cb98ff5d4b97d7@kapio-technology.com> <69db7606896c77924c11a6c175c4b1a6@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_091320_775352_31CD337B X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-29 18:03, Ido Schimmel wrote: > On Mon, Aug 29, 2022 at 05:08:23PM +0200, netdev@kapio-technology.com > wrote: >> On 2022-08-29 16:37, Ido Schimmel wrote: >> > On Mon, Aug 29, 2022 at 02:04:42PM +0200, netdev@kapio-technology.com >> > wrote: >> > > On 2022-08-29 13:32, Ido Schimmel wrote: >> > > Port association is needed for MAB to work at all on mv88e6xxx, but >> > > for >> > > 802.1X port association is only needed for dynamic ATU entries. >> > >> > Ageing of dynamic entries in the bridge requires learning to be on as >> > well, but in these test cases you are only using static entries and >> > there is no reason to enable learning in the bridge for that. I prefer >> > not to leak this mv88e6xxx implementation detail to user space and >> > instead have the driver enable port association based on whether >> > "learning" or "mab" is on. >> > >> >> Then it makes most sense to have the mv88e6xxx driver enable port >> association when then port is locked, as it does now. > > As you wish, but like you wrote "802.1X port association is only needed > for dynamic ATU entries" and in this case user space needs to enable > learning (for refresh only) so you can really key off learning on > "learning || mab". User space can decide to lock the port and work with > static entries and then learning is not required. I will of course remove all "learning on" in the selftests, which is what I think you are referring to. In the previous I am referring to the code in the driver itself which I understand shall turn on port association with locked ports, e.g. no need for "learning on" when using the feature in general outside selftests... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel