Re: [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code - Alejandro Colomar (man-pages)

From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Borislav Petkov <bp@suse.de>, Corey Minyard <cminyard@mvista.com>,
	Chris Mason <clm@fb.com>,
	Christian Brauner <christian.brauner@ubuntu.com>,
	David Sterba <dsterba@suse.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Jason Wang <jasowang@redhat.com>,
	Jitendra Bhivare <jitendra.bhivare@broadcom.com>,
	John Hubbard <jhubbard@nvidia.com>,
	"John S . Gruber" <JohnSGruber@gmail.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Josef Bacik <josef@toxicpanda.com>,
	Kees Cook <keescook@chromium.org>,
	Ketan Mukadam <ketan.mukadam@broadcom.com>,
	Len Brown <lenb@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Russell King <linux@armlinux.org.uk>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
	Subbu Seetharaman <subbu.seetharaman@broadcom.com>,
	intel-gfx@lists.freedesktop.org, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-btrfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code
Date: Fri, 19 Nov 2021 16:38:46 +0100	[thread overview]
Message-ID: <f1a90f53-060e-2960-3926-e30b44a1be28@gmail.com> (raw)
In-Reply-To: <YZfEHZa3f5MXeqoH@smile.fi.intel.com>

Hi Andy,

On 11/19/21 16:34, Andy Shevchenko wrote:
> On Fri, Nov 19, 2021 at 04:06:27PM +0100, Alejandro Colomar (man-pages) wrote:
>> Yes, I would like to untangle the dependencies.
>>
>> The main reason I started doing this splitting
>> is because I wouldn't be able to include
>> <linux/stddef.h> in some headers,
>> because it pulled too much stuff that broke unrelated things.
>>
>> So that's why I started from there.
>>
>> I for example would like to get NULL in memberof()
>> without puling anything else,
>> so <linux/NULL.h> makes sense for that.
> 
> I don't believe that the code that uses NULL won't include types.h.

I'm not sure about the error I got (I didn't write it down),
but I got a compilation error.
That's why I split NULL.

If one could anwer my doubt,
I would be in better position to learn how to avoid them.
See below.

On 11/19/21 16:06, Alejandro Colomar (man-pages) wrote:
> BTW, I also have a longstanding doubt about
> how header files are organized in the kernel,
> and which headers can and cannot be included
> from which other files.
>
> For example I see that files in samples or scripts or tools,
> that redefine many things such as offsetof() or ARRAY_SIZE(),
> and I don't know if there's a good reason for that,
> or if I should simply remove all that stuff and
> include <linux/offsetof.h> everywhere I see offsetof() being used.

Thanks,
Alex

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel