From: Marc Zyngier <maz@kernel.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: linux-kernel@vger.kernel.org, linuxarm@openeuler.org,
eric.auger@redhat.com, "Wangzhou \(B\)" <wangzhou1@hisilicon.com>,
"Zengtao \(B\)" <prime.zeng@hisilicon.com>,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] genirq/msi: Make sure early activation of all PCI MSIs
Date: Sat, 23 Jan 2021 12:32:53 +0000 [thread overview]
Message-ID: <f1aceff55b3580194b41b812ba7ffb76@kernel.org> (raw)
In-Reply-To: <c084871426cb4c9b9e0fe0684ca4c276@huawei.com>
Hi Shameer,
On 2021-01-22 09:21, Shameerali Kolothum Thodi wrote:
> Hi Marc,
>
[...]
>> I find this pretty complicated, and the I'd like to avoid injecting
>> the PCI
>> MSI-vs-MSI-X concept in something that is supposed to be bus-agnostic.
>
> Agree. That’s mainly because I was very skeptical(TBH, very limited in
> my knowledge
> on this msi core code) about changing the MSI-X activation logic here
> and just thought
> of limiting the impact to MSI case as a first attempt.
>
>> What's wrong with the following (untested) patch, which looks much
>> simpler?
>
> Yes, had tried this as one of the early fix, but as said above was not
> very sure of
> the impact on other platforms. Tested this again and it works.
>
> Please send it.
Actually, there is a better way, which is to have a proper iterator on
vectors instead of descriptors. With that and a bit of cleanup, the
patch[1] looks pretty neat.
Please give it a go.
Thanks,
M.
[1] https://lore.kernel.org/r/20210123122759.1781359-1-maz@kernel.org
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-01-23 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 11:02 [PATCH] genirq/msi: Make sure early activation of all PCI MSIs Shameer Kolothum
2021-01-21 21:25 ` Marc Zyngier
2021-01-22 9:21 ` Shameerali Kolothum Thodi
2021-01-23 12:32 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1aceff55b3580194b41b812ba7ffb76@kernel.org \
--to=maz@kernel.org \
--cc=eric.auger@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=prime.zeng@hisilicon.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tglx@linutronix.de \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).