From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A34C433E0 for ; Fri, 29 Jan 2021 18:13:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 964AB64E08 for ; Fri, 29 Jan 2021 18:13:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 964AB64E08 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y4dNhX1HeOF8iLFC//Zl5vnTn+hsGxN2juuhEkgTvYA=; b=fFfONSTkl4p6+5mPl+PDo6Jsr zLnMsxnml2/KJv0+oCObGneHJmZ/YyLlUCGU8XhSSNF6YXhxsl/VV3ovBhDK99tYT4b/s8xPrfybi 9MyOt/a0MerlWXvjrwGeAnJ9N7xC01pV8Hr2voZ/4J8VevaoxMquDE6uEbvU//Wu9Or8v8HNZNzFZ 4R/UN9VtGbjZ94342fpO9Ml11T10caCaNLPbNZm8AeI+pXE7zJtg+IkcUrMvgRtTjYCvPO7ATr1DY dqs831Kua9IX8kcVLjP19BoYZpG0u2GiDBpuVKmkaRV72zLk1yUB6a1BOIs8q9D6SIc0mCUoQpaS6 s//iyOSGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5YGB-0007zZ-Du; Fri, 29 Jan 2021 18:12:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5YG8-0007yo-8X for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 18:12:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B969913A1; Fri, 29 Jan 2021 10:12:37 -0800 (PST) Received: from [10.37.12.11] (unknown [10.37.12.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F5033F885; Fri, 29 Jan 2021 10:12:35 -0800 (PST) Subject: Re: [PATCH v9 3/4] kasan: Add report for async mode To: Andrey Konovalov , Alexander Potapenko References: <20210126134603.49759-1-vincenzo.frascino@arm.com> <20210126134603.49759-4-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Fri, 29 Jan 2021 18:16:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_131240_410507_70798871 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Catalin Marinas , Evgenii Stepanov , LKML , kasan-dev , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/29/21 6:09 PM, Andrey Konovalov wrote: > On Fri, Jan 29, 2021 at 6:56 PM Vincenzo Frascino > wrote: >> >> Hi Andrey, >> >> On 1/29/21 5:40 PM, Andrey Konovalov wrote: >>> I suggest to call end_report(&flags, 0) here and check addr !=0 in >>> end_report() before calling trace_error_report_end(). >>> >> >> Probably this is better as: >> >> if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) >> >> Because that condition passes always addr == 0. > > Not sure I understand. Call report_end(&flags, 0) and then there do: > > if (addr) trace_error_report_end(...); > > Although maybe it makes sense to still trace all async bugs to address > 0. Or to some magic address. > > Alex, WDYT? > What I meant is instead of: if (addr) trace_error_report_end(...); you might want to do: if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) trace_error_report_end(...); because, could make sense to trace 0 in other cases? I could not find the implementation of trace_error_report_end() hence I am not really sure on what it does. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel