From: Krzysztof Kozlowski <krzk@kernel.org>
To: "olivia.wen" <olivia.wen@mediatek.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Tinghan Shen <tinghan.shen@mediatek.com>,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
jason-ch.chen@mediatek.com, yaya.chang@mediatek.com,
teddy.chen@mediatek.com
Subject: Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1
Date: Thu, 11 Apr 2024 08:07:29 +0200 [thread overview]
Message-ID: <f1bdf524-17b4-4cce-a7ed-abc97786c975@kernel.org> (raw)
In-Reply-To: <20240411033750.6476-3-olivia.wen@mediatek.com>
On 11/04/2024 05:37, olivia.wen wrote:
> +};
> +
> static const struct of_device_id mtk_scp_of_match[] = {
> { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data },
> { .compatible = "mediatek,mt8186-scp", .data = &mt8186_of_data },
> @@ -1323,6 +1362,7 @@ static const struct of_device_id mtk_scp_of_match[] = {
> { .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data },
> { .compatible = "mediatek,mt8195-scp", .data = &mt8195_of_data },
> { .compatible = "mediatek,mt8195-scp-dual", .data = &mt8195_of_data_cores },
> + { .compatible = "mediatek,mt8188-scp-dual", .data = &mt8188_of_data_cores },
Why do you add new entries to the end? Look at the list first.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-11 6:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 3:37 [PATCH 0/2] Support MT8188 SCP core 1 olivia.wen
2024-04-11 3:37 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP olivia.wen
2024-04-11 6:06 ` Krzysztof Kozlowski
2024-04-12 11:00 ` Olivia Wen (温倩苓)
2024-04-11 7:34 ` AngeloGioacchino Del Regno
2024-04-11 7:39 ` AngeloGioacchino Del Regno
2024-04-12 10:18 ` Olivia Wen (温倩苓)
2024-04-12 11:01 ` Olivia Wen (温倩苓)
2024-04-24 0:58 ` Olivia Wen (温倩苓)
2024-04-11 3:37 ` [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1 olivia.wen
2024-04-11 6:07 ` Krzysztof Kozlowski [this message]
2024-04-12 11:06 ` Olivia Wen (温倩苓)
2024-04-11 7:33 ` AngeloGioacchino Del Regno
2024-04-12 10:49 ` Olivia Wen (温倩苓)
2024-04-12 11:26 ` Olivia Wen (温倩苓)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1bdf524-17b4-4cce-a7ed-abc97786c975@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jason-ch.chen@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=olivia.wen@mediatek.com \
--cc=robh@kernel.org \
--cc=teddy.chen@mediatek.com \
--cc=tinghan.shen@mediatek.com \
--cc=yaya.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).