From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95067C7EE23 for ; Mon, 5 Jun 2023 17:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YU9dTlq64Hx1Im7yAJVGNe2CC8+F9MFCwQOFPmoy9kw=; b=YOl2Ha6wimiv94 Bmt8r/cB4gSnUtwPBEGW+gq9TRvh0ohEq1MMNuqB0Mvo0nGKrsDmynpziemxMbSKnfadGC2aiFxQZ kaXxmnuNHz5wNbHH0hilj5YwwAZvXitcnc6GVtwKMFOFrHDWmH7BKgfRyYueBRt98j0FAfmXESs6k H3BVGXNl7mZLYT+I/PwN6LvRgX2G2pIthNb3mvLwWKYO4ApPxegujJrhqsa+gSUGkSuBUGrV8lDFb 0VRWkObt8o+XT7LReIRLAzeuEroSBrKeSJ8/1dIvAEv7KwQUE10YMXa58KKCd5dtHRhj/v2b3pNh0 etMeID7BXaoIZAarQE7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6DaE-00GDOX-32; Mon, 05 Jun 2023 17:01:30 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6DaB-00GDMM-2H for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 17:01:29 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 355H1Lgw079322; Mon, 5 Jun 2023 12:01:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685984481; bh=lSN/X+qqnpCellhQEw5dxATrMURNyrkvsY0vQP4ikJM=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=CBHT4DeI4oxj8DHwfolcqCHBUJ/FWs201zbAmJcO51B0D75zJ5USEON6d1ZleX8y2 sQfbihKtUR40SD35q8WX2H32hjU6r5vpO5cOAVx6Mttrw9oVYcvxwxety9VUVqAJcJ 7bB+5DYZwz59PvQ8cdNF6vu9LJdIaxIfvNLFRjB8= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 355H1L3d103642 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Jun 2023 12:01:21 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 5 Jun 2023 12:01:21 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Jun 2023 12:01:21 -0500 Received: from [10.249.141.75] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 355H1H5e104461; Mon, 5 Jun 2023 12:01:18 -0500 Message-ID: Date: Mon, 5 Jun 2023 22:31:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 03/12] arm64: dts: ti: k3-j721e-beagleboneai64: Fixup reference to phandles array Content-Language: en-US To: Nishanth Menon , Conor Dooley , Krzysztof Kozlowski , Rob Herring CC: , , , Tero Kristo , Vignesh Raghavendra , Robert Nelson References: <20230601152636.858553-1-nm@ti.com> <20230601152636.858553-4-nm@ti.com> From: "Kumar, Udit" In-Reply-To: <20230601152636.858553-4-nm@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_100127_820173_FFAAECCB X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth On 6/1/2023 8:56 PM, Nishanth Menon wrote: > When referring to array of phandles, using <> to separate the array > entries is better notation as it makes potential errors with phandle and > cell arguments easier to catch. Fix the outliers to be consistent with > the rest of the usage. > > Cc: Robert Nelson > Signed-off-by: Nishanth Menon > --- > .../boot/dts/ti/k3-j721e-beagleboneai64.dts | 29 ++++++++++--------- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > index 37c24b077b6a..c13246a9ed8f 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > @@ -593,7 +593,7 @@ &main_i2c0 { > &main_i2c1 { > status = "okay"; > pinctrl-names = "default"; > - pinctrl-0 = <&main_i2c1_pins_default &csi1_gpio_pins_default>; > + pinctrl-0 = <&main_i2c1_pins_default>, <&csi1_gpio_pins_default>; > clock-frequency = <400000>; > }; > > @@ -623,7 +623,7 @@ &main_i2c4 { > &main_i2c5 { > status = "okay"; > pinctrl-names = "default"; > - pinctrl-0 = <&main_i2c5_pins_default &csi0_gpio_pins_default>; > + pinctrl-0 = <&main_i2c5_pins_default>, <&csi0_gpio_pins_default>; > clock-frequency = <400000>; > }; > > @@ -639,7 +639,7 @@ &main_i2c6 { > &wkup_i2c0 { > status = "okay"; > pinctrl-names = "default"; > - pinctrl-0 = <&wkup_i2c0_pins_default &eeprom_wp_pins_default>; > + pinctrl-0 = <&wkup_i2c0_pins_default>, <&eeprom_wp_pins_default>; > clock-frequency = <400000>; Why we need more than 2 pio lines for i2c node , > [...] > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel