From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E97AC52D7C for ; Mon, 19 Aug 2024 17:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8kiYpity7QE9fjnTaEN0Otfc5NaWtjeUHbIZaw5EgeU=; b=uT+j0T/Z3T8suCH882RmSir/6J xvufMD5U2qhCQ/e6wnS6DBPYX9jy62RnUoxQcme+vhYnI1GjHifHWXOMeQH660YU/ad2jbfS0zsZW qj1cgNidGBrl6rzMC0uSlLRVNsXDqcDVtvEBUtAwPufjN4uNQsfklqDrM8SpMHjbqpeJwgkmv2YvK qnZGTUnxB3+6rPrpyJfr9WzIEaa5humme9He/q3FTXz8YaKUGJtmchkbJaBnW0g2FNQ/S1zGTZqzg r8UUcAXXVDF4nYkkaxyO56VX65DeXJ5Qu7u6reXnEYi4+1dyviR4Wb2E4Ry+CweNjzKi5fOMV941P xJnWqJjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg6Vl-00000002T9a-2t5w; Mon, 19 Aug 2024 17:49:45 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg6V4-00000002SzR-3F4J for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 17:49:04 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-7a1d5f6c56fso315920485a.0 for ; Mon, 19 Aug 2024 10:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1724089741; x=1724694541; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=8kiYpity7QE9fjnTaEN0Otfc5NaWtjeUHbIZaw5EgeU=; b=Z2wb62eU0VhNG7rrNdW3mslypgRBlQOPFtB01IwRI9DUEcNsT3LwDiXjKyi+QENsPo vQtK0nefPBqSzFDTarE43H9XhJhE3dPnkYreOSx4AoURoG33n0o9hAj6dJk8zRvyuvFl N6fv46dBbTLjg+eipWmxpB50eytGrc+3J34aU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724089741; x=1724694541; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8kiYpity7QE9fjnTaEN0Otfc5NaWtjeUHbIZaw5EgeU=; b=tljyXE1ebD3+rwxsNgulSVmbwYOvNn1s1sX5qaAIb9Z0H/QJrhvuK35s6DZVXY+EQj qzoIkPM7iLPA2Cgmx9GEFkmX5JP1ACW/IVX5SzlsLyndnDwiveXEQLbep8rorFIYZjYT lCBubID1/6SgFp140B7QnrDwiSxPqmZPlJEbnXTcB9YF+OX0M6MfggwzhHq/NJdzu9oP /KbTuBrnZBFN3NZvFk16J6E7hhE6qK7IX/+ZybUv3u7RQxCRNWGYHXhOLFCCW6E0HU/u XdxvKub4qVni1mWKI/6SZ6GOb0jzhKlgWgWPoIPYmR9x4MCPEOSyNX1IGCDAP8gefMSi QV1w== X-Forwarded-Encrypted: i=1; AJvYcCXdIul+TyVu8AYkMk08wHiEi2bk46lberNEM7dapVeNidBjJmsI6aMEt7JRchXPNL01eSkT4sbDWMhmwLukf9K+q/SR4iFYHUB42tYq9H7NftmYEqk= X-Gm-Message-State: AOJu0Yy/2BKJed96YVuBhL7qoANAhZ0Bv15Gsqj85/ApCGbStBBWfSEy 6/9h7WNxRir6jAyg3B/2VSwhFR4Io8hLia8qU7/vCdRsDrrZIXRtBat2RpYPiQ== X-Google-Smtp-Source: AGHT+IEjyKNVNzbiz9tq6nMYcRZoQu3gCMdJn9f0E8cT9KI+QQeYl6RdoIIb8dSnN6MK5wEoCPF6AQ== X-Received: by 2002:a05:620a:4312:b0:79c:fbf:6381 with SMTP id af79cd13be357-7a5069df09cmr1005035485a.70.1724089740635; Mon, 19 Aug 2024 10:49:00 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4536a04e4f2sm42095151cf.69.2024.08.19.10.48.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 10:48:59 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 10:48:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/13] PCI: brcnstb: Enable STB 7712 SOC To: Jim Quinlan , Manivannan Sadhasivam Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring References: <20240815225731.40276-1-james.quinlan@broadcom.com> <20240816071822.GO2331@thinkpad> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_104902_835060_E18D2044 X-CRM114-Status: GOOD ( 16.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/19/24 10:44, Jim Quinlan wrote: > On Fri, Aug 16, 2024 at 3:18 AM Manivannan Sadhasivam > wrote: >> >> On Thu, Aug 15, 2024 at 06:57:13PM -0400, Jim Quinlan wrote: >>> V6 Changes >>> o Commit "Refactor for chips with many regular inbound windows" >>> -- Use u8 for anything storing/counting # inbound windows (Stan) >>> -- s/set_bar/add_inbound_win/g (Manivannan) >>> -- Drop use of "inline" (Manivannan) >>> -- Change cpu_beg to cpu_start, same with pcie_beg. (Manivannan) >>> -- Used writel_relaxed() (Manivannan) >>> o Use swinit reset if available >>> -- Proper use of dev_err_probe() (Stan) >>> o Commit "Use common error handling code in brcm_pcie_probe()" >>> -- Rewrite commit msg in paragraph form (Manivannan) >>> -- Refactor error path at end of probe func (Manivannan) >>> -- Proper use of dev_err_probe() (Stan) >>> o New commit "dt-bindings: PCI: Change brcmstb maintainer and cleanup" >>> -- Break out maintainer change and small cleanup into a >>> separate commit (Krzysztof) >>> >> >> Looks like you've missed adding the review tags... > > > I didn't mention this in the cover letter but I update the review tags > at each version. The problem is that if someone has reviewed a > commit, and then that commit is subsequently changed due to another > reviewer, I have to remove the existing tag of the first reviewer > because the code has changed. It seems to me like you did the right thing here, the changes you did between v5 and v6 were substantial enough they invalidated the Reviewed-by tag(s) you had gotten previously. -- Florian