* [RESEND PATCH 0/2] Remove the mistakes detected by the check tools.
@ 2016-01-20 6:39 Eric Long
2016-01-20 6:39 ` [RESEND PATCH 1/2] coresight: tmc/etm4x: Remove the mistakes detected by sparse tool Eric Long
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Eric Long @ 2016-01-20 6:39 UTC (permalink / raw)
To: linux-arm-kernel
Both of the two patches optimize the code and remove the mistakes and
warnings detected by the check tools.
Eric Long (2):
coresight: tmc/etm4x: Remove the mistakes detected by sparse tool
coresight: Remove the mistakes detected by smatch tool
drivers/hwtracing/coresight/coresight-etm4x.c | 2 +-
drivers/hwtracing/coresight/coresight-tmc.c | 6 +++---
drivers/hwtracing/coresight/of_coresight.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH 1/2] coresight: tmc/etm4x: Remove the mistakes detected by sparse tool
2016-01-20 6:39 [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Eric Long
@ 2016-01-20 6:39 ` Eric Long
2016-01-20 6:39 ` [RESEND PATCH 2/2] coresight: Remove the mistakes detected by smatch tool Eric Long
2016-01-21 16:56 ` [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Mathieu Poirier
2 siblings, 0 replies; 6+ messages in thread
From: Eric Long @ 2016-01-20 6:39 UTC (permalink / raw)
To: linux-arm-kernel
The dma_alloc_coherent return an "void *" not an "void __iomen *".
It uses the wrong parameters when calls dma_free coherent function,
and "DEVICE_ATTR_RO" should be defined as static.
The sparse tool output logs as the following:
coresight-etm4x.c:2224:1: warning: symbol 'dev_attr_trcoslsr' was
not declared. Should it be static?
coresight-etm4x.c:2225:1: warning: symbol 'dev_attr_trcpdcr' was
not declared. Should it be static?
coresight-etm4x.c:2226:1: warning: symbol 'dev_attr_trcpdsr' was
not declared. Should it be static?
coresight-tmc.c:199:23: warning: incorrect type in argument 1
(different address spaces)
coresight-tmc.c:199:23: expected void *<noident>
coresight-tmc.c:199:23: got void [noderef] <asn:2>*vaddr
coresight-tmc.c:336:30: warning: incorrect type in assignment
(different address spaces)
coresight-tmc.c:336:30: expected char *buf
coresight-tmc.c:336:30: got void [noderef] <asn:2>*
coresight-tmc.c:769:50: warning: incorrect type in argument 4
(different base types)
coresight-tmc.c:769:50: expected unsigned long long
[unsigned] [usertype] dma_handle
coresight-tmc.c:769:50: got restricted gfp_t
Signed-off-by: Eric Long <eric.long@linaro.org>
---
drivers/hwtracing/coresight/coresight-etm4x.c | 2 +-
drivers/hwtracing/coresight/coresight-tmc.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index a670764..1ec6798 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -2219,7 +2219,7 @@ static ssize_t name##_show(struct device *_dev, \
return scnprintf(buf, PAGE_SIZE, "0x%x\n", \
readl_relaxed(drvdata->base + offset)); \
} \
-DEVICE_ATTR_RO(name)
+static DEVICE_ATTR_RO(name)
coresight_simple_func(trcoslsr, TRCOSLSR);
coresight_simple_func(trcpdcr, TRCPDCR);
diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
index a57c7ec..5b052d1 100644
--- a/drivers/hwtracing/coresight/coresight-tmc.c
+++ b/drivers/hwtracing/coresight/coresight-tmc.c
@@ -124,7 +124,7 @@ struct tmc_drvdata {
bool reading;
char *buf;
dma_addr_t paddr;
- void __iomem *vaddr;
+ void *vaddr;
u32 size;
bool enable;
enum tmc_config_type config_type;
@@ -766,7 +766,7 @@ err_misc_register:
err_devm_kzalloc:
if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)
dma_free_coherent(dev, drvdata->size,
- &drvdata->paddr, GFP_KERNEL);
+ drvdata->vaddr, drvdata->paddr);
return ret;
}
@@ -778,7 +778,7 @@ static int tmc_remove(struct amba_device *adev)
coresight_unregister(drvdata->csdev);
if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)
dma_free_coherent(drvdata->dev, drvdata->size,
- &drvdata->paddr, GFP_KERNEL);
+ drvdata->vaddr, drvdata->paddr);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RESEND PATCH 2/2] coresight: Remove the mistakes detected by smatch tool
2016-01-20 6:39 [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Eric Long
2016-01-20 6:39 ` [RESEND PATCH 1/2] coresight: tmc/etm4x: Remove the mistakes detected by sparse tool Eric Long
@ 2016-01-20 6:39 ` Eric Long
2016-01-21 16:56 ` [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Mathieu Poirier
2 siblings, 0 replies; 6+ messages in thread
From: Eric Long @ 2016-01-20 6:39 UTC (permalink / raw)
To: linux-arm-kernel
There is an unnecessary space at the front of the code.
The smatch tool output logs as the following:
of_coresight.c:89 of_coresight_alloc_memory() warn:
inconsistent indenting
Signed-off-by: Eric Long <eric.long@linaro.org>
---
drivers/hwtracing/coresight/of_coresight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index b097361..3cc57c1 100644
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c
@@ -86,7 +86,7 @@ static int of_coresight_alloc_memory(struct device *dev,
return -ENOMEM;
/* Children connected to this component via @outports */
- pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
+ pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
sizeof(*pdata->child_names),
GFP_KERNEL);
if (!pdata->child_names)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RESEND PATCH 0/2] Remove the mistakes detected by the check tools.
2016-01-20 6:39 [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Eric Long
2016-01-20 6:39 ` [RESEND PATCH 1/2] coresight: tmc/etm4x: Remove the mistakes detected by sparse tool Eric Long
2016-01-20 6:39 ` [RESEND PATCH 2/2] coresight: Remove the mistakes detected by smatch tool Eric Long
@ 2016-01-21 16:56 ` Mathieu Poirier
2016-01-22 9:15 ` Eric Long
2 siblings, 1 reply; 6+ messages in thread
From: Mathieu Poirier @ 2016-01-21 16:56 UTC (permalink / raw)
To: linux-arm-kernel
On 19 January 2016 at 23:39, Eric Long <eric.long@linaro.org> wrote:
> Both of the two patches optimize the code and remove the mistakes and
> warnings detected by the check tools.
>
> Eric Long (2):
> coresight: tmc/etm4x: Remove the mistakes detected by sparse tool
> coresight: Remove the mistakes detected by smatch tool
>
> drivers/hwtracing/coresight/coresight-etm4x.c | 2 +-
> drivers/hwtracing/coresight/coresight-tmc.c | 6 +++---
> drivers/hwtracing/coresight/of_coresight.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
Please run checkpath.pl on your patches. Also if the changes are of a
different nature, ex. indentation problem and wrong argument to a
function, please provide two separate patches.
Thanks,
Mathieu
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH 0/2] Remove the mistakes detected by the check tools.
2016-01-21 16:56 ` [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Mathieu Poirier
@ 2016-01-22 9:15 ` Eric Long
2016-01-22 17:29 ` Mathieu Poirier
0 siblings, 1 reply; 6+ messages in thread
From: Eric Long @ 2016-01-22 9:15 UTC (permalink / raw)
To: linux-arm-kernel
On 22 January 2016 at 00:56, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>
> Please run checkpath.pl on your patches. Also if the changes are of a
> different nature, ex. indentation problem and wrong argument to a
> function, please provide two separate patches.
>
Hi Mathieu,
I had already ran checkpath.pl, and there was no error and warning.
All the changes are either indentation problems or wrong argument,
except one static defined problem. So I think there is no need to
separate the patch.
By the way, the patches I had send were created base on the check
tools, one for smatch and another for sparse. In case I need to separate
the patches, do I need to follow the this principle. Thanks.
Best Regards.
Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH 0/2] Remove the mistakes detected by the check tools.
2016-01-22 9:15 ` Eric Long
@ 2016-01-22 17:29 ` Mathieu Poirier
0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Poirier @ 2016-01-22 17:29 UTC (permalink / raw)
To: linux-arm-kernel
On 22 January 2016 at 02:15, Eric Long <eric.long@linaro.org> wrote:
> On 22 January 2016 at 00:56, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>>
>> Please run checkpath.pl on your patches. Also if the changes are of a
>> different nature, ex. indentation problem and wrong argument to a
>> function, please provide two separate patches.
>>
>
> Hi Mathieu,
>
> I had already ran checkpath.pl, and there was no error and warning.
Using a 4.4 kernel I got the following chackpatch warnings:
mpoirier at t430:~/work/linaro/coresight/kernel-maint$
./scripts/checkpatch.pl
0001-coresight-Remove-the-mistakes-detected-by-sparse-too.patch
0002-coresight-Remove-the-mistakes-detected-by-smatch-too.patch
---------------------------------------------------------------
0001-coresight-Remove-the-mistakes-detected-by-sparse-too.patch
---------------------------------------------------------------
WARNING: A patch subject line should describe the change not the tool
that found it
#4:
Subject: [PATCH 1/2] coresight: Remove the mistakes detected by sparse tool
total: 0 errors, 1 warnings, 32 lines checked
0001-coresight-Remove-the-mistakes-detected-by-sparse-too.patch has
style problems, please review.
---------------------------------------------------------------
0002-coresight-Remove-the-mistakes-detected-by-smatch-too.patch
---------------------------------------------------------------
WARNING: A patch subject line should describe the change not the tool
that found it
#4:
Subject: [PATCH 2/2] coresight: Remove the mistakes detected by smatch tool
total: 0 errors, 1 warnings, 8 lines checked
0002-coresight-Remove-the-mistakes-detected-by-smatch-too.patch has
style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
mpoirier at t430:~/work/linaro/coresight/kernel-maint$ ls
> All the changes are either indentation problems or wrong argument,
> except one static defined problem. So I think there is no need to
> separate the patch.
After fixing the above checkpatch warning bunching changes by tools
won't make sense anymore.
> By the way, the patches I had send were created base on the check
> tools, one for smatch and another for sparse. In case I need to separate
> the patches, do I need to follow the this principle. Thanks.
It's usually one semantic change per patch - the tool that highlighted
the problem is secondary.
>
> Best Regards.
> Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-22 17:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-20 6:39 [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Eric Long
2016-01-20 6:39 ` [RESEND PATCH 1/2] coresight: tmc/etm4x: Remove the mistakes detected by sparse tool Eric Long
2016-01-20 6:39 ` [RESEND PATCH 2/2] coresight: Remove the mistakes detected by smatch tool Eric Long
2016-01-21 16:56 ` [RESEND PATCH 0/2] Remove the mistakes detected by the check tools Mathieu Poirier
2016-01-22 9:15 ` Eric Long
2016-01-22 17:29 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).