From: srplsnh@gmail.com (Surinder P Singh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] [ARM]: U8500 core machine support
Date: Thu, 24 Sep 2009 20:26:56 +0530 [thread overview]
Message-ID: <f2235a630909240756w658f84fai668b6d4d9fe3edb6@mail.gmail.com> (raw)
In-Reply-To: <f2235a630909240743t1fddabbct7c8ea0c4f77dbf73@mail.gmail.com>
On Thu, Sep 24, 2009 at 8:13 PM, Surinder P Singh <srplsnh@gmail.com> wrote:
> Some review comments:
>
>> diff --git a/arch/arm/mach-ux500/include/mach/debug-macro.S b/arch/arm/mach-ux500/include/mach/debug-macro.S
>> +
>> +#include <linux/amba/serial.h>
>> + ? ? ? ? ? ? ? .macro ?addruart,rx
>> + ? ? ? ? ? ? ? mrc ? ? p15, 0, \rx, c1, c0
>> + ? ? ? ? ? ? ? tst ? ? \rx, #1 ? ? ? ? ? ? ? ? @MMU enabled?
>> + ? ? ? ? ? ? ? moveq ? \rx, #0x80007000 ? ? ? ?@MMU off, Physical address
>> + ? ? ? ? ? ? ? movne ? \rx, #0xF0007000 ? ? ? ?@MMU on, Virtual address
>> + ? ? ? ? ? ? ? .endm
>> +
>
> It looks like the constants used here will break compilation. You
> could instead use 0x80000000 and 0xf0000000 and add an 'orr \rx, \rx,
> #0x7000' after the 'movne' to fix this.
>
You can also remove serial.h from here since this is now included in
debug-pl01x.S
prev parent reply other threads:[~2009-09-24 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 22:37 [PATCH 1/3] [ARM]: U8500 core machine support srinidhi kasagar
2009-09-24 14:43 ` Surinder P Singh
2009-09-24 14:56 ` Surinder P Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2235a630909240756w658f84fai668b6d4d9fe3edb6@mail.gmail.com \
--to=srplsnh@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox