From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A468DC4332F for ; Mon, 28 Feb 2022 14:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gk3yhJk1OWibX5Z8O7nZQK0UHCLak9479ZeiIffykos=; b=xD+j/Nbjq97vKk QOvdy8nT6WUsIYFxXNNEju6tpQVgkrlQ7/0R9I9M5w0avPEwzvY8Pi7lljO7FvNhvJpxRZplWK8Jo jNhBD0/loRKGvmqeDuPb+ZyZc9sOIfv9UYAnYHdIA8g+fffpOuzTVJFx532A7Ap+jzXdb3LmofGH4 4gPAil9h01aXGSpWbBwF9ZEHVcXmHKvA4ueUMjUUQF4d+vMN9REmSoLvOodGw/8TRXKkjVJiKILvd M7dbdG916LHkfsGEuIMHTs3YV6F1+ZBl8fSb97j25BatGtfwhuwcU8ajBJdJD8qI0DQ1kXOQaswrm b+G6RIvkezlOSSebfTEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOhHE-00Czx9-D9; Mon, 28 Feb 2022 14:45:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOh8U-00CwcY-5O for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 14:36:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30E99D6E; Mon, 28 Feb 2022 06:36:25 -0800 (PST) Received: from [10.57.39.47] (unknown [10.57.39.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC8653F73D; Mon, 28 Feb 2022 06:36:23 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 14:36:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property in pl022 Content-Language: en-GB To: Kuldeep Singh , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Linus Walleij References: <20220228124345.99474-1-singh.kuldeep87k@gmail.com> <20220228124345.99474-4-singh.kuldeep87k@gmail.com> From: Robin Murphy In-Reply-To: <20220228124345.99474-4-singh.kuldeep87k@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_063626_315161_5F0A59A9 X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-02-28 12:43, Kuldeep Singh wrote: > Fix below dtc warning by making necessary addition of "spiclk" in > clock-names property. > > arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000: > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000: > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml As before, what makes the binding at fault rather than that DT? The PL022's actual input is named SSPCLK, not SPICLK, so why should a driver which wants to look up that clock by name expect to look for "spiclk"? Robin. > Signed-off-by: Kuldeep Singh > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 5f6926a58b15..fb3075a0c7fd 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -45,6 +45,7 @@ properties: > - enum: > - sspclk > - SSPCLK > + - spiclk > - const: apb_pclk > > pl022,autosuspend-delay: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel