From: Matthias Brugger <matthias.bgg@gmail.com>
To: Chen Ni <nichen@iscas.ac.cn>,
nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com,
shayne.chen@mediatek.com, sean.wang@mediatek.com,
kvalo@kernel.org, angelogioacchino.delregno@collabora.com,
deren.wu@mediatek.com, mingyen.hsieh@mediatek.com
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] wifi: mt76: mt7925: convert comma to semicolon
Date: Wed, 4 Sep 2024 10:36:46 +0200 [thread overview]
Message-ID: <f2380ad1-f1d1-41c1-b00e-782f2c1937fc@gmail.com> (raw)
In-Reply-To: <20240904075213.1352976-1-nichen@iscas.ac.cn>
On 04/09/2024 09:52, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> index 9dc22fbe25d3..82c5a8def344 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> @@ -2171,12 +2171,12 @@ void mt7925_mcu_bss_rlm_tlv(struct sk_buff *skb, struct mt76_phy *phy,
>
> tlv = mt76_connac_mcu_add_tlv(skb, UNI_BSS_INFO_RLM, sizeof(*req));
> req = (struct bss_rlm_tlv *)tlv;
> - req->control_channel = chandef->chan->hw_value,
> - req->center_chan = ieee80211_frequency_to_channel(freq1),
> - req->center_chan2 = ieee80211_frequency_to_channel(freq2),
> - req->tx_streams = hweight8(phy->antenna_mask),
> - req->ht_op_info = 4, /* set HT 40M allowed */
> - req->rx_streams = hweight8(phy->antenna_mask),
> + req->control_channel = chandef->chan->hw_value;
> + req->center_chan = ieee80211_frequency_to_channel(freq1);
> + req->center_chan2 = ieee80211_frequency_to_channel(freq2);
> + req->tx_streams = hweight8(phy->antenna_mask);
> + req->ht_op_info = 4; /* set HT 40M allowed */
> + req->rx_streams = hweight8(phy->antenna_mask);
> req->band = band;
>
> switch (chandef->width) {
prev parent reply other threads:[~2024-09-04 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 7:52 [PATCH] wifi: mt76: mt7925: convert comma to semicolon Chen Ni
2024-09-04 8:36 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2380ad1-f1d1-41c1-b00e-782f2c1937fc@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=deren.wu@mediatek.com \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=mingyen.hsieh@mediatek.com \
--cc=nbd@nbd.name \
--cc=nichen@iscas.ac.cn \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).