* [PATCH] wifi: mt76: mt7925: convert comma to semicolon
@ 2024-09-04 7:52 Chen Ni
2024-09-04 8:36 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2024-09-04 7:52 UTC (permalink / raw)
To: nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
matthias.bgg, angelogioacchino.delregno, deren.wu, mingyen.hsieh
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek,
Chen Ni
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
index 9dc22fbe25d3..82c5a8def344 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
@@ -2171,12 +2171,12 @@ void mt7925_mcu_bss_rlm_tlv(struct sk_buff *skb, struct mt76_phy *phy,
tlv = mt76_connac_mcu_add_tlv(skb, UNI_BSS_INFO_RLM, sizeof(*req));
req = (struct bss_rlm_tlv *)tlv;
- req->control_channel = chandef->chan->hw_value,
- req->center_chan = ieee80211_frequency_to_channel(freq1),
- req->center_chan2 = ieee80211_frequency_to_channel(freq2),
- req->tx_streams = hweight8(phy->antenna_mask),
- req->ht_op_info = 4, /* set HT 40M allowed */
- req->rx_streams = hweight8(phy->antenna_mask),
+ req->control_channel = chandef->chan->hw_value;
+ req->center_chan = ieee80211_frequency_to_channel(freq1);
+ req->center_chan2 = ieee80211_frequency_to_channel(freq2);
+ req->tx_streams = hweight8(phy->antenna_mask);
+ req->ht_op_info = 4; /* set HT 40M allowed */
+ req->rx_streams = hweight8(phy->antenna_mask);
req->band = band;
switch (chandef->width) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] wifi: mt76: mt7925: convert comma to semicolon
2024-09-04 7:52 [PATCH] wifi: mt76: mt7925: convert comma to semicolon Chen Ni
@ 2024-09-04 8:36 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2024-09-04 8:36 UTC (permalink / raw)
To: Chen Ni, nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
angelogioacchino.delregno, deren.wu, mingyen.hsieh
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek
On 04/09/2024 09:52, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> index 9dc22fbe25d3..82c5a8def344 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> @@ -2171,12 +2171,12 @@ void mt7925_mcu_bss_rlm_tlv(struct sk_buff *skb, struct mt76_phy *phy,
>
> tlv = mt76_connac_mcu_add_tlv(skb, UNI_BSS_INFO_RLM, sizeof(*req));
> req = (struct bss_rlm_tlv *)tlv;
> - req->control_channel = chandef->chan->hw_value,
> - req->center_chan = ieee80211_frequency_to_channel(freq1),
> - req->center_chan2 = ieee80211_frequency_to_channel(freq2),
> - req->tx_streams = hweight8(phy->antenna_mask),
> - req->ht_op_info = 4, /* set HT 40M allowed */
> - req->rx_streams = hweight8(phy->antenna_mask),
> + req->control_channel = chandef->chan->hw_value;
> + req->center_chan = ieee80211_frequency_to_channel(freq1);
> + req->center_chan2 = ieee80211_frequency_to_channel(freq2);
> + req->tx_streams = hweight8(phy->antenna_mask);
> + req->ht_op_info = 4; /* set HT 40M allowed */
> + req->rx_streams = hweight8(phy->antenna_mask);
> req->band = band;
>
> switch (chandef->width) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-04 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-04 7:52 [PATCH] wifi: mt76: mt7925: convert comma to semicolon Chen Ni
2024-09-04 8:36 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).