From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC770C433FE for ; Mon, 14 Nov 2022 20:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zivse9wfy87Ot21ZIEty9pkHBuaDcDWI4D3rIF9TgVE=; b=pBI1TTOBIYDd9u UsGsLud1+Cwwr1Z7VB/tbA5El6O4xfASdqHt7t1CqutS9agP8Sg73PA5LotBWDwkN7nW5adEvuuJS 68+KxyocRgQtyJH8JKaVEt5UOy02xVwBwkWn4Gaz+N5onLl4wko0Avxd8prxGwAvyrpzDgWuRCi/g b2ZRaxGK2MQ7Xu+XZOe3MC/9G/g57czbR1ZsKeyU0vBo4Pn44dzWdanFmW2+YntL9D7jlhfEPFpu6 Z+zCJoHv9YqzCuDGyzK5lJZxxe7s0QiFs/Iq+piWpYGi4uEn0QZWpi6VShEfqEqaAwcRJUT8JNc8Q QPL2d05UOBOeQGD+yOOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ougJn-004qPC-PL; Mon, 14 Nov 2022 20:44:35 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ougJk-004qG5-7w for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 20:44:34 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AEKhre2086852; Mon, 14 Nov 2022 14:43:53 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668458633; bh=RRwVbs6Nxajdn/lHSP6EvoUJW0qDTPedg7Ql4Rbsgxw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=Ln7toHtfnHFQmyUN4xGjisz7miy4P2ui4/4LbCh0KRI1xLSuZRExRAoD0LcgA3rMX 8qFAxVf7UZzDtvaAmeMxuv+Ldi7GEfBt1IWXvzbM82U2cw1W+6YDIyabEqhOiWyG9N KzJcmEifBV3764UfYkDRQZ0FaC7YXga2WskNPiHI= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AEKhr84038214 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Nov 2022 14:43:53 -0600 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Mon, 14 Nov 2022 14:43:53 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Mon, 14 Nov 2022 14:43:53 -0600 Received: from [10.250.38.44] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AEKhqYZ026574; Mon, 14 Nov 2022 14:43:52 -0600 Message-ID: Date: Mon, 14 Nov 2022 14:43:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 0/7] Rename DTB overlay source files Content-Language: en-US To: Andy Shevchenko CC: Rob Herring , Shawn Guo , Li Yang , Sascha Hauer , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra , Masahiro Yamada , Michal Marek , Nick Desaulniers , Geert Uytterhoeven , Frank Rowand , , , , , References: <20221024173434.32518-1-afd@ti.com> From: Andrew Davis In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_124432_437461_FA92F4F9 X-CRM114-Status: GOOD ( 28.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/14/22 10:06 AM, Andy Shevchenko wrote: > On Sun, Nov 13, 2022 at 02:36:33PM +0200, Andy Shevchenko wrote: >> On Sun, Nov 13, 2022 at 02:20:48PM +0200, Andy Shevchenko wrote: >>> On Fri, Nov 11, 2022 at 03:05:20PM -0600, Andrew Davis wrote: >>>> On 11/11/22 1:39 PM, Andy Shevchenko wrote: >>>>> On Wed, Oct 26, 2022 at 09:11:21AM -0500, Rob Herring wrote: >>>>>> On Mon, Oct 24, 2022 at 12:34 PM Andrew Davis wrote: >>>>>>> >>>>>>> Hello all, >>>>>>> >>>>>>> This is a series based on my patch here[0]. As suggested by Rob >>>>>>> I've resurrected Frank's patch and appended it to mine as a series. >>>>>>> >>>>>>> First patch here is my original patch, 3rd is Frank's patch but with >>>>>>> the unittest changes pulled out into the 2nd patch. That was re-worked >>>>>>> moving the source building macro into scripts/Makefile.lib. >>>>>>> >>>>>>> Patches 4, 5, and 6 are an attempt at renaming all the existing DTB >>>>>>> overlays. Split out by platform so they could be taken by platform >>>>>>> maintainers or if easier ACK'd here and taken all together. >>>>>>> >>>>>>> This should cover all the DTB overlays so we can remove the old .dts >>>>>>> rule for overlays and make .dtso the only supported way, let me know >>>>>>> if we want that this cycle and I can post that too. >>>>>>> >>>>>>> Thanks, >>>>>>> Andrew >>>>>>> >>>>>>> Changes from v1[1]: >>>>>>> - Added patch to rename pi433 overlay. >>>>>>> - Cleaned wording on patch 4-6. >>>>>>> - Collected some ACKs >>>>>>> >>>>>>> [0] https://www.spinics.net/lists/kernel/msg4548509.html >>>>>>> [1] https://www.spinics.net/lists/arm-kernel/msg1020165.html >>>>>>> >>>>>>> Andrew Davis (6): >>>>>>> kbuild: Allow DTB overlays to built from .dtso named source files >>>>>>> kbuild: Allow DTB overlays to built into .dtso.S files >>>>>>> arm64: dts: freescale: Rename DTB overlay source files from .dts to >>>>>>> .dtso >>>>>>> arm64: dts: renesas: Rename DTB overlay source files from .dts to >>>>>>> .dtso >>>>>>> arm64: dts: xilinx: Rename DTB overlay source files from .dts to .dtso >>>>>>> staging: pi433: overlay: Rename overlay source file from .dts to .dtso >>>>>>> >>>>>>> Frank Rowand (1): >>>>>>> of: overlay: rename overlay source files from .dts to .dtso >>>>>> >>>>>> I've applied patches 1-3 and 7. I'll send a PR for the branch to the >>>>>> platform maintainers after a few days in linux-next. >>>>> >>>>> The patch >>>>> >>>>> commit 941214a512d8c80d47e720c17ec17e8539175e93 >>>>> Author: Andrew Davis >>>>> Date: Mon Oct 24 12:34:29 2022 -0500 >>>>> >>>>> kbuild: Allow DTB overlays to built into .dtbo.S files >>>>> >>>>> broke the build reproducibility / no-op builds. >>>>> >>>>> Before: >>>>> 2+ execution of `make` on non-changed tree did nothing >>>>> >>>>> Now: >>>>> Each run of `make` (even without a single bit changed) restarts vmlinux >>>>> rebuild. >>>>> >>>>> Please, revert or fix. >>>>> >>>> >>>> I do not see this behavior. What config are you using? >>>> >>>> Not sure how this patch could be the root cause, it only adds >>>> a build target/rule, but doesn't actually use it anywhere yet.. >>> >>> For your reference I started with this one [1]. >>> >>> When I bisected, I just answered with defaults on whatever `make` told me at >>> the configuration stage. >>> >>> The actual `make` command I used: >>> >>> make O=/path/to/the/result W=1 C=1 CF=-D__CHECK_ENDIAN__ -j64 >>> >>> But there is nothing that can affect the described issue. >> >> Actually, O= might affect which Makefile is used and how. >> The C=, CF= are sparse flags, W= is just warning level. > > As far as I can tell right now it's the OF_UNITTEST on x86_64 that makes the > above mentioned patch to be a culprit. Not sure if on ARM / ARM64 you can > reproduce that. And it's really strange nobody reported this for a week+. > > Whatever, I'm open for the suggestions and material to test. > I think I found the issue, we forgot to add the new dtbo.S/o files to the list of preserved intermediate targets, so Make was removing them after build. Sending the fix now. Thanks, Andrew >>> [1]: https://p.defau.lt/?ZSOdGnNxF9v9AQtrfDo_KQ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel