From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EAE2C3A5A5 for ; Thu, 5 Sep 2019 12:16:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41FC921883 for ; Thu, 5 Sep 2019 12:16:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n6A+azf6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41FC921883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nYHo0JmAh95EcmcuuRdM8TZQaBN9fotz9ii4OU9LWXQ=; b=n6A+azf6LhTU9l /SHP8LruDrYVO0pzIGA53SPhlUthtfXt3PhUb/oNirnSNsfiYnVRdjR0+2Ycf6vbOA6QuFT0G3P2N dGPhYwU9QqKMqalJf7+7LThGs04e1igYpJzDJZsKjZeFC8vXKeNbeNIaVpQnjgKW0ZCjTO3vGkfuq Eb3vqXSQjxMxOcd0lGUXkOGsdn5PTh7x0U3q0GsJNpl7I6f4TndsqDpYIFRKJOTQf2TZuKCH/9neR zPFRGRxIDKXblc1+gt/A41QirePr4nPzHNS3TJUX8MdYT392cmwpXjVyJNsz2ks+7piCOSqgAdHyg SdcjbbxZOeEz/wxhQ6yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5qgI-0005C4-IS; Thu, 05 Sep 2019 12:16:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5qgF-0005BY-Rs for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2019 12:16:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 200BE28; Thu, 5 Sep 2019 05:16:03 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 51FA33F718; Thu, 5 Sep 2019 05:16:02 -0700 (PDT) Subject: Re: [PATCH v5 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd To: Dave Martin References: <20190902112932.36129-1-cristian.marussi@arm.com> <20190902112932.36129-10-cristian.marussi@arm.com> <20190904114923.GZ27757@arm.com> From: Cristian Marussi Message-ID: Date: Thu, 5 Sep 2019 13:15:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190904114923.GZ27757@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_051603_992794_B9E55B8C X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi On 04/09/2019 12:49, Dave Martin wrote: > On Mon, Sep 02, 2019 at 12:29:30pm +0100, Cristian Marussi wrote: >> Add a simple fake_sigreturn testcase which builds a ucontext_t with >> an anomalous additional fpsimd_context and place it onto the stack. >> Expects a SIGSEGV on test PASS. >> >> Signed-off-by: Cristian Marussi >> --- >> v3 --> v4 >> - fix commit >> - missing include >> - using new get_starting_head() helper >> - added test description >> --- >> .../fake_sigreturn_duplicated_fpsimd.c | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> >> diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> new file mode 100644 >> index 000000000000..c7122c44f53f >> --- /dev/null >> +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> @@ -0,0 +1,52 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2019 ARM Limited >> + * >> + * Place a fake sigframe on the stack including an additional FPSIMD >> + * record: on sigreturn Kernel must spot this attempt and the test >> + * case is expected to be terminated via SEGV. >> + */ >> + >> +#include >> +#include >> + >> +#include "test_signals_utils.h" >> +#include "testcases.h" >> + >> +struct fake_sigframe sf; >> + >> +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, >> + siginfo_t *si, ucontext_t *uc) >> +{ >> + size_t resv_sz, need_sz; >> + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; >> + >> + /* just to fill the ucontext_t with something real */ >> + if (!get_current_context(td, &sf.uc)) >> + return 1; >> + >> + resv_sz = GET_SF_RESV_SIZE(sf); >> + need_sz = HDR_SZ + sizeof(struct fpsimd_context); > > Nit: Maybe write this sum in the same order as the records we're going > o append, i.e.: > > need_sz = sizeof(struct fpsimd_context) + HDR_SZ; /* for terminator */ Ok > > Also, maybe fail this test if there is no fpsimd_context in the initial > frame from get_current_context(): that would be a kernel bug, but we > wouldn't be giving fake_sigreturn() duplicate fpsimd_contexts in that > case -- so this test wouldn't test the thing it's supposed to test. > Any context grabbed by get_current_context() is verified at first to be sane when is copied in the handler by ASSERT_GOOD_CONTEXT() > } else if (signum == sig_copyctx && current->live_uc) { > memcpy(current->live_uc, uc, current->live_sz); > ASSERT_GOOD_CONTEXT(current->live_uc); > current->live_uc_valid = 1; A missing fpsimd in the original sigframe would lead to an abort() straight away while preparing the test, and the test will fail. Cheers Cristian >> + >> + head = get_starting_head(shead, need_sz, resv_sz, NULL); >> + if (head) { >> + /* Add a spurios fpsimd_context */ >> + head->magic = FPSIMD_MAGIC; >> + head->size = sizeof(struct fpsimd_context); >> + /* and terminate */ >> + write_terminator_record(GET_RESV_NEXT_HEAD(head)); >> + >> + ASSERT_BAD_CONTEXT(&sf.uc); >> + fake_sigreturn(&sf, sizeof(sf), 0); >> + } >> + >> + return 1; > > [...] > > Cheers > ---Dave > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel