From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Russell King <linux@armlinux.org.uk>,
Andy Shevchenko <andy@kernel.org>, Kees Cook <kees@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: s3c: use string choices helper
Date: Tue, 17 Jun 2025 08:34:55 +0200 [thread overview]
Message-ID: <f2a0137f-22fd-46da-b5da-9ad03ce1d05d@kernel.org> (raw)
In-Reply-To: <CAHp75Vd+9f_iJ9AW+OfjpuZrt6zjaxPEY1ihZHCDOnvQmwboNQ@mail.gmail.com>
On 17/06/2025 08:11, Andy Shevchenko wrote:
> On Tue, Jun 17, 2025 at 8:54 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 17/06/2025 02:06, Kuninori Morimoto wrote:
>>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> Missing commit msg (especially considering this is legacy code which
>> soon might be completely removed).
>
> Besides the fact that this most likely would need to be changed to
> pr_info() to begin with :-)
Yeah, indeed. I don't want patches converting it to pr_xxx or dev_xxx,
either, unless you come with really good explanation. This all will be
removed this or next year.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-06-17 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 0:06 [PATCH] arm: s3c: use string choices helper Kuninori Morimoto
2025-06-17 5:54 ` Krzysztof Kozlowski
2025-06-17 6:11 ` Andy Shevchenko
2025-06-17 6:34 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2a0137f-22fd-46da-b5da-9ad03ce1d05d@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=kees@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox