From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC89DC4338F for ; Sun, 22 Aug 2021 08:55:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD1E0611F2 for ; Sun, 22 Aug 2021 08:55:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BD1E0611F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2dVHAbuQ6R2Y9ScKjN6EDhHC4SfdhU+Esjkss0fL/Ko=; b=ZHLWtefWcIA19j0GFRtsmQGRA7 fe6oRsTDSMOw1NXO58UwvSlqDt+HdXEk+X1ZcJrUD40yBTt7DB5NQvSxaR2Mmggk3SVyYFQnWYeNv xj1BaY5lPaf/ZelttnQ5JsXWd1jREEG7gBPhtZdS31aqNmU5ZbpMpTDquGadZqoIc0emQcGuf7rfX romLEUMMZigMYS39POuK/CuwWDxlr3H2twboaAIxS09gdweE3qFxR7oRnnITjojLtkj0TgRWwG6aI fzAQpuS3EAypSwzgNrVekncclyDTov3dL3JcPGZxwxul4FxiNyj4ARTNpPF2qZtDMvcjbIAznI3Um l9FGZ6ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHjDW-00Djdq-6s; Sun, 22 Aug 2021 08:52:34 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHjDS-00Djcu-2M; Sun, 22 Aug 2021 08:52:31 +0000 Received: by mail-wm1-x336.google.com with SMTP id u15so8564991wmj.1; Sun, 22 Aug 2021 01:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JF6Zh6avYIlDu2Zmhl/mye0nrmkhYSCt6Bp3eS+Tocg=; b=O13e2oeA/KYgy+6+k49OkC7C2oEmD2hZ+y7VPhkFOhOGz5Vp0rByHT4Lc/PSUaLvaX U5QyrUPJvz7fyjR4YkxJJvCgQh1hHpbd1bzNuF3PdpxfDVGEyNIwLeBVZIihTjV+MsyU nhi81okeWZUN8BUEqCHP+R8xB8SnjWsZWEQr1yFSeQBdWt3/CawBiFZhJFDytCLh3lua POB/SEatspeXjQD6O7iJF1GfyFZvkBmO1Y8x3nImNGbOUng4eJwp1A4zi4z+K4AclmJp Wy+1Uf1ZGjl71WMt2OW1PBvtifFOATE7vFPy/B9JchPy+8Sy0Imv+SXLOQwa/qoyXeZo Z+zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JF6Zh6avYIlDu2Zmhl/mye0nrmkhYSCt6Bp3eS+Tocg=; b=PaCsOfREM+Klfmu2fehVP0dAHdGrsmYDSscD2/6A6V0dvcKZ5eBkd/+YU/qL0MAwk9 MuKVi1M1zVdxJTpZ3lWgQn8yEhi0runSs2sLvynZwmeHBstEh4nhx8S86GuNmrHz9qyR 4JkawqjFubN4SwutxRL2vHdPSFNjPlJdnOv1XcvVqsxAT1TDmYWnyTJ0gG26h5OsjSHj EL9sZod5Z1yjj+WSwyfGJHCvPWfNhFpAwA7ruu4QStTO3xA2hvqSkSZRpZPAv8HB7tlw uEf+QQkxmMsdH5r0HTgP37GJdJg0PmUC4L/dXFlKkWC9jWe/b0o/ee3SYgVgfUkEtK3U lxJA== X-Gm-Message-State: AOAM531VgDPTI/Dnuy9PynlLCCvbnQyIIIoUz82hpceYsVg4nzxUZ6nW DnGDiwfouBS0qysUl8Zvtr0= X-Google-Smtp-Source: ABdhPJy+5/Qyp89qbqbAg+aFoRbSXqDporku/I9fNp0g6zTjfr7dIfGKfDZbUsHByZ8o8PZv9WckgA== X-Received: by 2002:a7b:cf05:: with SMTP id l5mr11402615wmg.138.1629622347002; Sun, 22 Aug 2021 01:52:27 -0700 (PDT) Received: from [192.168.1.22] (amarseille-551-1-7-65.w92-145.abo.wanadoo.fr. [92.145.152.65]) by smtp.gmail.com with ESMTPSA id r10sm13811735wrq.32.2021.08.22.01.52.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Aug 2021 01:52:26 -0700 (PDT) Subject: Re: [PATCH v2 2/4] PCI: brcmstb: Add ACPI config space quirk To: Jeremy Linton , linux-pci@vger.kernel.org Cc: lorenzo.pieralisi@arm.com, nsaenz@kernel.org, bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org, robh@kernel.org, kw@linux.com, sdonthineni@nvidia.com, stefan.wahren@i2se.com, bcm-kernel-feedback-list@broadcom.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210819215655.84866-1-jeremy.linton@arm.com> <20210819215655.84866-3-jeremy.linton@arm.com> From: Florian Fainelli Message-ID: Date: Sun, 22 Aug 2021 10:52:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210819215655.84866-3-jeremy.linton@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210822_015230_188582_61E2BCF7 X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/19/2021 11:56 PM, Jeremy Linton wrote: > The PFTF CM4 is an ACPI platform that isn't ECAM compliant. Its config > space is in two parts. One part is for the root port registers and a > second moveable window pointing at a device's 4K config space. Thus it > doesn't have an MCFG, and any MCFG provided would be nonsense > anyway. Instead, a Linux specific host bridge _DSD selects a custom > ECAM ops and cfgres. The cfg op picks between those two regions while > disallowing problematic accesses. > > Signed-off-by: Jeremy Linton Once you address Bjorn's feedback, feel free to add: Acked-by: Florian Fainelli I do wonder if squashing patches 2 and 3 would make more sense, otherwise we have a bcm2711_pcie_ops that is unused in patch 2. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel