From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9868EC6FD1F for ; Wed, 3 Apr 2024 04:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q1P31Fll7mLbOPFh3SUv3eYHwZFso9nA2qgLNWIm4LY=; b=hc+mM5Yt5BK+lH mWChs0/J/KfTg+6DIjDP68Vh8CVAj7taVd7u1yUHDVahpyHVL8Tg/zkX9H5/wblRg5S5cU853/WYd piHBV55Ltb+ToaTBawvdkFebIGjUHh0KCM5VReJUP10kQWIrK9mYNbQTsGhgijql3IfoXlk32aIoP GZIMiSEkLYyJL9E9bBSWehYdCQsqo+ADIFHfJhPklBvzGacAEhj8+yA9okc1GX1JQMyjGhIow8sN9 MV7prCb6uOnGKAaayw4DttqEsR8Zed0jZOau9hc2rmuR5wrkR2GVbX4v6Fj9HciXMZrnsB/neJtiB LeYi9FrLXvHMwEUZx9bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrsBj-0000000DwIf-2z3M; Wed, 03 Apr 2024 04:25:27 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrsBe-0000000DwFP-3iBT; Wed, 03 Apr 2024 04:25:24 +0000 X-UUID: 2dfa4a20f17211eeac1957ae9f99f617-20240402 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=ALToTDOLXG1JUxgoypRInnHKy0z1IvTA4lbsrRxUGQ0=; b=f/47bzwDuBPLi9cFe0mvTbw2y8t2Oq//Lo8XiH/4yp7xAkA8PUuWttCRji8hVc8l3AT4vjwYwEPRPwiyS76Rqh3mbcNdY2sYbS/o5WC2RyUZVFILiXv3nr0kDb/4A7DANOypladMD4+uqF3DrAR/pgP9apgKDX+afoG6BhPI9vE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:f6c201c6-a15d-493b-98b0-2c1aa9dba73c,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6f543d0,CLOUDID:0e6b2891-e2c0-40b0-a8fe-7c7e47299109,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 2dfa4a20f17211eeac1957ae9f99f617-20240402 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1700047010; Tue, 02 Apr 2024 21:25:19 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 3 Apr 2024 12:24:39 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 3 Apr 2024 12:24:39 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j49nLxqyQoQ8ZL4ssKmZ13j/umeAxH6xq/HAq7HuYs6VSs9UkNAShz1QAOR6XvZzsv419IhI7olAf4dMeYAKOnucyRN8JKptDqMYfPF4lexdaH9kITIOPm6ckCwZDUiseIqP1vPLgSI+qoPOVnJ1whm6dtwRuZTG//xkRdbsNzb3xzoH45nXVdV6l1qQRDhs/3ruPAB1oBrwqd7gLb9UYX71hUjAZ+WfVmSB3iN/Mvx66NdJqX2MqJ8N6Um4a/eHTmxhYzcAyuqr8Mz5Hm9JXw7fbB+vZxVFYWa3+Bcz9T63Thajo00D3/s2UF74MciqQh3MMv3diZ2UbIRk0RLonA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ALToTDOLXG1JUxgoypRInnHKy0z1IvTA4lbsrRxUGQ0=; b=NAdNhTJhAqo2ET7eqqrWmQ8m3OY31pXWjmx2/wyBYXqHaLxhBqf5Xg7Vu9PhT+GAz9Mg1djTnissROJ6aF1wFKNlBxumklENMf8ypuYAAtLHX22j9i8kAlC265R9ibVp58VkGMPvVmqy9oxJOI34GRNOW9tAxn5iJ9jAIrb3KpxttiN4dmh8PWnRUQ4tVE7oVvXh5sxOW4MUtckB0dJ2Co60cZSbAMsBt7JQyZPXUkb91xbv29liHEdLBQ8atNyjmZ0Axn0wc+GxGNWpIJrGvnV027jvWR7OMWO0hE4Pq3Rda19/IrFEbE9C+5+QKIu7/LVR/VbRnkKW2jZcxVM88Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ALToTDOLXG1JUxgoypRInnHKy0z1IvTA4lbsrRxUGQ0=; b=FCSbvQc4r1t25FTsRtsTg1wJhPVzN02U4PBCl/cgiZfumvSpmJqpxD6PQo6bWexeRynlUjBpw02n1LbiklMUP+ZSiFH9YF/gsZOyhEC8rAnuNnsY64URVbrZ08P5AQ2NqRJfH9mi0TKweJbWJYPKUZUrytTUftjI6XGh/jn8fcw= Received: from TYZPR03MB5566.apcprd03.prod.outlook.com (2603:1096:400:53::7) by SEZPR03MB8763.apcprd03.prod.outlook.com (2603:1096:101:218::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 3 Apr 2024 04:24:37 +0000 Received: from TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::b39a:4ac4:5bf8:88d]) by TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::b39a:4ac4:5bf8:88d%5]) with mapi id 15.20.7409.042; Wed, 3 Apr 2024 04:24:36 +0000 From: =?utf-8?B?WmhpIE1hbyAo5q+b5pm6KQ==?= To: "sakari.ailus@linux.intel.com" CC: "heiko@sntech.de" , "gerald.loacker@wolfvision.net" , "robh+dt@kernel.org" , "yunkec@chromium.org" , "linux-kernel@vger.kernel.org" , "dan.scally@ideasonboard.com" , "linux-media@vger.kernel.org" , =?utf-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , "hdegoede@redhat.com" , "linus.walleij@linaro.org" , "andy.shevchenko@gmail.com" , =?utf-8?B?WWF5YSBDaGFuZyAo5by16ZuF5riFKQ==?= , "mchehab@kernel.org" , "jacopo.mondi@ideasonboard.com" , "jernej.skrabec@gmail.com" , "linux-mediatek@lists.infradead.org" , "bingbu.cao@intel.com" , Project_Global_Chrome_Upstream_Group , "conor+dt@kernel.org" , "10572168@qq.com" <10572168@qq.com>, "hverkuil-cisco@xs4all.nl" , "tomi.valkeinen@ideasonboard.com" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "laurent.pinchart@ideasonboard.com" , "devicetree@vger.kernel.org" , "angelogioacchino.delregno@collabora.com" , "macromorgan@hotmail.com" Subject: Re: [PATCH v1 2/2] media: i2c: Add GC05A2 image sensor driver Thread-Topic: [PATCH v1 2/2] media: i2c: Add GC05A2 image sensor driver Thread-Index: AQHad00+IqkBATFIkUCM1xUJwrGHMrFAQfSAgARroYCAEWF6gA== Date: Wed, 3 Apr 2024 04:24:36 +0000 Message-ID: References: <20240316025253.2300-1-zhi.mao@mediatek.com> <20240316025253.2300-3-zhi.mao@mediatek.com> <8a6bbbdde57283b5bf8cab0ea7ecb0f201d437e7.camel@mediatek.com> In-Reply-To: <8a6bbbdde57283b5bf8cab0ea7ecb0f201d437e7.camel@mediatek.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB5566:EE_|SEZPR03MB8763:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VOqxJ5QhJ7a3sT+/ZT4coe/N2z5lmT/eEyra9BGLMj+uCWjF9hem5yW24HmxXyK/Jsn88e6ltlxryTEOVJLJjUzsQ+iqRo+veIKzRG2vAaAWBDVq0mTrpxnyrc0G5HUUvwpIBl+PoE/7bHF5h8WmRMz2A1ajjftGa0dvc5e2l7UA8QFTAVxRQKL7Bowyx2CwZDwf09jEyZ+zaz2T2HO1Lbglyx0unRK2mHPrrMa9VZdSoooqOZWh9jS/JZAXsnsoMn9FRtNizh0YldEWZl0glQUwnQps2Pa28WibMjalSH7luoMb1owy7Mg3M+R0evePFdW9MKUExpWxSWTC29xJjsTMbvDNrtCq3u2iIW3sMN+AAj2URUIVM9fpUZ7mfij2q6D/3qofR4dESiFte2TBCzgg2nN6kNRh/tZY/Exczwovh5Q2PTO8WAsjNziIlT1J2rIQRqLtrL3fI977DLBWdCsGhhLJhXPrbeNWFm6+3XfpkV7wm5I+fsx0SlcuOXQElAqv1aOHdPcNKhIa2GJPwmlgEFKt3+uhGlvVqbt3i1nrBSeL/Q77s6PGj70i202D9bKjKAQ2NFe+p64Rg0cqA5oy/qilgELzY62reHV+bt00F0XDejUwB1afwqAoaBmo x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB5566.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(376005)(366007)(1800799015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?LzZ3MGl2T0s2M2lHYkxwSU5GUG9EMTJvU3oxVGxSaGRCUUl1VVh2d2lLWjRB?= =?utf-8?B?UWd5WE91UkpwMDZmNEx1aHlPUFJ0Y2N5b0lRaUFXUmFaVUJ4UUZmQm5hWElQ?= =?utf-8?B?RnY4aUFSM0ZldFRVbUZWdXpXdmdVTi9pVnhRVS9UeGZwdDlQRkJNSTdaTEU5?= =?utf-8?B?RVIzdTdzckVTK3VlZFJzTmtFczNpeWhhNXY2L1VLdzRvbjRzN0MyQjZLTk9h?= =?utf-8?B?eng0bDBiSERLOFhHNUluRytueEtpSmxzTDM0SlduMndFaXhZY1NMOGRvREFJ?= =?utf-8?B?WkVLNXZ5UHN2R3VmMzVuVTVXT2VGUi9ITzFzQkY5TE5IQitQMktoenptWjNa?= =?utf-8?B?QUlQbVlTVktvME5WbVQvTHhpeVp4alhvVlpNZm4yc0ZObTdBTStqaFRnVjRS?= =?utf-8?B?SFdqWlZTN3ArWTVEck80SXZVRTVoTVVUQ1h4WVh5bE5kcDdSV3BoUFRPd2lC?= =?utf-8?B?Qk8ydkdrMUpFNjZ1QnlndE8xOGozWENSSWJKUVZwdkRzL0Fqb0hXQTFuYTRK?= =?utf-8?B?Z1BVMkxCSit4WUtBSUhKWWh3QVlWNlFOQUxqN3pTdDFmZlhMamQ1SUw1NWQw?= =?utf-8?B?N2RiV1dKOGY3emFpR1V6cmlTclVGUVNCYVBTbHFreEdjS0lFOGlodnNzbnN4?= =?utf-8?B?MDRyUStIL09yNkRPWEFnYjk1Qi9iVjlzTDdhSllzVjhteEVUbnFaQ2IvSmRJ?= =?utf-8?B?a09MMkl1elZvV2MrTFZzckNKTmpnd1o4cFRCUm5pNlZCNFVZVElGNjFMOGVD?= =?utf-8?B?aGIzYXpDanpUc3dKY3ErM1B2T2NXSFpHRUdJbkIrMlRjRzlzSjEzVUNOZVc1?= =?utf-8?B?NFdMMWlnVlk2N2RjVDA1alBWTEYrOHE4ejNhOFhsazVRb2ZKS3B3M3NWUy9w?= =?utf-8?B?cWtFcFdHWDVGSS9zOUlwOEd5cWJyK0RHZlA5QWlOOVQydGV4VFBNakpubkxi?= =?utf-8?B?NHlIcEVRbkw5U0ErSmE2RFMxQ3dkanJDclBRczFqTHFhTy8vNFora28xWmJK?= =?utf-8?B?SGg3V1JyWkNEa1BpRU90cGdIazJsVVZ0bldycHQ4QXZHZ3VibVFJY29SeFhP?= =?utf-8?B?ak5nNjJzSk9iaUxxeGVDdnQzUDdpenFRZXI3NU9QTHNrT0FiMXo2S1BoelVW?= =?utf-8?B?bzZEQW0yZEJ6R0tBQ2NKOVlxa0RGVE5DY0twNVdGQ2F1KzF3WlFlOHZtUGVH?= =?utf-8?B?Z1YrZ0ExVVk2WWZpbFU4bXQ0ZC9oMHFHZVluYWtZYStpMVFNcnIwMzNZMXlX?= =?utf-8?B?NTlDeGFxNllJNHdTUk5DaythcUxmb0E4KzBqWkxjL2VjUnZnRDhUcUhnVnJG?= =?utf-8?B?VDk4Q2JmVDlTb2MvQWhQUmlxTFZOYk5vakp0aTJ0R2pHczBhd2lzalNjRW1z?= =?utf-8?B?RG5lYVV3cVcvL1NleGo4Q1VwbDhLM2t1TmRDL2cvMnBaVVg3dVR2TnRLcnpx?= =?utf-8?B?c3ZySFMzanp4V2lMVHVqcFRnc3UwNHBxQUdscmZHOElndUVvQTNHQ0NQSSt5?= =?utf-8?B?VExmcmZzMHJ5Z2cwamJ1MDM1czJYZURpV1VvbVpPNWs3WUdhaUZaME12WTgv?= =?utf-8?B?VXhFNW9PbG5Mdi9DQzkzelQxOXUvdlRjYkh2Q3RjVWFGZGxzYzgxcXA0dnV1?= =?utf-8?B?dWRnY2NIM1RCV01mdzhGUHc1YVpSQ2E2RkRsdWxvNUp3Q2V6d1cvSHdmaDRr?= =?utf-8?B?blJ3cEU5aytZc2pKRTZxemtzWEpuaTd3a0pYa0pzWnF0cUkwNVpVOWs0YUpX?= =?utf-8?B?TFI1WnE1N3VoMzhYbXd5Q3U4TWwrSTJzY3RZbDU5bTFtZEdnL2YyRGhJM1RN?= =?utf-8?B?c2NLeDNFTUJWNmlya3EzN0VJc3lURGxqcUcxZ2FDNzRvTVBXY3dpUG1BcEZw?= =?utf-8?B?UUNBRU04a1VWQ01pU3VYWjc5bi9qRGh2dlBOc3JYRUVIeVBUZ0dSM2FqZzBT?= =?utf-8?B?QkdUNkl5TzRxT2hwam9Yc29ENlExQ1ZPRjdsK1hXNklZRXJDTDFpWlhxSUpo?= =?utf-8?B?MnpzQWlGS3IvOGE1OTQ4QVFUR21abnNHQ0pZSE5jbVNxTGlHNWVOcTBrQUJt?= =?utf-8?B?VWV0UzMvdjRtbUtZZTBia3ZMVCsrM2poSXc2QkNqQXRlWldyaGtVckQ4Qjlq?= =?utf-8?B?M01WSk9aRDhsc2xIcVJ6c0dEM1hsRkh6dStSRHBBY1RoMnhDK1dzVkNiQzl5?= =?utf-8?B?OVE9PQ==?= Content-ID: <6E66F93B9CA9384E90C5DC746E61DCBE@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB5566.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c544155e-acb0-4f8e-0ca7-08dc5395f8b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2024 04:24:36.7351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r7L/uHwgemAByKm809i0QaMYkeuwFvj7aiFeOPAMhkzJ2dRr4wVnfuI9Ce8oOxm0SxDQEG/nQVG/saiIxJnirQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB8763 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--16.951700-8.000000 X-TMASE-MatchedRID: dc8Jy61QoRrUL3YCMmnG4uG5dRZCgxC3uLwbhNl9B5UNcckEPxfz2IP+ YDa/Dhu9JP00JqzxhIBrkO0aOJR63GaivMAy8a2BvHKClHGjjr2cyCGZko2aplVqIv0mjuMGo/7 b2ABiEdK+j2QY5cRmWtP+J/cFFKsSHyzWFbk8FLVLc5N+0s1+DTK1/qdbjc7QEqzh2sHXZHGiw+ Xvt/uB3M0AhBXEKaqYeo8Y7LCQaK8AiB89UisvLBWCVBr+Ay98wx0jRRxcQfNAiWCTfFh1XgBKG kW9znn5NZgKuXgLgpPcHsyE3Hr9h0L9tcyTZdAsgxsfzkNRlfL+VmoNXJ/8FMBrudef+SZcjocz muoPCq2UTGVAhB5EbQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--16.951700-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: AD25280E4E5CDFF39D33C5A62753ADED7DFE98F4DB50350C0B7F911A52CA933E2000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_212522_963500_08585ABF X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, Update gc05a2 driver patch. On Sat, 2024-03-23 at 10:59 +0800, zhi.mao@mediatek.com wrote: > Hi Sakari, > > Thanks for your review. > > On Wed, 2024-03-20 at 07:29 +0000, Sakari Ailus wrote: > > > > External email : Please do not click links or open attachments > > until > > you have verified the sender or the content. > > Hi Zhi, > > > > Thanks for the set. > > > > On Sat, Mar 16, 2024 at 10:52:53AM +0800, Zhi Mao wrote: > > > +static int gc05a2_set_ctrl(struct v4l2_ctrl *ctrl) > > > +{ > > > +struct gc05a2 *gc05a2 = > > > +container_of(ctrl->handler, struct gc05a2, ctrls); > > > +int ret = 0; > > > +s64 exposure_max; > > > +struct v4l2_subdev_state *state; > > > +const struct v4l2_mbus_framefmt *format; > > > + > > > +state = v4l2_subdev_get_locked_active_state(&gc05a2->sd); > > > +format = v4l2_subdev_state_get_format(state, 0); > > > + > > > +if (ctrl->id == V4L2_CID_VBLANK) { > > > +/* Update max exposure while meeting expected vblanking */ > > > +exposure_max = format->height + ctrl->val - GC05A2_EXP_MARGIN; > > > +__v4l2_ctrl_modify_range(gc05a2->exposure, > > > + gc05a2->exposure->minimum, > > > + exposure_max, gc05a2->exposure->step, > > > + exposure_max); > > > +} > > > + > > > +/* > > > + * Applying V4L2 control value only happens > > > + * when power is on for streaming. > > > + */ > > > +if (!pm_runtime_get_if_in_use(gc05a2->dev)) > > > > This should be pm_runtime_get_if_active(). Please assume it takes a > > single > > argument (the device)---see commit > > c0ef3df8dbaef51ee4cfd58a471adf2eaee6f6b3. > > > > The same comment applies to the GC08A3 if it uses autosuspend, > > please > > post > > a new patch for that. > > > > fixed, patch as below: > gc05a patch:v2 > > https://lore.kernel.org/linux-media/20240323014751.4989-1-zhi.mao@mediatek.com/ > gc05a driver was updated to patch:v3 https://lore.kernel.org/linux-media/20240403033825.9072-1-zhi.mao@mediatek.com/ > gc08a patch:v8 > > https://lore.kernel.org/linux-media/20240323023851.5503-1-zhi.mao@mediatek.com/ > > > -- > > Kind regards, > > > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel