From: stefan@agner.ch (stefan at agner.ch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6ul: rename mux mode name REF_CLK_32K to OSC32K_32K_OUT
Date: Tue, 06 Feb 2018 17:27:15 +0100 [thread overview]
Message-ID: <f2dcbad84f9237adf072e005d15d65ef@agner.ch> (raw)
In-Reply-To: <20180205204759.28526-1-joerg.krause@embedded.rocks>
On 05.02.2018 21:47, J?rg Krause wrote:
> This is a rebased version of patch [0].
>
> The 32 kHz reference clock on the i.MX6UL(L) can be output by
> setting the external signal XTALOSC_REF_CLK_32K in one of the
> following ways [1]:
>
> |----------------------------------------------------------|
> | Signal | Pad | Mode | Direction |
> |----------------------------------------------------------|
> | XTALOSC_REF_CLK_32K | ENET1_RX_EN | ALT2 | O |
> | | GPIO1_IO03 | ALT3 | |
> | | JTAG_TCK | ALT6 | |
> |----------------------------------------------------------|
>
> Before patch [2] the mux mode for the external reference clock was
> missing. The patch named the mux mode as used in the NXP Linux
> 4.9.11_1.0.0 release, but the Reference Manual uses the name
> OSC32K_32K_OUT, e.g. in [3].
>
> As Philipp and Shawn suggest the name from the RM should be used
> instead.
>
> [0] https://patchwork.kernel.org/patch/10172187/
> [1] IMX6ULRM, Rev. 1, 04/2016, Table 58-1, p. 3649
> [2] https://patchwork.kernel.org/patch/10156121/
> [3] IMX6ULRM, Rev. 1, 04/2016, 30.5.47 SW_MUX_CTL_PAD_ENET1_RX_EN SW MUX
> Control Register (IOMUXC_SW_MUX_CTL_PAD_ENET1_RX_EN), p. 1357
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
Looks good to me.
Reviewed-by: Stefan Agner <stefan@agner.ch>
--
Stefan
> ---
> arch/arm/boot/dts/imx6ul-pinfunc.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6ul-pinfunc.h
> b/arch/arm/boot/dts/imx6ul-pinfunc.h
> index 9538b0ed5c11..7b9a4dc38456 100644
> --- a/arch/arm/boot/dts/imx6ul-pinfunc.h
> +++ b/arch/arm/boot/dts/imx6ul-pinfunc.h
> @@ -63,7 +63,7 @@
> #define MX6UL_PAD_JTAG_TCK__SAI2_RX_DATA 0x0054 0x02e0 0x05f4 2 0
> #define MX6UL_PAD_JTAG_TCK__PWM7_OUT 0x0054 0x02e0 0x0000 4 0
> #define MX6UL_PAD_JTAG_TCK__GPIO1_IO14 0x0054 0x02e0 0x0000 5 0
> -#define MX6UL_PAD_JTAG_TCK__REF_CLK_32K 0x0054 0x02e0 0x0000 6 0
> +#define MX6UL_PAD_JTAG_TCK__OSC32K_32K_OUT 0x0054 0x02e0 0x0000 6 0
> #define MX6UL_PAD_JTAG_TCK__SIM2_POWER_FAIL 0x0054 0x02e0 0x0000 8 0
> #define MX6UL_PAD_JTAG_TRST_B__SJC_TRSTB 0x0058 0x02e4 0x0000 0 0
> #define MX6UL_PAD_JTAG_TRST_B__GPT2_COMPARE3 0x0058 0x02e4 0x0000 1 0
> @@ -103,7 +103,7 @@
> #define MX6UL_PAD_GPIO1_IO03__I2C1_SDA 0x0068 0x02f4 0x05a8 0 1
> #define MX6UL_PAD_GPIO1_IO03__GPT1_COMPARE3 0x0068 0x02f4 0x0000 1 0
> #define MX6UL_PAD_GPIO1_IO03__USB_OTG2_OC 0x0068 0x02f4 0x0660 2 0
> -#define MX6UL_PAD_GPIO1_IO03__REF_CLK_32K 0x0068 0x02f4 0x0000 3 0
> +#define MX6UL_PAD_GPIO1_IO03__OSC32K_32K_OUT 0x0068 0x02f4 0x0000 3 0
> #define MX6UL_PAD_GPIO1_IO03__USDHC1_CD_B 0x0068 0x02f4 0x0668 4 0
> #define MX6UL_PAD_GPIO1_IO03__GPIO1_IO03 0x0068 0x02f4 0x0000 5 0
> #define MX6UL_PAD_GPIO1_IO03__CCM_DI0_EXT_CLK 0x0068 0x02f4 0x0000 6 0
> @@ -320,7 +320,7 @@
> #define MX6UL_PAD_ENET1_RX_EN__ENET1_RX_EN 0x00cc 0x0358 0x0000 0 0
> #define MX6UL_PAD_ENET1_RX_EN__UART5_DCE_RTS 0x00cc 0x0358 0x0640 1 3
> #define MX6UL_PAD_ENET1_RX_EN__UART5_DTE_CTS 0x00cc 0x0358 0x0000 1 0
> -#define MX6UL_PAD_ENET1_RX_EN__REF_CLK_32K 0x00cc 0x0358 0x0000 2 0
> +#define MX6UL_PAD_ENET1_RX_EN__OSC32K_32K_OUT 0x00cc 0x0358 0x0000 2 0
> #define MX6UL_PAD_ENET1_RX_EN__CSI_DATA18 0x00cc 0x0358 0x050c 3 0
> #define MX6UL_PAD_ENET1_RX_EN__FLEXCAN2_TX 0x00cc 0x0358 0x0000 4 0
> #define MX6UL_PAD_ENET1_RX_EN__GPIO2_IO02 0x00cc 0x0358 0x0000 5 0
next prev parent reply other threads:[~2018-02-06 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 20:47 [PATCH] ARM: dts: imx6ul: rename mux mode name REF_CLK_32K to OSC32K_32K_OUT Jörg Krause
2018-02-06 16:27 ` stefan at agner.ch [this message]
2018-02-08 7:22 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2dcbad84f9237adf072e005d15d65ef@agner.ch \
--to=stefan@agner.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).