From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E7D1C2D0E4 for ; Mon, 23 Nov 2020 22:36:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7706A206B7 for ; Mon, 23 Nov 2020 22:36:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TD6xX763"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="Yp8F5fGa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="cJ+a9PcT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7706A206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ck/cK3gVYZcDvhNDOKt4w7uPALtGOq+2Wlk7kdTNtGE=; b=TD6xX763wH447wjAw5Ug6QG5U UtnXUh9TyygwUKsGD95jOIi7igZCwFkC7wZ6ZR7uQT2x6CRmUbzFp0XmQaBZmdV4HLxp5/sznIV+B sbWTxNqcuRzfKZ9YuCxDbNSWk4ye6oDmOEzd9fUvjxxXTon2lkW19IzqJd4rO5vFDsSO4lHmWXdTS 0A9I374IsslArq3BWGBn+y6spJoQ8dI9X1Rl2/FLZN+b3pSL3tOF74m2+KWxXEsw6z0JSQ+kMHeOL GSgezm4YEUnDSHI/S4LlVQobnPwyRAp+QSHwGhyN3G3+VUvmnoaGReEgmUWFTUM28OV2gQ9gJNIfR shj1cP/CA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khKR0-0003zo-Ic; Mon, 23 Nov 2020 22:35:46 +0000 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khKQx-0003z1-Gs for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 22:35:44 +0000 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0ANMZ43I006260; Mon, 23 Nov 2020 14:35:04 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=pfpt0220; bh=FltfOxyfQCCW74Va6hnp+4W2QwwfgI9c9opVOpNeFk8=; b=Yp8F5fGahNIZHxGJg2fBjdsYvpeTz4BZXbFnLoV5ybQNq86O7mGdVb1X8wEbZVzpejSf ZWsXch6apVeNhxcBSsYCU2mxS3WuGeU7jG0PYD7yhl/grkatWJpRwHxbeRrvZBvpT+7V 94oQ8G9KSCkMlffy7MngYrOk59COreJ3w41bPMssnsrAqzVEQX4YKIVH+mpNHmBbIq0F t1gAOxqbFxn7aD1kdelF5xK5Gn1wbqotrxw9U2FEqfrhH3ZTFv/iTtvH5bEBbyom/tpV v1e2GIGmvZ1DFIZcO1Qh+s/IhjRiwb2yD6ciFgYFM/CbRG/Apk+6qrbY7ioHNbnf1G3D Eg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 34y39r7dv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 23 Nov 2020 14:35:04 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 23 Nov 2020 14:35:02 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 23 Nov 2020 14:35:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dVcRp5x0rlXpsBx1zz+rziDwK/sKnrwcCuGmTluu6ILb/AuKUFA2XSrsEjgwrGaf8E77Wda5TxCyHWjKEj6np/NxeQwQNUrokYfu1DDwSlwn9UaNkiBjUZ3vulznCjQT1CVpf1txw+68uumoRVzb23E/hU/MX6TiSqLIVxlL/TtEcbFVZ8ensBFdMzoVM/LyIVgnO56o/L0IwemURPJkUDLQHjP08uW4hzszaZcI8qMpN/mC4pN5UFgBo+ACjt4au/glEi8qMUKVJN2SsIjaecx4MVgjIjRUrV9dZ9YPn3RCQ8H52zIZSATUnD9350yN3EToVP+73n0/b77FH0v2pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FltfOxyfQCCW74Va6hnp+4W2QwwfgI9c9opVOpNeFk8=; b=d0DRO4PUeTcmwjJmZ3woS+EjbDLpe3U6Sk65OFEI1bSELJQeHCtLkwM8akFFyCyJ36q6cSSjK5OpKM6mXAzFWyqyIRYqbPsBoawBl5mP0vvlJyGw4W+2+TPs+5N8gTpz1ouU4zz+Bk5kSCw9bVsdUbK7cTMTxhGDiUP/J5S8TGRei6IE4aGg4Xn31qyuIJD2+mB4yBCytQm8SGzxN1zj1LU8tnuMsFKR0ssXwCCVRu1WvsK2w6HVN0dlPRHBfnFDGauBmiL66UU2R236MLmWzP1fWipqbOQI9gbmQgvAeCS4f95/vmVftpn9U1B93iC7IFn7+MqrM+MFFaHI2YC34A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FltfOxyfQCCW74Va6hnp+4W2QwwfgI9c9opVOpNeFk8=; b=cJ+a9PcTTHBsp5mNBrPJ1wcOcYjkEgZh00N41MCqe7wux5wsrKttpqBa7JvnOPh4MkukYsGcqAmO1jXdvBAQrEM+LhAt1f5Cf8IhmMV52jPlWQXeKJQyEA4Xfn/E/hC7bbfi//j3h7xGshUR4koWjTUH2obE5UVdAE+r7YKGAoQ= Received: from MW2PR18MB2267.namprd18.prod.outlook.com (2603:10b6:907:3::11) by CO6PR18MB4052.namprd18.prod.outlook.com (2603:10b6:5:34a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Mon, 23 Nov 2020 22:35:01 +0000 Received: from MW2PR18MB2267.namprd18.prod.outlook.com ([fe80::e17f:37fb:4eb3:c703]) by MW2PR18MB2267.namprd18.prod.outlook.com ([fe80::e17f:37fb:4eb3:c703%4]) with mapi id 15.20.3564.039; Mon, 23 Nov 2020 22:35:01 +0000 From: Alex Belits To: "frederic@kernel.org" Subject: Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Thread-Topic: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Thread-Index: AQHWwejhJlApE01BIU2RlahAgN9o7A== Date: Mon, 23 Nov 2020 22:35:01 +0000 Message-ID: References: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> <76ed0b222d2f16fb5aebd144ac0222a7f3b87fa1.camel@marvell.com> <20201123221336.GB1751@lothringen> In-Reply-To: <20201123221336.GB1751@lothringen> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=marvell.com; x-originating-ip: [173.228.7.197] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dbcc4518-e581-41e1-8dc1-08d890000420 x-ms-traffictypediagnostic: CO6PR18MB4052: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jMxEmJ5FqyNhO0/TRlkyNaJ3kBWW4AryyDo/XdDgdPx+DWf6YVzcCKAt/8bw4bdqXYw3yeZMK3dq3QniucPgeqvuZ7pxIxil/n/AUxDVmsreYarcMS0ui40NmEFM4miWuQ7rytUCoVKdruCl/MOr9bbVO/L3DImxPPQr5clDJ57xuF0YD7HhYbjddAsJpX5UMF5HdjPigW+16DOrYDn2LW4SFQoUEAPKnRnWELMq78+CqdrCz4ZA8Yxqrh3ap8angfVxJDOfd9pZWl0mJnQ79dflni0MzY3BDmo2Eps5nFJp5w7LiIvFk64Mb7yQSDd3mSdXTewNy5mGADH5FAAqDw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2267.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(366004)(39860400002)(396003)(91956017)(6506007)(76116006)(316002)(83380400001)(86362001)(36756003)(2616005)(26005)(54906003)(7416002)(2906002)(186003)(71200400001)(4326008)(478600001)(8936002)(6916009)(8676002)(5660300002)(6512007)(66446008)(66946007)(66556008)(4001150100001)(66476007)(64756008)(6486002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jTri6gqhZ4rwKwYXFZySaTwatfKgg8nD/MBnOUAqvl8NMnPahGaYo5Y/9iI7bjgGqZwdNDWCaSNJ50Ku1Xy4/SA83udq0sNdjmncO06xTbNbtQ8XOkte6ulf6qL05oz8wzxQCckmZP6HhVruCrbItPsd4ur3qF1ARTSL8VaMMRu0Iuyi5WSBnP1s6ejlYQrAm+e6Ek0qXFGUT1fs7nvDkst1TFKRJcMvS4wN2fg7/h0G35ooY9Z9esKXW2UlDtT/7TXD+R3M/9seniYGk28FpMVSr+czFOsLzlbzN8UdtIkursNx9SdKkVhqTnswUF7+3k6kX+XpVmSJUZkQ75JG9W6ESReEWwxipsddGr5vei9awLsOYN3NuKPdX8ZFSxjCEhHFNcEREEIQS/vqmwvN5dzIDx2SeTQdTCnx55ywXWdZOdD1tLZI+WppK5ZSHtlyTPDiGX6xXj9ECOlLW9NoIYTwqMpwAfMADNl5bRNdBGAdihhjdF3g4kf7xzsJ5RwQLxSTd6jr4RhQhjKNkUIZ7fBDFOrLZdXuejvzfLfL1T9VM1SQ6hZw2GYFzI+A4Nrid5Q/InfWMi662GByPyfbgkKfJQ9pG8xXhB5illJPWVi9niRXGx9HyOq/kh2Xgwe1WRxbfQK6jyz6EZVw9s2fwioUv0dNImS8xCmt1koFaPNcDccxQGISWUVroCLz7UoRrrYgchzIrC3djiGE7zy8FwZuXF2qeOkDFg6QMZqhuojrH5MWRRc1Cb9fQeRfXIcHOf8XALMvK4HoquA/cbn1ul/y2Y/lE6Ir+ieRDlOoFuMqAAyPQpzN7+Efd42TFoll6SsABn1QlcAQqJC+ZKCa49U/kr2KV45VG57rHWWR724xUoYM078Fb/tvpT3NFEDaDjocQ9ZZyU1CICov/UxR+Q== Content-ID: <331BF2DE0E087745A23E25C258E0CD06@namprd18.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2267.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbcc4518-e581-41e1-8dc1-08d890000420 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2020 22:35:01.5018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8gmhv7qNkFSrGZxtoIcnls+1Ht+HtS6YJOFy48c6gX2F0muNiXJwLOXjY53CxRqOYIlIw43bAM3T6LsMXoJx3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4052 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-23_19:2020-11-23, 2020-11-23 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_173543_641430_94F58A98 X-CRM114-Status: GOOD ( 29.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arch@vger.kernel.org" , "nitesh@redhat.com" , "pauld@redhat.com" , "catalin.marinas@arm.com" , "peterz@infradead.org" , Prasun Kapoor , "mtosatti@redhat.com" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "davem@davemloft.net" , "leon@sidebranch.com" , "netdev@vger.kernel.org" , "peterx@redhat.com" , "trix@redhat.com" , "tglx@linutronix.de" , "linux-api@vger.kernel.org" , "will@kernel.org" , "mingo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-11-23 at 23:13 +0100, Frederic Weisbecker wrote: > External Email > > ------------------------------------------------------------------- > --- > Hi Alex, > > On Mon, Nov 23, 2020 at 05:58:22PM +0000, Alex Belits wrote: > > From: Yuri Norov > > > > For nohz_full CPUs the desirable behavior is to receive interrupts > > generated by tick_nohz_full_kick_cpu(). But for hard isolation it's > > obviously not desirable because it breaks isolation. > > > > This patch adds check for it. > > > > Signed-off-by: Yuri Norov > > [abelits@marvell.com: updated, only exclude CPUs running isolated > > tasks] > > Signed-off-by: Alex Belits > > --- > > kernel/time/tick-sched.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > > index a213952541db..6c8679e200f0 100644 > > --- a/kernel/time/tick-sched.c > > +++ b/kernel/time/tick-sched.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void) > > */ > > void tick_nohz_full_kick_cpu(int cpu) > > { > > - if (!tick_nohz_full_cpu(cpu)) > > + smp_rmb(); > > + if (!tick_nohz_full_cpu(cpu) || task_isolation_on_cpu(cpu)) > > return; > > Like I said in subsequent reviews, we are not going to ignore IPIs. > We must fix the sources of these IPIs instead. This is what I am working on right now. This is made with an assumption that CPU running isolated task has no reason to be kicked because nothing else is supposed to be there. Usually this is true and when not true is still safe when everything else is behaving right. For this version I have kept the original implementation with minimal changes to make it possible to use task isolation at all. I agree that it's a much better idea is to determine if the CPU should be kicked. If it really should, that will be a legitimate cause to break isolation there, because CPU running isolated task has no legitimate reason to have timers running. Right now I am trying to determine the origin of timers that _still_ show up as running in the current kernel version, so I think, this is a rather large chunk of work that I have to do separately. -- Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel