From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: Paul Gerber <Paul.Gerber@tq-group.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: (EXT) Re: [PATCH 1/1] thermal: imx8mm: enable ADC when enabling monitor
Date: Wed, 1 Dec 2021 15:52:04 +0100 [thread overview]
Message-ID: <f3248b92-c6db-c3a3-f26a-65a2fd272d4c@linaro.org> (raw)
In-Reply-To: <ea1af2b2091c0cab822c9ef5810db6936365d7ef.camel@ew.tq-group.com>
On 01/12/2021 15:45, Alexander Stein wrote:
> Am Dienstag, dem 30.11.2021 um 15:49 +0100 schrieb Daniel Lezcano:
>> On 22/11/2021 12:42, Alexander Stein wrote:
>>> From: Paul Gerber <
>>> Paul.Gerber@tq-group.com
>>>>
>>>
>>> The i.MX 8MP has a ADC_PD bit in the TMU_TER register that controls
>>> the
>>> operating mode of the ADC:
>>> * 0 means normal operating mode
>>> * 1 means power down mode
>>>
>>> When enabling/disabling the TMU, the ADC operating mode must be set
>>> accordingly.
>>>
>>> i.MX 8M Mini & Nano are lacking this bit.
>>>
>>> Signed-off-by: Paul Gerber <
>>> Paul.Gerber@tq-group.com
>>>>
>>> Signed-off-by: Alexander Stein <
>>> alexander.stein@ew.tq-group.com
>>>>
>>> ---
>>> Often this bit is set already by the bootloader, but in case this
>>> is not
>>> done, the file /sys/class/thermal/thermal_zone0/temp will always
>>> return
>>> -EAGAIN.
>>
>> Does it deserve a Fixes tag?
>
> The more I think about it, the more I'm inclined to add one.
> Please tell me if I shall iterate v2 adding a Fixes tag (or other
> changes)
It is not necessary to send a V2 as the commit log will have a link to
this thread. Just answer with the Fixes tag, I'll add it myself to the
change log.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-01 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 11:42 [PATCH 1/1] thermal: imx8mm: enable ADC when enabling monitor Alexander Stein
2021-11-30 14:49 ` Daniel Lezcano
2021-12-01 14:45 ` (EXT) " Alexander Stein
2021-12-01 14:52 ` Daniel Lezcano [this message]
2021-12-01 15:19 ` (EXT) " Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3248b92-c6db-c3a3-f26a-65a2fd272d4c@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Paul.Gerber@tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).