From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00701C46CD4 for ; Tue, 26 Dec 2023 09:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RXiWb+ekR7G77m8+V0LBGszc0V5NnlP+EeKCyeCgQl0=; b=iwlBevN+lGTbf8 /fHTa4uFplCWM+Y9pIvkGC/ql4L2Ipa1XxCHlYTqRfzrAGnBKV/vmfQ8xer0tikkWBH8HqJxrY9p7 AYIPBLnO/5qeB92GqVYxYjZ8X3PUEC66aqmFr6ZNKAjJO95V1mHMhlLCKV/S36IYQTa4SH3Sxp/sq U+dQuAUIsoZWjJAkMiYW1axxArGDZ/WZYRGUuOuGmHXxzk9odnK/RCsXIjA07iWhBHE9z1Os9aqqQ rEFokGjE35T5c89ET3OuzHSUkuUNXuXaZdRs+e39s5lUls3DigEzIULV6aIoSvuPnNiu/EB58gkka oSSf1d7CyYVLWdDBJ4ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rI3RZ-00BxqO-0h; Tue, 26 Dec 2023 09:09:45 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rI3RU-00BxpQ-27; Tue, 26 Dec 2023 09:09:42 +0000 X-UUID: 79b56266a3ce11ee9a662f17bb45267e-20231226 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=j6ZqMXAzo/hn6Nx6P+QNs7O4911FhhoRJoFR2OHUE40=; b=QswsXSw9RGAqOaOK5BEuymzjVIug+uEA0sylgC5VBLiZ4x08pJhMu/LzdvTs80D6JGNPsNHat3O9I/C1gQzjBl4DreQE+PIG2aD0I8ZzKiGnleLg+jG+4jivIYByD0BwuixAWVlcmgC/46a9RP0+6kI51qZfdoNGD6HhINtS3ww=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:f0663f08-deed-428a-8a73-cf5bdd34f506,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:0026ae7e-4f93-4875-95e7-8c66ea833d57,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 79b56266a3ce11ee9a662f17bb45267e-20231226 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1631937564; Tue, 26 Dec 2023 02:09:29 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 26 Dec 2023 16:58:50 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 26 Dec 2023 16:58:50 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFtGMW2Qdv3MuIbjQLbqb5UdXLC8oc2iXwfwF9xCXT3GBekKG7gUa1tCCwgSKAVNK/73CFaLGZF97H1knF5CDIRrOBER+Wb7xwk4ZuC9B0LdlQJK2Ssg5w0DakUX5MzCLqxr7kYxsMwlUdiZIVIdNJICY3HzLeh+Y1LXM+LEn+P9ZRToK4NAAEW5U4o7AophVzoBNFo+osvotFGMlH6X3tjsgmQXL8SsdJZrfkgczVI/yaAsVZY3KtxmbHQQkxW1ANyGqFcWTzpnsQesBnq9KgsHBKKGXUOyF7HActKD0yacDd9p46VC9sHXzIf2BG1toVIshNYhiWMI0BxrVwPbfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6ZqMXAzo/hn6Nx6P+QNs7O4911FhhoRJoFR2OHUE40=; b=AQMbHP+CnOS0LOV5+X9J1yUcTB2dHDsp+d7bqghaw2O4jksP0/rjIKXJbNqaqzawVGcp5KqTVS1IMc59BT/adhHL5JYdcJU8SRFFbeuLC50AGsXzgkB1AUEpZheyqfapr/YuH56GTXTzt+OBIDTt5d3PrlP0t04VbrJgG3lkGLVn0rrhyEjaRXR9gx0DsYJyFqYQM9ZQMj/go3JXqgdHn/+He9qASaXloBrGJm93zB1KV511yLYJAMq8fryJ5yh91/yDoThnBgMdoskACrinFj4Fazumlm4+0xlr8gr+EYlv++mqCad0VvxZN+UANs3QngaHx1apceRGeTPbC7l7vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6ZqMXAzo/hn6Nx6P+QNs7O4911FhhoRJoFR2OHUE40=; b=oFBeInZ+f4F/ep38ws89/gR9fyJAlxAEwgtCL8269qt8S6h7gyyvaPr1siDqH7NVujzmKNUT/gzq++FjJv11zTEUgQT0wl7pNyzW0NlwS3UNhEpOP3vLvupuTu/7DViOUS0me5J1PAK1yarpmqkUFI3t+IROQW2MItmasZzxoOA= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by SEZPR03MB7753.apcprd03.prod.outlook.com (2603:1096:101:128::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 08:58:45 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::eb43:57cb:edfd:3762]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::eb43:57cb:edfd:3762%7]) with mapi id 15.20.7113.027; Tue, 26 Dec 2023 08:58:45 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: "jassisinghbrar@gmail.com" , "matthias.bgg@gmail.com" , =?utf-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "angelogioacchino.delregno@collabora.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "chunkuang.hu@kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?utf-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , =?utf-8?B?Sm9obnNvbiBXYW5nICjnjovogZbpkasp?= , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , =?utf-8?B?SmFzb24tY2ggQ2hlbiAo6Zmz5bu66LGqKQ==?= , =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "mchehab@kernel.org" , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "conor+dt@kernel.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 8/9] mailbox: mediatek: Add CMDQ secure mailbox driver Thread-Topic: [PATCH v3 8/9] mailbox: mediatek: Add CMDQ secure mailbox driver Thread-Index: AQHaNJMHlgU6p3MSPUCi0pus2NsH47C7Sk8A Date: Tue, 26 Dec 2023 08:58:45 +0000 Message-ID: References: <20231222045228.27826-1-jason-jh.lin@mediatek.com> <20231222045228.27826-9-jason-jh.lin@mediatek.com> In-Reply-To: <20231222045228.27826-9-jason-jh.lin@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|SEZPR03MB7753:EE_ x-ms-office365-filtering-correlation-id: 2b4262ec-e764-458a-f952-08dc05f0de03 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xB8Tar5ld/6zal3e4+2u3NZA2H/b/nyqiVS0Dyfmnbu5Plv1tbu00ySdAVJJ2OcDMc7C1pVWbeKqy56iTIlxa0QP+baEiKOBhaQEMyFFR8xdBuWa63et/sNsN4sWtW2gaQoTxFmSriNVbviwL1u4wwPmvJlpO9emF2xgMPh1BMpdjvjeFPUx/0G69c1ZkRY8FOL590AB9wqo8yf5NFkTIf84bgWnAYOq9ytpbWUIwZXxGHRQNGn2sgUDQaObxq91KftaFeqLqhgEhzO6S8MantprNi7rGVbY3vKeoeaKeOI9zGb9I8+kWRm3qHKgAjegN98mYi81Sp+GwB/ePqiiGds4CmFEE3icGi2yRPzWv6Lauyz0uijxSyPWo6V0M4kGyMovhyaPSSStIgz7avApu4TJH3sq/T2lx8JRbNh1Ioct1DuKtSUuxspASMpm0cAad/ZAmW4uxe2uXjuhu9gJQdg/u7e2Altn/wRb0YbmTry1WTeSgFuXPhSmOrJKSHQ1GZI3MRocTEy7WlsPqy1gtWreAtqf8iNSc5/0xiOaF+A5/oAkN2KPNyFYigB6WwgNQ/reRkuKHAxlWDrGIDf3cAaWY6AIyqt1+dFvFIQ85/CN0+i+SJ10brDA9x3MrzWhpglkPk+KwzNHqA7Sk0XcXiW+VIoyU18Ryv/ZkTUJzzo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(396003)(376002)(136003)(39860400002)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(36756003)(85182001)(71200400001)(6512007)(6506007)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(6486002)(86362001)(38070700009)(26005)(38100700002)(122000001)(83380400001)(2616005)(41300700001)(2906002)(15650500001)(5660300002)(4001150100001)(8936002)(7416002)(8676002)(478600001)(316002)(54906003)(110136005)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M0grYk5rMTdTQS9DTGZMK1h5eUt4djNxV09NZXJNTm5GU3VwR2tyOUVzSWRW?= =?utf-8?B?SWpEM242eUlZVmNtQWpKcUhrbHlKUmhFVW5DKzZDQm5sdXZleTdtWXNMODdX?= =?utf-8?B?Z1l1cU1JaEFwRDd4eDVyRTJrd3libjRZcnhybGRWcGZjNWU4Rms5dXR3Qzdw?= =?utf-8?B?VUlBU0QzTHArV0tGLzVodklMYUp2eWZEQzIrR2pxOFNVeVdvQWhkQmFqSUY0?= =?utf-8?B?aHE2dnU5WjJqOHNrREltUkRlZStEQU9wdm5kN1hpaDRFa0ZFNU1vaHppZFlm?= =?utf-8?B?Rkl6TGJqTUNJSTkrbStscjBGUCtmTytObFZZTGJMak5ESEo1djBoT3dNdHd6?= =?utf-8?B?Q1MyZDRwSy9EcXViTy8yb2lEdTM2QjNoSEJwV1E1UFJHVjhQQ2JMS1VPMldy?= =?utf-8?B?UXFUVlQvMzloT0ZZVXpQVmpQUzExR3FDY2M2NjE5bEFqQ2FhcU05K0t4Y0F0?= =?utf-8?B?RDFLL0FoeVU5Y1Z5ZWFhcHowdlY2QjdDWFlLMFVFWHFSSVZSbSsvTzBPVmRX?= =?utf-8?B?d1NhY25DU1NRUWR5bStEUlhzaEhwQW9obUt3T3FackxpK05sVXlsTEEvbE9B?= =?utf-8?B?cGRYQ0V1VDBEVisvWEt5bTJNRlFTbG1EZ0tPVzcvRTN2aS90cS92UTF3RGFx?= =?utf-8?B?U1FIaGpaYUFqeVI1WXl5T2kyRHFQZkFFSy9zL0xYaGVGOFpVY0VyckIvN3ZL?= =?utf-8?B?SDk1Zkh5ZkhxK2E2eEtlTzVISnd1cXJzQWxTdlBHWmdmYVk1SXhXUnJmQ2NG?= =?utf-8?B?eXdSR2w2dTl5dWdxQTBzZFgwTUtCWTVyN1JONlJRamRkYnpYc2t6OGlpcnQ2?= =?utf-8?B?VWQwaG9aSGhlaUNEZzh1Ui9FNGxuY2FQTDlNTXkrclBadjZVaFhHb2JiRkd3?= =?utf-8?B?T0hCcVZLQWk1Y2RyRHRKMlE3ZUNvRzcwWkZoSFdOdFA5eDYrZ2k3b1hiS0k3?= =?utf-8?B?N3NaUE9UWnRkMGpYdG5KTzNUenpIblo3bGd2QWwrblN5U3B1djBNMTc0WTd2?= =?utf-8?B?cGR5cklpNVdmY3JaS2dGVm9abElUOGRkNFNMQlFob3QxbXVjSHdaSHRkN1ox?= =?utf-8?B?NCs3UGZrNjc2RllXcTBTMVZpaUVqYm5nQ01xT05qRVVWVzBRYUkxRUVsQy9J?= =?utf-8?B?dFRHdVk0U1lXc0VXU0hwbUdNc0RIMjBiTnRkZ2NXaUdYcVREMDNVd1BGRWU4?= =?utf-8?B?UE81UFRuOWtGRUd0V1ZoQWVTWXI2OThRVEhKQjlWaFArRmFGTEFFbEN5NEtT?= =?utf-8?B?SFV4QnVsdXMvSnNSVFNvR2s4VTYxYmZ6WktlUk5jY01xeHFFYmtjWEMrQThO?= =?utf-8?B?aVM1aURkNlZaWlJ6TWllVkl2MTNlbUNQUzI1Q2ZIRy9CUDd3clppWE5JalFW?= =?utf-8?B?SnpIa2hSTGhXWE9wU0VXc21tQmQ4eVA1M2Y1cTh1Rk9WVTlSZ1Z2MDhaNGVU?= =?utf-8?B?WGdQby9tNmVEQmFSQ0hzV1pwVGJJZzFzcXQ4ZFRidTl4emdTNTFWVFB5UGxX?= =?utf-8?B?K0VIY2lFcW01eFFkcmF1TTNyZW9HUEQ2Y2lzcVZ5WkNJbi9sOHNsaVFLb3V6?= =?utf-8?B?dzZYSlRBbWlVSEwzUmxyZndSb3NhQkdJSkREdEpubGpYNHA4MWlVOUxBUXBJ?= =?utf-8?B?bFkvWHZ6MFhDellKVTVhalZ0b2tscjFjaHV0cG9ySjh1b0ZtRUZvMXBOWWk5?= =?utf-8?B?eFJoQ1RYR3BFNWZQb1d1UkhSUUtSdHJObUJkSWdpb1BEekFRVFN2K0dUYjZC?= =?utf-8?B?NkRLamx2TW5ISjUxcUJIQThTM0cvL2ZTblJ3SEJzVGRxTXI0YjRXLzJiYWlB?= =?utf-8?B?WnlKUjNHUWhsNmZKb2hYM3dDYVh3Q0pMS3A5YnFRM2RVOFczdHlQK080RGpy?= =?utf-8?B?b2Vpbmk1UG1sTVNDTVIyWE85Qk9wMmpWb3kyQTFWeDBad29vY2g3TmZlOVZw?= =?utf-8?B?L2JaQXlaQmhLSlMybnhYQ0hSSnpsaGhhWmJRL1NQMUlpU2lnaksxRDJtMEl3?= =?utf-8?B?TWgzSGR1UDNqdWR3WnBFMnVrc1VoMFZrV1h6emlKbWpHSkttMTJCOTZtbi9w?= =?utf-8?B?Um0zWlRMeEtaQW52MlFaWVFwOE9zaHJKajBuZnVnVlAzWi9oZjEyWHAwS1lN?= =?utf-8?Q?CHnqKOxU0mShdfK148Ds9i4St?= Content-ID: <753C52BB8991954DABD3D9BA8DAD72C8@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b4262ec-e764-458a-f952-08dc05f0de03 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 08:58:45.4840 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: udbRi6MR9uLmlgv0PFiO7ZhXSjpHXEf3LuRAgnSn+skiroyHvcgBsdqb3YLBsCSdZFdwkIMBVh1OXx2ocKIJqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB7753 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--15.033300-8.000000 X-TMASE-MatchedRID: VPleTT1nwdQOwH4pD14DsPHkpkyUphL9qQ9UezeTkThu4FknyqyshF1Q po5pNysMe29pTfBhqOY7b3Js3F6vVD1LciJB3541o65WJt1k1O8TbU1KYGoQp3vsbfoZixUT3oz JRX7b4Nkl3UHzTyg4SDjMd1TWYQcanuh7s4XRTZYbmaDSnOqZfqcX+euO9ejcvDa284z78yfyKd Kafi2Z4+LzNWBegCW2PZex/kxUIHW3sNbcHjySQd0H8LFZNFG7bkV4e2xSge5/sWXVzFBYYzVhL rNyPF2sSTLHh5jqITBw9PR+tf+HQTZFEgw6u+Np X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.033300-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: D837212CDECCBA21E2D301C87A354A5F2BDB4ABB95B19956571D895E6B4B92152000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_010941_019223_552733A5 X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Jason: On Fri, 2023-12-22 at 12:52 +0800, Jason-JH.Lin wrote: > To support secure video path feature, GCE have to read/write > registgers > in the secure world. GCE will enable the secure access permission to > the > HW who wants to access the secure content buffer. > > Add CMDQ secure mailbox driver to make CMDQ client user is able to > sending their HW settings to the secure world. So that GCE can > execute > all instructions to configure HW in the secure world. > > Signed-off-by: Jason-JH.Lin > --- [snip] > + > +static int cmdq_sec_fill_iwc_msg(struct cmdq_sec_context *context, > + struct cmdq_sec_task *sec_task, u32 > thrd_idx) > +{ > + struct iwc_cmdq_message_t *iwc_msg = NULL; > + struct cmdq_sec_data *data = (struct cmdq_sec_data *)sec_task- > >task.pkt->sec_data; > + u32 size = 0, offset = 0, *instr; > + > + iwc_msg = (struct iwc_cmdq_message_t *)context->iwc_msg; > + > + if (sec_task->task.pkt->cmd_buf_size + 4 * CMDQ_INST_SIZE > > CMDQ_TZ_CMD_BLOCK_SIZE) { > + pr_err("sec_task:%p size:%zu > %u", > + sec_task, sec_task->task.pkt->cmd_buf_size, > CMDQ_TZ_CMD_BLOCK_SIZE); > + return -EFAULT; > + } > + > + if (thrd_idx == CMDQ_INVALID_THREAD) { > + iwc_msg->command.cmd_size = 0; > + iwc_msg->command.metadata.addr_list_length = 0; > + return -EINVAL; > + } > + > + iwc_msg->command.thread = thrd_idx; > + iwc_msg->command.scenario = sec_task->scenario; > + iwc_msg->command.eng_flag = sec_task->engine_flag; > + size = sec_task->task.pkt->cmd_buf_size; > + memcpy(iwc_msg->command.va_base + offset, sec_task->task.pkt- > >va_base, size); I think it's not necessary to copy from normal command buffer to normal command buffer. Just iwc_msg->command.va_base = sec_task->task.pkt->va_base; You have a secure command buffer for secure gce to execute command. If you want to modify command buffer, copy from normal command buffer to secure command buffer, and modify the secure command buffer. Regards, CK > + iwc_msg->command.cmd_size += size; > + offset += size / 4; > + > + instr = &iwc_msg->command.va_base[iwc_msg->command.cmd_size / 4 > - 4]; > + if ((u64)*instr == CMDQ_EOC_CMD) > + instr[0] = 0; > + else > + pr_err("%s %d: find EOC failed: %#x %#x", > + __func__, __LINE__, instr[1], instr[0]); > + > + iwc_msg->command.wait_cookie = sec_task->wait_cookie; > + iwc_msg->command.reset_exec = sec_task->reset_exec; > + > + if (data->addr_metadata_cnt) { > + iwc_msg->command.metadata.addr_list_length = data- > >addr_metadata_cnt; > + memcpy(iwc_msg->command.metadata.addr_list, > + (u32 *)(unsigned long)data->addr_metadatas, > + data->addr_metadata_cnt * sizeof(struct > iwc_cmdq_addr_metadata_t)); > + } > + > + iwc_msg->command.metadata.engs_need_dapc = data- > >engs_need_dapc; > + iwc_msg->command.metadata.engs_need_sec_port = data- > >engs_need_sec_port; > + iwc_msg->command.normal_task_handle = (unsigned long)sec_task- > >task.pkt; > + > + return 0; > +} > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel