From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F49C04AB4 for ; Tue, 14 May 2019 05:29:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB6D02086A for ; Tue, 14 May 2019 05:29:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R7gp3mOg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="DqVGD9Sp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB6D02086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zWjCDg3Bn3G9YS4m7onqZcIzZAxAYpldkfOWmpWKxEY=; b=R7gp3mOgtIduA1NGgz1PdonAf tsJAFSHqaBaf+7cGTRZnpUBH6lDJ9e0m0jRsDG7XF/t3AQwLWBAtvP/6MpOfIyT9Fg5SwoB9E6n5y B+kaGX3wZ84XJK4/cWSD/pEHhx9qJ/2t4yapq2FBfPdsRj6GzxvaiMjsm+i4ArTY8AL/P/mVbgFam XMN83V4ZoOUeCF3jZpnMnmmDdf6G94ykXrXHDYGJPllzrYk4IIzPNr2pQ0zJZernDOTZ5oxuvbdvW Icff0tHtx5QMs1fvGMl63pI4xQw5t3T+dUka6j05tfB+JDmufgj8oRRvSNeZcEHB7kkAiqyvaITYI f0T9AUcVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQQ0W-0007Rb-MW; Tue, 14 May 2019 05:29:44 +0000 Received: from hqemgate15.nvidia.com ([216.228.121.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQQ0T-0007R5-2h for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2019 05:29:42 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 13 May 2019 22:28:59 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 13 May 2019 22:29:39 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 13 May 2019 22:29:39 -0700 Received: from [10.24.47.172] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 14 May 2019 05:29:34 +0000 Subject: Re: [PATCH V5 07/16] dt-bindings: PCI: designware: Add binding for CDM register check To: Rob Herring References: <20190424052004.6270-1-vidyas@nvidia.com> <20190424052004.6270-8-vidyas@nvidia.com> <20190426143247.GA25107@bogus> <031df2ca-27de-2388-5f23-078320203f5d@nvidia.com> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: Date: Tue, 14 May 2019 10:59:31 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1557811740; bh=cqJjsaktR+J8Rzac06BPbRbkXCQMRbYeXEjs18+haNc=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=DqVGD9SpIGwB+ICy+zXbqihOzxwZF83U/SQ2oW9SUGBCiTUWbFM2evWjeZaNNRcXp OUdYxDyeRXV/BmgAiiVD8BOefyvDaY7i6G3qmcv8B1QWNg9oUGJEloYXLeAlR6GTP+ 5ft4GbFstcouTV1VmsB5acuJkkQpCXPpm4vYhS6kxxYf7AeOYnfOn77cwsU7UEU5BC qecBcnP7PkPZzkcP0DGTgZ5euLnpKNLHgMv25PXeahLET5puUlat8Tgp13WbKdDq3L cc4MwKxr2dL0MMXQGuzeZT8NQi4r0U/0uogEF/Q9Fd3KDRQCoVbAwAvbR2vJzBSjH8 j4wCRmXxcqTew== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_222941_140491_5C7C825C X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Lorenzo Pieralisi , Mikko Perttunen , Manikanta Maddireddy , linux-pci@vger.kernel.org, Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , kthota@nvidia.com, Kishon Vijay Abraham I , linux-tegra@vger.kernel.org, Thierry Reding , Gustavo Pimentel , Jingoo Han , Bjorn Helgaas , Jon Hunter , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , sagar.tv@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/13/2019 8:45 PM, Rob Herring wrote: > On Tue, May 7, 2019 at 3:25 AM Vidya Sagar wrote: >> >> On 4/26/2019 8:02 PM, Rob Herring wrote: >>> On Wed, Apr 24, 2019 at 10:49:55AM +0530, Vidya Sagar wrote: >>>> Add support to enable CDM (Configuration Dependent Module) registers check >>>> for any data corruption. CDM registers include standard PCIe configuration >>>> space registers, Port Logic registers and iATU and DMA registers. >>>> Refer Section S.4 of Synopsys DesignWare Cores PCI Express Controller Databook >>>> Version 4.90a >>>> >>>> Signed-off-by: Vidya Sagar >>>> --- >>>> Changes since [v4]: >>>> * None >>>> >>>> Changes since [v3]: >>>> * None >>>> >>>> Changes since [v2]: >>>> * Changed flag name from 'cdm-check' to 'enable-cdm-check' >>>> * Added info about Port Logic and DMA registers being part of CDM >>>> >>>> Changes since [v1]: >>>> * This is a new patch in v2 series >>>> >>>> Documentation/devicetree/bindings/pci/designware-pcie.txt | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt >>>> index 5561a1c060d0..85b872c42a9f 100644 >>>> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt >>>> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt >>>> @@ -34,6 +34,11 @@ Optional properties: >>>> - clock-names: Must include the following entries: >>>> - "pcie" >>>> - "pcie_bus" >>>> +- enable-cdm-check: This is a boolean property and if present enables >>> >>> This needs a vendor prefix. >> Why only for this? Since this whole file is for Synopsys DesignWare core based PCIe IP, >> I thought there is specific prefix required. Am I wrong? Also, CDM checking is a feature >> of IP and DWC based implementations can choose either to enable this feature at hardware level >> or not. And whoever enabled it at hardware level (like Tegra194) can set this flag to >> enable corresponding software support. > > TBC, I meant a Synopsys vendor prefix, not NVIDIA. > > Any property that's not from a common binding should have a vendor > prefix. That hasn't always happened, so we do have lots of examples > without. Ok. got it. I'm going to take care of this in V7 series. > > Rob > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel