From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C49D7C43381 for ; Mon, 4 Mar 2019 08:04:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92C392082F for ; Mon, 4 Mar 2019 08:04:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pi0gD7Ev"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="DzZBt/BA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92C392082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vdj5+GMrjevBFSua/VuJNBOg7X7RTtNQyZYmQ+4nsOw=; b=pi0gD7EvGoSQbc U+Xg3dHNz+10xcKJsRbDlpvqckoKTA75PFnpWduBFnw/zPD+4fqnURRHI1+Ftem2iaER+wU3EPm1U sON7WYhPJPpdrjmNo7avvDMTkQpC2qydZhF6+0RZlNAREI9ZcxEGysPLnlwY763vMK+PQKFakV8G5 9l7/HGTrgHZpnX7i9Scry6lF/MKTnN7mRrEr9uDEdOId+QFqLuFL0RdV2vjwvdwqyVIzhbtOLTufo oLUs61Nz2z2O4rC7d3nQvvojwJb0FaHjs2Mj/SQnkORl7UGRwe/J/RF8ox35zUvg0p/FX4a02XbZF 52s8+X4HAn321KFeYpYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0iZq-0007n9-4g; Mon, 04 Mar 2019 08:03:58 +0000 Received: from mail-eopbgr150054.outbound.protection.outlook.com ([40.107.15.54] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0iZm-0007mN-O1 for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 08:03:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Hf4/om2b/QyB7SjdgsfsNQF9uHbn4M6aQkHr3peRu8=; b=DzZBt/BANVF5VQusH6c4Zm/6NhSQ1waCYwJDANYZEWYqyX8DMsczxPeD/dCnIakGXVxJu7iJs0I/B10QVsth9V++9GZvLU+V1dFXdIbll2qdujZ3P7C5tZRT58Oh15HNgnOcq5nVj17BTVnMHAPCSySRU1FZYK0H22aFzpygnxQ= Received: from AM4PR08MB2929.eurprd08.prod.outlook.com (10.171.190.138) by AM4PR08MB0755.eurprd08.prod.outlook.com (10.164.82.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.18; Mon, 4 Mar 2019 08:03:47 +0000 Received: from AM4PR08MB2929.eurprd08.prod.outlook.com ([fe80::e522:c03f:3d0c:f4ce]) by AM4PR08MB2929.eurprd08.prod.outlook.com ([fe80::e522:c03f:3d0c:f4ce%4]) with mapi id 15.20.1665.020; Mon, 4 Mar 2019 08:03:47 +0000 From: "Haibo Xu (Arm Technology China)" To: Sudeep Holla , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling Thread-Topic: [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling Thread-Index: AQHUz5P7c5GVx0ww2U2d9460BIWJxqX7ImCA Date: Mon, 4 Mar 2019 08:03:47 +0000 Message-ID: References: <20190228183220.15626-1-sudeep.holla@arm.com> <20190228183220.15626-3-sudeep.holla@arm.com> In-Reply-To: <20190228183220.15626-3-sudeep.holla@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0008.apcprd03.prod.outlook.com (2603:1096:202::18) To AM4PR08MB2929.eurprd08.prod.outlook.com (2603:10a6:205:c::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Haibo.Xu@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54fe6d66-2831-4015-15e9-08d6a077edf1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR08MB0755; x-ms-traffictypediagnostic: AM4PR08MB0755: x-microsoft-exchange-diagnostics: 1; AM4PR08MB0755; 20:IFYxHqURzaZ2zJ/f2sUDuCpNs8y9UfMbz0uh+nLYBClj3MF7LbXnRvTJQohfeA1NtpNemROu0GTARDPSoXWVKnV7WuRVL8XCRoZwT2PBviLXQsl8XlhIOyQkrfvzKb4c5WSeU2ge83jJ4z8+OusRvnxrlaXaAGgL419y+ORvD60= x-microsoft-antispam-prvs: x-forefront-prvs: 09669DB681 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(346002)(376002)(366004)(396003)(40434004)(189003)(199004)(4326008)(97736004)(476003)(105586002)(2616005)(106356001)(8936002)(7736002)(71200400001)(5660300002)(2906002)(316002)(54906003)(110136005)(14444005)(446003)(11346002)(5024004)(486006)(256004)(71190400001)(68736007)(31686004)(229853002)(6486002)(6436002)(478600001)(72206003)(186003)(2501003)(26005)(14454004)(6246003)(53936002)(55236004)(386003)(53546011)(6506007)(102836004)(99286004)(6512007)(76176011)(52116002)(66066001)(25786009)(6116002)(81166006)(81156014)(8676002)(36756003)(2201001)(3846002)(7416002)(31696002)(86362001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB0755; H:AM4PR08MB2929.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: iXYNy1yxQAFAAmRC1ZvjuXbd3XYppMNtUZM4fAMds+hbbzer8X3QhDPMS+ruExo3mGq/IUTw2xZWP9F9opgKV//JxnmnfV7qJK+/CmvP/d3Jnj2HEulGHDCSyREf7Aek4Uta/Fv/FQG4Mid1xk5c9E2xSO/WWxYZcLIAbbviBqj8R7oW7fB7T60h5gPyu/DblKQUwzIKbyepguJVHkwdV8A1VLDEWUUn2n3XuSfDGBTbj8UxkoLN4Epf0AAA7jXDgSTDx88boe3h5G+rtjn3bt9OXnAKR/GkFWL+nSgY7Hz4wfzG+b2P+Ov8a1BSic7r0mjXP2BD+rtbXtiDX1KA0ohUnawsxtwoKh2j8Ma9QM8BBMB+ksU3OO+7iyV9JzQm7cXTzLUhVIpexRbc1cxNBeekBfFz4mHo7K9rKxuv+tY= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54fe6d66-2831-4015-15e9-08d6a077edf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2019 08:03:47.5968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB0755 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_000354_825190_7DAB3E3C X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steve Capper , Catalin Marinas , "jdike@addtoit.com" , Will Deacon , Oleg Nesterov , "Bin Lu \(Arm Technology China\)" , Richard Weinberger , Ingo Molnar , Paul Mackerras , Michael Ellerman , Thomas Gleixner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019/3/1 2:32, Sudeep Holla wrote: > Currently each architecture handles PTRACE_SYSEMU in very similar way. > It's completely arch independent and can be handled in the code helping > to consolidate PTRACE_SYSEMU handling. > > Let's introduce a hook 'ptrace_syscall_enter' that arch specific syscall > entry code can call. > The 'ptrace_syscall_enter' is dedicated for PTRACE_SYSEMU flag, So I suggest to rename the function to something like 'ptrace_syscall_emu_enter". > +/* > + * Hook to check and report for PTRACE_SYSEMU, can be called from arch > + * arch syscall entry code > + */ > +long ptrace_syscall_enter(struct pt_regs *regs) > +{ > +#ifdef TIF_SYSCALL_EMU > +if (test_thread_flag(TIF_SYSCALL_EMU)) { > +if (tracehook_report_syscall_entry(regs)); Shall we remove the semi-colon at end of the above line? > +return -1L; > +} > +#endif > +return 0; > +} > + > /* > * Detach all tasks we were using ptrace on. Called with tasklist held > * for writing. > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel