From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anshul Dalal <anshuld@ti.com>, Nishanth Menon <nm@ti.com>,
Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH RFC] dt-bindings: arm: keystone: add boot_* mailboxes
Date: Tue, 11 Nov 2025 11:52:38 +0100 [thread overview]
Message-ID: <f372ea12-b8ed-4372-8657-96f09a6d4fec@kernel.org> (raw)
In-Reply-To: <20251111-k3_syscon_add_boot_mailboxes-v1-1-529a27f21076@ti.com>
On 11/11/2025 11:37, Anshul Dalal wrote:
> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
> which might be different than one's available to the kernel (firmware
> spec).
Why is this RFC? You don't expect review?
>
> Therefore, this patch adds the missing mailbox entries to the DT binding
> to represent the mailboxes exposed by the hardware during boot for the
> purpose of loading the firmware.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
> Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..b5f48647a0f09bb930f052ea0f84a78525c925eb 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -51,15 +51,23 @@ properties:
> minItems: 1
>
> mbox-names:
> + minItems: 2
> + maxItems: 6
> description: |
> Specifies the mailboxes used to communicate with TI-SCI Controller
> - made available from TI-SCI controller.
> + made available from TI-SCI controller. All boot_* mailboxes are used by
> + the first stage bootloader to load firmware for the device.
Description does not go to mbox-names, but to mboxes.
> items:
> - const: rx
> - const: tx
> + - const: notify
> + - const: boot_rx
> + - const: boot_tx
> + - const: boot_notify
>
> mboxes:
> minItems: 2
> + maxItems: 6
You need to list the items instead.
>
> ti,host-id:
> $ref: /schemas/types.yaml#/definitions/uint32
You should update the example so it will be complete.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-11 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:37 [PATCH RFC] dt-bindings: arm: keystone: add boot_* mailboxes Anshul Dalal
2025-11-11 10:52 ` Krzysztof Kozlowski [this message]
2025-11-12 5:49 ` Anshul Dalal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f372ea12-b8ed-4372-8657-96f09a6d4fec@kernel.org \
--to=krzk@kernel.org \
--cc=anshuld@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).