From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BD0C433F5 for ; Mon, 27 Sep 2021 15:06:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 391C560FF2 for ; Mon, 27 Sep 2021 15:06:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 391C560FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vCMEhYsKPDzdfOz0SL8/57DmMMgNwzPBVGiUxEBKJhE=; b=ZUDFDRzH0F8gOl Cg0x2nNIuVhgkGSrSEa+XphL/7gnNzDfwkJnt9iu018MNm6E+6Dzw3A5IVSByHYlSoKmXHsHckZD8 20Y2jnZyclhfoPXsEmC7xXGrVdIx5HXTUf4j7Awdjbl+LeI4ous9MiLO4rnwqXpZxvQi22Rn+Boy5 zH4PUN+NmIq2xOHgU42/a9ppUSi0HNmwwdbPsZMR2NGiPeZ7kmxRxx/+VYGxEM1upRFhDcbYqrX0Y BfEMJsFRiC1+1N3ZzXrmekqbC4uUF1X0S2RTvD0zIQGEGIhj1DHOcAW7jKzmcVw+RjsFv+wQCVUml fYCQwbOHA70hvA4NU0Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUsAq-0030us-6I; Mon, 27 Sep 2021 15:04:08 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUsAm-0030sO-6x for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 15:04:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632755042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/mgKtKp5KKfxcrjzch748kWu470axxG1OqY2NSG+pg=; b=G4o6czsuomYR1ifyXyubV3aqKKexjCVmqXWZ267EHOGlySXD/dl7za3yHNlxa+k79vqMRa US+qLk2H4xPRu4egSPZT1O73fLElJ983qBHBADc3WzRZkGGzSqvZFr0oDOqut6w0+AiG6t G46G2yE2cSRHEvytAefXiz8v1e1F3bo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-kgDylEDaMT6EQ6URaGz9jA-1; Mon, 27 Sep 2021 11:03:59 -0400 X-MC-Unique: kgDylEDaMT6EQ6URaGz9jA-1 Received: by mail-wr1-f72.google.com with SMTP id c2-20020adfa302000000b0015e4260febdso14159873wrb.20 for ; Mon, 27 Sep 2021 08:03:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=r/mgKtKp5KKfxcrjzch748kWu470axxG1OqY2NSG+pg=; b=TwWKTrQrkdkSdP2Fk850ZeQVU5+YTVFaIEB/8Ta31u5aOr/lME6EKr4NsTvX06ioNZ rMdo8JscbHSJd0qthynu0zWe/5VB3/iLoEUyBWQa1E/IcSobsZ28n3mICNdo+lkWZNLp 1vkVkEC7aocRWSsd9DE1EFUv5yDQtUF7zEufPvTG+DA9WRbpAubGzsavKekAjm4rGbi3 QaqvmgKQUmBr1H9ZknDFU75u53VIKijsGNkTlEGtBYIFJ3MBekdL817Jo1nrD0q48H54 ShwmCHn6jMV/2gQouDzeDTqgJYVtR16b3eQpUBUHqB7ypgMXepdIRjSt4ojoXVLwh9xt raNw== X-Gm-Message-State: AOAM533hJYB8ibLQ9x1wF3oL/+lmjM5p7Dp3GVuFxcrxu610RHX4UkA/ mjKRXij8HJhSfb4gc/ZD+XJ75wrXL6k361EdIIcBYrKK1wIxuzfnFMz2EVgGGvChAPb6g9Mbqlr rvUa2ELjPICo5p+YNpKDZQJoFCtU4epBcg9w= X-Received: by 2002:a7b:c209:: with SMTP id x9mr388009wmi.9.1632755038167; Mon, 27 Sep 2021 08:03:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEdm9plI8QQmwPL2SFhkzquOawAtG2L3LzWjsrxEcUhatBpqdEXWMPsZ+lvaoVsF5QfHy+Uw== X-Received: by 2002:a7b:c209:: with SMTP id x9mr387973wmi.9.1632755037927; Mon, 27 Sep 2021 08:03:57 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id c9sm15544500wmb.41.2021.09.27.08.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 08:03:57 -0700 (PDT) Message-ID: Date: Mon, 27 Sep 2021 17:03:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: disabling halt polling broken? (was Re: [PATCH 00/14] KVM: Halt-polling fixes, cleanups and a new stat) To: Sean Christopherson , Christian Borntraeger Cc: David Matlack , Jon Cargille , Jim Mattson , James Morse , Alexandru Elisei , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Jing Zhang , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Janosch Frank References: <20210925005528.1145584-1-seanjc@google.com> <03f2f5ab-e809-2ba5-bd98-3393c3b843d2@de.ibm.com> From: Paolo Bonzini In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_080404_367091_0CB5A88C X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/09/21 16:59, Sean Christopherson wrote: >> commit acd05785e48c01edb2c4f4d014d28478b5f19fb5 >> Author: David Matlack >> AuthorDate: Fri Apr 17 15:14:46 2020 -0700 >> Commit: Paolo Bonzini >> CommitDate: Fri Apr 24 12:53:17 2020 -0400 >> >> kvm: add capability for halt polling >> >> broke the possibility for an admin to disable halt polling for already running KVM guests. >> In past times doing >> echo 0 > /sys/module/kvm/parameters/halt_poll_ns >> >> stopped polling system wide. >> Now all KVM guests will use the halt_poll_ns value that was active during >> startup - even those that do not use KVM_CAP_HALT_POLL. >> >> I guess this was not intended? No, but... > I would go so far as to say that halt_poll_ns should be a hard limit on > the capability ... this would not be a good idea I think. Anything that wants to do a lot of polling can just do "for (;;)". So I think there are two possibilities that makes sense: * track what is using KVM_CAP_HALT_POLL, and make writes to halt_poll_ns follow that * just make halt_poll_ns read-only. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel