linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@denx.de>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Peng Fan <peng.fan@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mm: Add i.MX8M Mini Toradex Verdin based Menlo board
Date: Wed, 13 Apr 2022 23:58:07 -0300	[thread overview]
Message-ID: <f3c944abb82efd127533196c5f8eebfb@denx.de> (raw)
In-Reply-To: <20220414001237.280866-2-marex@denx.de>

Hi Marek,

On 13/04/2022 21:12, Marek Vasut wrote:

> +
> +	/* CAN controller on the baseboard */
> +	canfd: can@0 {
> +		compatible = "microchip,mcp2518fd";
> +		clocks = <&clk_xtal20>;
> +		gpio-controller;

Please remove this 'gpio-controller' property as it is not valid here.

Reviewed-by: Fabio Estevam <festevam@denx.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-14  2:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14  0:12 [PATCH v2 1/2] dt-bindings: arm: Add i.MX8M Mini Toradex Verdin based Menlo board Marek Vasut
2022-04-14  0:12 ` [PATCH v2 2/2] arm64: dts: imx8mm: " Marek Vasut
2022-04-14  2:58   ` Fabio Estevam [this message]
2022-04-14  2:56 ` [PATCH v2 1/2] dt-bindings: arm: " Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3c944abb82efd127533196c5f8eebfb@denx.de \
    --to=festevam@denx.de \
    --cc=francesco.dolcini@toradex.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marex@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).