Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Marc Zyngier <maz@kernel.org>
Cc: <tglx@kernel.org>, <radu@rendec.net>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] irqchip/gic-v3-its: Size the collection table for all possible CPUs
Date: Wed, 18 Nov 2026 09:50:15 +0800	[thread overview]
Message-ID: <f3ccfbc9-c84b-4eb0-b8d3-e281ebceafe9@huawei.com> (raw)
In-Reply-To: <87fqwz8amh.wl-maz@kernel.org>

Hi Marc,

在 2026/11/18 4:29, Marc Zyngier 写道:
> On Tue, 17 Nov 2026 12:31:16 +0000,
> Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>>
>> The collection table is currently sized at a single ITS page size,
>> and the driver's allocation policy is to allocate a single collection
>> per CPU. On systems with more CPUs that the ITS can fit in a single
>> page, no LPI can be routed to the CPUs that don't have an allocated
>> collection, and the system grinds to a halt.
>>
>> Change the allocation policy to allow two-level tables, similarly to
>> the other tables.
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> v1 -> v2:
>> - Cleanup the similar calls of its_parse_indirect_baser() (Marc).
>> - Simplfy the commit message (Marc).
>> - Drop fix tag and comment (Marc).
>> - Give nr_ids a default for unrecognised BASER types.
> 
> At this stage, and given that this is my commit message and my code
> (plus an additional bug of your own doing), you may as well put:
> 
> Suggested-by: Marc Zyngier <maz@kernel.org>

Very happy to do so.

> 
>> ---
>>  drivers/irqchip/irq-gic-v3-its.c | 17 ++++++++++++-----
>>  1 file changed, 12 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
>> index c952c069f937..41cd359e52a7 100644
>> --- a/drivers/irqchip/irq-gic-v3-its.c
>> +++ b/drivers/irqchip/irq-gic-v3-its.c
>> @@ -2682,7 +2682,7 @@ static int its_alloc_tables(struct its_node *its)
>>  		u64 val = its_read_baser(its, baser);
>>  		u64 type = GITS_BASER_TYPE(val);
>>  		bool indirect = false;
>> -		u32 order;
>> +		u32 order, nr_ids;
>>  
>>  		if (type == GITS_BASER_TYPE_NONE)
>>  			continue;
>> @@ -2696,8 +2696,7 @@ static int its_alloc_tables(struct its_node *its)
>>  
>>  		switch (type) {
>>  		case GITS_BASER_TYPE_DEVICE:
>> -			indirect = its_parse_indirect_baser(its, baser, &order,
>> -							    device_ids(its));
>> +			nr_ids = device_ids(its);
>>  			break;
>>  
>>  		case GITS_BASER_TYPE_VCPU:
>> @@ -2713,11 +2712,19 @@ static int its_alloc_tables(struct its_node *its)
>>  				}
>>  			}
>>  
>> -			indirect = its_parse_indirect_baser(its, baser, &order,
>> -							    ITS_MAX_VPEID_BITS);
>> +			nr_ids = ITS_MAX_VPEID_BITS;
>> +			break;
>> +
>> +		case GITS_BASER_TYPE_COLLECTION:
>> +			nr_ids = order_base_2(num_possible_cpus());
>> +			break;
>> +
>> +		default:
>> +			nr_ids = 0;
> 
> Absolutely not. The above four BASER types are the only ones that are
> allowed by the architecture. Anything else is a HW bug. So no, we're

Yes, according to the GIC architecture specification, a value of 0
indicates Unimplemented, and other values are reserved.

> not silently accepting this. We scream and *abort*.

Thank you for the suggestion, will add an appropriate pr_err info and
then return the error directly.

Best regards,
Jinjie

> 
> 	M.
> 



      reply	other threads:[~2026-11-18  1:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:31 [PATCH v2] irqchip/gic-v3-its: Size the collection table for all possible CPUs Jinjie Ruan
2026-11-17 20:29 ` Marc Zyngier
2026-11-18  1:50   ` Jinjie Ruan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3ccfbc9-c84b-4eb0-b8d3-e281ebceafe9@huawei.com \
    --to=ruanjinjie@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=radu@rendec.net \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox