From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31306E71080 for ; Sat, 7 Sep 2024 12:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aqvM697JlB9gjKKKjfqbFfLfWOob1dg5J0ndW8MLbXU=; b=v4eHGkZ3MhKxj/laeLx7Ba33+4 BU6v+gNN4elBeyc6SVEdEqpd3+T+bHTkQEGrNxwyoSE/jE4MEjKT++TxBHEkMz/Q7GuxD/AiUWGBH rlvKHcUWVQW26si9VeQ7b1bQ7DjPqRwyQ+LGqMyJ7MX+rBuwOZOPNc6GDu6cU4dE9NeMko1SYbfbi o9U6OvqtJMm8fJ+I1qQ8uxrn8wIZy7GAFUor4O2A41H1jMdltVsfhgAO0VSTKKjM53I3Z+Zzf8/qT BpcBZiZFG/1A+WhUqXyCD9TYX1MZDSfGDOXQY+Gan+nn8zblenHR19z16td/ZM7IEKhXV9l3I7fL5 RB8CQA3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smuCe-0000000EyJN-1OKh; Sat, 07 Sep 2024 12:06:08 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smuBd-0000000Ey9K-0mqb for linux-arm-kernel@lists.infradead.org; Sat, 07 Sep 2024 12:05:06 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-53568ffc525so3867510e87.0 for ; Sat, 07 Sep 2024 05:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1725710703; x=1726315503; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aqvM697JlB9gjKKKjfqbFfLfWOob1dg5J0ndW8MLbXU=; b=NrYruWBFAL+VSqgZHP85tBZdU+u5RYAFt4oI9y2KjqxF8MwhoElx1i7gc9XHSVsxPh qfN94gTfuCA3nc7wGNZ3cPCy3vy5NT13MGUDxdOKPw1+ne23CadMt2HddwdIik21irn6 +Op1cOJjV2REOR6aUYYy/RNRg2O4RR90hqlwWnnDQo78daruGaSzmKs3tSozvQO0uEZA HCHHctdOqTzAD41zC1mfo+ITs9Zz9J3ewHBHPQdwIzk8OzHVMsIt3AEEOkvz4d35QY4d Fy04hHuoHcJ+22N76mtYEc/gANJiOUyjdxCRArl7YaGnyaiI9qKgv7TdRjw+mORueIbr Kb1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725710703; x=1726315503; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqvM697JlB9gjKKKjfqbFfLfWOob1dg5J0ndW8MLbXU=; b=WH0w0lyZMadCTyI2rIhjiQtOnt13QorCLW5dz3sP17A2xdqBXg3nJ4EXiAyiQwNQqc vylV/fjABBTvrt7wompLjAkLKKqgCDKWuxxhJYRlE8S/uy6dznqWcJjwu3kA/lQzYf1H /gK3Dz4fUCFW9JenANBzAgzmLumHlzQNlNIjwBqmHDYqXEhSji/CN3TE1XBkZ0Fhn9Fr 3OVU184sEwFsldkVmNUBSyw7h9UEZDOVvWTgYWJvsF+TzPZqXC1fPo9IgnnfpyYNo3wt OzyAciKz8YxTEFFghqAeBWpoipWK94VsJlwdM0AKx24i4Bwez1B/NTjFOd33ds+xdhN4 Uv2Q== X-Forwarded-Encrypted: i=1; AJvYcCX5ANgEWeg7L6YyRRfPPkeicSXynQPjokZAxRSTTvAOpB+iHJJzCiotmdXWj66B2WjWFNe+KRCdRvYZoSufKQqM@lists.infradead.org X-Gm-Message-State: AOJu0YxMJW1c17BWMlbskJhybR4OxvctshL4FofZ8SH7T6oI28QdBL5U M/hvxzakmmChQzZWECl4+23M/sttdE8XbqlAteVsyRh+i4qjopLdHXYCWkquvb0= X-Google-Smtp-Source: AGHT+IFtRi6m8sRVLTuS9OP4yIa7IuuuGeCjTXFidBiPaGoEONxF66FpQDAkwH9cJg21xCXNrz2Y5w== X-Received: by 2002:a05:6512:138c:b0:52c:9f9e:d8e3 with SMTP id 2adb3069b0e04-536587c5fbfmr3915871e87.31.1725710702961; Sat, 07 Sep 2024 05:05:02 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.144]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d258317e1sm64649866b.37.2024.09.07.05.05.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Sep 2024 05:05:02 -0700 (PDT) Message-ID: Date: Sat, 7 Sep 2024 15:05:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/12] nvmem: microchip-otpc: Add missing register definitions Content-Language: en-US To: Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list , Nicolas Ferre References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-8-ada@thorsis.com> <5228af83-b423-4f51-820a-edfc40017ca8@tuxon.dev> <20240828-making-gangrene-786ec368b106@thorsis.com> <20240902-countless-applicant-e726bda10200@thorsis.com> From: claudiu beznea In-Reply-To: <20240902-countless-applicant-e726bda10200@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240907_050505_269233_93745565 X-CRM114-Status: GOOD ( 16.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02.09.2024 11:08, Alexander Dahl wrote: > Hello Claudiu, > > Am Sat, Aug 31, 2024 at 06:33:50PM +0300 schrieb claudiu beznea: >> >> >> On 28.08.2024 11:14, Alexander Dahl wrote: >>> Hello Claudiu, >>> >>> Am Sat, Aug 24, 2024 at 06:54:02PM +0300 schrieb claudiu beznea: >>>> >>>> >>>> On 21.08.2024 13:59, Alexander Dahl wrote: >>>>> According to datasheets DS60001765B for SAMA7G5 and DS60001579G for >>>>> SAM9X60. >>>>> >>>>> Signed-off-by: Alexander Dahl >>>>> --- >>>>> drivers/nvmem/microchip-otpc.c | 15 +++++++++++++++ >>>>> 1 file changed, 15 insertions(+) >>>>> >>>>> diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c >>>>> index b8ed7412dbca..4630e96243ac 100644 >>>>> --- a/drivers/nvmem/microchip-otpc.c >>>>> +++ b/drivers/nvmem/microchip-otpc.c >>>>> @@ -21,9 +21,24 @@ >>>>> #define MCHP_OTPC_AR (0x8) >>>>> #define MCHP_OTPC_SR (0xc) >>>>> #define MCHP_OTPC_SR_READ BIT(6) >>>>> +#define MCHP_OTPC_IER (0x10) >>>>> +#define MCHP_OTPC_IDR (0x14) >>>>> +#define MCHP_OTPC_IMR (0x18) >>>>> +#define MCHP_OTPC_ISR (0x1C) >>>>> +#define MCHP_OTPC_ISR_COERR BIT(13) >>>>> #define MCHP_OTPC_HR (0x20) >>>>> #define MCHP_OTPC_HR_SIZE GENMASK(15, 8) >>>>> #define MCHP_OTPC_DR (0x24) >>>>> +#define MCHP_OTPC_BAR (0x30) >>>>> +#define MCHP_OTPC_CAR (0x34) >>>>> +#define MCHP_OTPC_UHC0R (0x50) >>>>> +#define MCHP_OTPC_UHC1R (0x54) >>>>> +#define MCHP_OTPC_UID0R (0x60) >>>>> +#define MCHP_OTPC_UID1R (0x64) >>>>> +#define MCHP_OTPC_UID2R (0x68) >>>>> +#define MCHP_OTPC_UID3R (0x6C) >>>>> +#define MCHP_OTPC_WPMR (0xE4) >>>>> +#define MCHP_OTPC_WPSR (0xE8) >>>> >>>> Are all these used in driver? >>> >>> Not all, but some. What are you implying? Only add register >>> definitions actually used in the driver? >> >> Yes! > > Okay. > > So if I drop the patch with the warnings on driver probe you did not > like (checking for pre probe error conditions in interrupt register > for example), then it is just the MCHP_OTPC_UID0R and I would squash > that one definition in the last patch adding the nvmem for the UID > then, okay? OK for me. The idea would be to keep just what is used. Thank you, Claudiu Beznea > > Greets > Alex > >> >>> Why? >> >> Less code to maintain. If it's not used there is no meaning to have it. >> >> >>> >>> Those register offsets won't change, but helped us when debugging. >>> Debug code (e.g. register dump) is not part of the patch series. >>> >>> Greets >>> Alex >>> >>>> >>>>> >>>>> #define MCHP_OTPC_NAME "mchp-otpc" >>>>> #define MCHP_OTPC_SIZE (11 * 1024) >>