* Re: [PATCH] soc/fsl/qbman: Use for_each_online_cpu() instead of for_each_cpu()
[not found] <20250811065216.3320-1-wangfushuai@baidu.com>
@ 2025-08-11 16:46 ` Shrikanth Hegde
0 siblings, 0 replies; only message in thread
From: Shrikanth Hegde @ 2025-08-11 16:46 UTC (permalink / raw)
To: Fushuai Wang
Cc: frederic, christophe.leroy, linux-kernel, linux-arm-kernel,
linuxppc-dev
On 8/11/25 12:22, Fushuai Wang wrote:
> Replace the opencoded for_each_cpu(cpu, cpu_online_mask) loop with the
> more readable and equivalent for_each_online_cpu(cpu) macro.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
> ---
> drivers/soc/fsl/qbman/qman_test_stash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qbman/qman_test_stash.c b/drivers/soc/fsl/qbman/qman_test_stash.c
> index f4d3c2146f4f..6f7597950aa3 100644
> --- a/drivers/soc/fsl/qbman/qman_test_stash.c
> +++ b/drivers/soc/fsl/qbman/qman_test_stash.c
> @@ -103,7 +103,7 @@ static int on_all_cpus(int (*fn)(void))
> {
> int cpu;
>
> - for_each_cpu(cpu, cpu_online_mask) {
> + for_each_online_cpu(cpu) {
> struct bstrap bstrap = {
> .fn = fn,
> .started = ATOMIC_INIT(0)
Yes. This change makes sense given that for_each_online_cpu expands into the same.
Why not do for the remaining ones too?
linux_tip$ grep -Rw "for_each_cpu" * | grep cpu_online_mask
arch/riscv/kernel/unaligned_access_speed.c: for_each_cpu(cpu, cpu_online_mask) {
arch/riscv/kernel/unaligned_access_speed.c: for_each_cpu(cpu, cpu_online_mask) {
drivers/soc/fsl/qbman/qman_test_stash.c: for_each_cpu(cpu, cpu_online_mask) { ** current patch addresses this.
drivers/infiniband/hw/hfi1/sdma.c: for_each_cpu(cpu, cpu_online_mask) {
drivers/cpuidle/cpuidle-tegra.c: for_each_cpu(lcpu, cpu_online_mask) {
include/rv/da_monitor.h: for_each_cpu(cpu, cpu_online_mask) {
kernel/trace/trace_osnoise.c: for_each_cpu(cpu, cpu_online_mask) {
kernel/trace/trace_osnoise.c: for_each_cpu(cpu, cpu_online_mask) {
Rest everyone seems to have moved.
linux_tip$ grep -Rw "for_each_online_cpu" * | wc
416 1141 23047
^ permalink raw reply [flat|nested] only message in thread