From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E230CC04A94 for ; Fri, 11 Aug 2023 18:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EKKR1vMEsRN0OQ0ZnZ+ltGZk8P07GeyditlYms97pfw=; b=t0rT+NikjViURt qoC48IVgI19BtSG7WjIe8VnLHvXevFDQ89xwcgpVafJgn27IptdhTi7bNv4/NJsjuovej0SKaBAJi VoKcP2VepfUTNW3DnotJwmiD8FFK+JNClBk0XoCt4u6HZht1IlnV77Y4qUrzCyGWgCJRwTgiOQJAq /sWx7/I4STsHOq7l9nmSeIIRBrMdebxpIZXIvyDhMyBNAOhW65UrOsutgcZmkK+OyGWYckTQXjTIU QlfGz7tpP3VI48T+pZK44c0iPOIf7eQvFlIGRJTdgvAE6VZ0W7zbsptKCkBGxgGFDe5tbLYV+tTQB CkpU9Zv5XopLu338HY2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUWW6-00BJ7G-11; Fri, 11 Aug 2023 18:05:42 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUWVy-00BJ5T-2R for linux-arm-kernel@lists.infradead.org; Fri, 11 Aug 2023 18:05:37 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37BI5UZ4055481; Fri, 11 Aug 2023 13:05:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691777130; bh=0ip2uvqMwMwA+IpTP06n3f3fb7xVBAnrvfzUfhX/ezA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=OwHo5a/B1JrS6ez8MtMOHabWjZVix0lajc0BjxIlCmtEKzxq7G2Gi5F8U45Mtm7CL HGAw9mjHQNHaQP3rzeNOBZC2e91B2P7omYOwwXhcJKLOkct4iBCuV6ZzheK90yV+GB opRV9EmUMIAn9I+VgqOjKBR5GBcS6ypS/riccoKg= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37BI5UAx018256 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Aug 2023 13:05:30 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 11 Aug 2023 13:05:30 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 11 Aug 2023 13:05:30 -0500 Received: from [10.249.141.75] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37BI5QSE008841; Fri, 11 Aug 2023 13:05:27 -0500 Message-ID: Date: Fri, 11 Aug 2023 23:35:26 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 3/3] arm64: dts: ti: k3-am69-sk: Add phase tags marking Content-Language: en-US To: Nishanth Menon , Apurva Nandan CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Hari Nagalla , Dasnavis Sabiya References: <20230811151644.3216621-1-a-nandan@ti.com> <20230811151644.3216621-4-a-nandan@ti.com> <638d5883-5b95-403e-ecb9-8122d8774675@ti.com> <20230811175459.nxi65bu4bbjki5xe@duller> From: "Kumar, Udit" In-Reply-To: <20230811175459.nxi65bu4bbjki5xe@duller> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_110534_886894_CE3F6B2D X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/11/2023 11:24 PM, Nishanth Menon wrote: > On 23:05-20230811, Kumar, Udit wrote: >> Hi Apurva >> >> On 8/11/2023 8:46 PM, Apurva Nandan wrote: >>> bootph-all as phase tag was added to dt-schema >>> (dtschema/schemas/bootph.yaml) to cover U-Boot challenges with DT. >>> That's why add it also to Linux to be aligned with bootloader requirement. >>> >>> wkup_uart0, wkup_i2c0, mcu_uart0, main_uart8, main_sdhci0 and main_sdhci1 >>> are required for bootloader operation on TI K3 AM69-SK EVM. These IPs >>> along with pinmuxes need to be marked for all bootloader phases, hence add >>> bootph-all to these nodes in kernel dts. >>> >>> Signed-off-by: Apurva Nandan >>> --- >>> [...] >>> &wkup_uart0 { >>> + bootph-all; >>> /* Firmware usage */ >>> status = "reserved"; >>> pinctrl-names = "default"; >> I am not sure, if you want to treat wkup_uart in same way as you are >> treating secure_proxy_mcu in patch 1 of this series. > You should'nt. wkup_uart0 or what ever peripherals are specifically > board dependent. This patch does it the right way. I do have other > platforms on other K3 SoCs where the TIFS uart logs are actually > disabled. Sorry, if i was not clear in my previous response. This node is marked as reserved, adding bootph is not adding any value. We can drop bootph from this node here. >> IMO, where we are making this node status is okay, mark booth-all at that >> place only. >> >> Otherwise for rest of series >> >> LGTM > Do i take that as a Reviewed-by: for the series? With above change, Reviewed-by: Udit Kumar >> > [...] > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel