From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1240DC433F5 for ; Tue, 28 Sep 2021 16:28:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE3B361206 for ; Tue, 28 Sep 2021 16:28:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE3B361206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dA3C6P4z/y9LZxIOOSKsCRvkzJOhlVRgb22SbCYzv+4=; b=EiJ7m9EffRvaxY l6te/H5/BMpHAiYgp6pOxJurxsB1UHpEcm0lKMgF2kRmxjeZ5j2ilHmKChqwuoIAEDzedXDt035KM ZIasx3aDRgnKlmeMK6HLY7CgFKR+2PC/j652P3+bqkk8R8APlKZ+1P+kJUfKRo70jMttUlb9xeTQK LvSkOn434rg607yVcFSzoV8tokX2olmG7JchoFD+UxLJ7m4EiKCEuwf+MML2fzRdugMATUAq0JJ9+ fLiWhhrYaIR58BzoOjkBMs+AwraTx/SmPkdhS6KAnW2ZI3BG59JrAPrJqBersTIcNrvi5RMVxbeNf bWLrzI7jRpjrymMlifvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVFvw-0083f3-AA; Tue, 28 Sep 2021 16:26:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVFvs-0083dx-G2; Tue, 28 Sep 2021 16:26:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3737960462; Tue, 28 Sep 2021 16:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632846375; bh=oFzMNd56P/Bc6DPh2ju3WdH1InmiJeQKxMtO1+IROrI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=eUO4pKcvbbdSTakQ8QNE+mtbLlsywDXXnVYi8Yaj6zIDjOtTwKee/gTMXHm4nDaW6 IDPZKT24kQfJidzd8aLAFyDqFaCRoEUMfHRdNMbCqz0XKeXPWMoOAiompisRLzUozW dz0o/1CKzRXpiW/jpTZkUVdYd/xEmq8T2R7QDa7rvw9RjGH4OEBhq2gghY5Uh1e1q9 ot/Nrl22pyxGn+mzqQNHReadorxYl148/+ph+UrZUQSGFyuNz+MLM51hpCpAE7y7Qz wdPKwMiwXFionZv1uRg+GOlImIhJOU5W8LcFUOe+Q6o0OO8ZBfmAs3jJu3tRx7S5jq gDB5t8AbnVOww== Message-ID: Subject: Re: [PATCH 1/5] clk: bcm-2835: Pick the closest clock rate From: nicolas saenz julienne To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds Date: Tue, 28 Sep 2021 18:26:10 +0200 In-Reply-To: <20210922125419.4125779-2-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-2-maxime@cerno.tech> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_092616_587747_F416208B X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > The driver currently tries to pick the closest rate that is lower than > the rate being requested. > > This causes an issue with clk_set_min_rate() since it actively checks > for the rounded rate to be above the minimum that was just set. > > Let's change the logic a bit to pick the closest rate to the requested > rate, no matter if it's actually higher or lower. > > Fixes: 6d18b8adbe67 ("clk: bcm2835: Support for clock parent selection") > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne # boot and basic functionality Regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel