From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AEACC47DDC for ; Tue, 23 Jan 2024 21:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Em6Fx2fNcrg8S6wNFLCEY0VQGDQpyXnDExy2w/EoDow=; b=Hdqx+IrOI4YzvC 4pnazDNJdrLiUqYlRMzDTmrC5+7iKhPRxcY6sVE1VsPELmGPttY+x0qLajIvYCIl9l/NnOq+15Lfz Smk1p4k1iQloQjACcsIJ6ibBbO8uhkjqPnMzbqndOUGqZwqMPdWuwkO1OrpuIpC2p0UsJfh+oBBiZ gTUMMZ1GyOBlaZxU4/qX3Bvgs5+aUpcakls7NrhnJbVbc2p1YXPKsvRJHG+Amr/ic/BGs4rkBZrQu 3ldwUrHrQJWHW867sUeYBKZA04Fj5VIJbWWo9u+IFB5I0nwHif5oZx57j1YCeZ7l0ShM/n4Enyx7A 5wNlI92bcdVUeqrZ0OTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSOIq-000Wuj-1b; Tue, 23 Jan 2024 21:27:28 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSOIn-000Wq8-2u for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 21:27:27 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40d6b4e2945so57231925e9.0 for ; Tue, 23 Jan 2024 13:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706045236; x=1706650036; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SsPFNicsRzcVeR0kjRsnPEk/NMOqj3G3Xl498xm7tPs=; b=d5w5EXYZsCv13ItoVFMiw2MGRm+BCCuIRR4cvGeGXlb3RCb90VCc4YujUcMzAvtgXO UtycTHZ0rjvzns0HjXya8/334Evd7+0ebEo32NeDCe0qrMk8WH3T/4JSKqR5j+GiDgjA 8ORaHL6Uoi1f4ota3lGydOL2pOgy+F24lR0TTzDObvKPO84yX5ikdLsCMGYULRrMk3mf IPuSuq3rZ6JYmSSZlmVI3575jaSh2LeLcpsqdsxa2oqn4gzOPrY5sKFnI9Shi7tEEMXc 00ULslCgfF17S0CjmnLf+Ni+ZztFld3DPow5wbdXqMHnKyAmeXqtjYLzOQyLhiraei/d dXHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706045236; x=1706650036; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SsPFNicsRzcVeR0kjRsnPEk/NMOqj3G3Xl498xm7tPs=; b=SJHOXTbB63app+18pzsZTBsn/buecBAQxxengYyyluVzdYfXbPY7brZ8nAs5B4FIfy 1gEvinvfABQBurQijlTYSxjg21iqESr43Wl4/YkdxWogbsMu4qlvZGC4gixpJlNHl0rG UqeDLjbXyAyCbnWZ7xgHjUA4f3JmB8+5R506X0hG0aG3BV8hCExfF2Xxo1vWUJ/1G4oQ 3N2Mhexb4spyY2mLyIui3nbJ/TKg3o0F7zDvgqCeOjN69iwd+pvQqpgAeVZr9wmv3G5g M9hVLn0Njp8/MLD4YmxTo/UBe2xbNwc63tdfEmohpaq4YGQqvgw6gB0VpAyrPkIstQSy X3sQ== X-Gm-Message-State: AOJu0Yx+he2H5nd817lwFiofNgfg4ZiaJD9iKtPYdBhmhzyvaXzlO0W6 Lom6ZSns1xPWsJlHX65Wt2+F4nenOjWBPdRz4cIwqeMNf429LuVwk9wRgw4b9F4= X-Google-Smtp-Source: AGHT+IFRvctKnY6OuHBRe0qLqdSp5NbxUd+MHzMy9wOKSxDBDO8OSOZJ02+w81ngdYKrMB78EBOAZw== X-Received: by 2002:a05:600c:6544:b0:40e:bedf:c10 with SMTP id dn4-20020a05600c654400b0040ebedf0c10mr348118wmb.262.1706045236422; Tue, 23 Jan 2024 13:27:16 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id t5-20020a05600c450500b0040d6d755c90sm43768183wmo.42.2024.01.23.13.27.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jan 2024 13:27:16 -0800 (PST) Message-ID: Date: Tue, 23 Jan 2024 22:27:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] dt-bindings: memory: additional compatible strings for Broadcom DPFE Content-Language: en-US To: Markus Mayer , Florian Fainelli , Rob Herring , Conor Dooley Cc: Linux ARM Kernel List , Device Tree Mailing List References: <20240119215231.758844-1-mmayer@broadcom.com> <20240119215231.758844-4-mmayer@broadcom.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240119215231.758844-4-mmayer@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_132725_944611_E3CCDEDC X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/01/2024 22:52, Markus Mayer wrote: > Add versioned compatible strings for Broadcom DPFE. These take the form > brcm,dpfe-cpu-v where is a number from 1 to 4. > > The chip-specific strings have been kept for compatibility purposes > (hardware is in the field). For new chips, the properly versioned > compatible string should be used. > > Signed-off-by: Markus Mayer > --- > .../memory-controllers/brcm,dpfe-cpu.yaml | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml > index 3f00bc2fd3ec..42c8160d95d1 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml > @@ -10,9 +10,28 @@ maintainers: > - Krzysztof Kozlowski > - Markus Mayer > > +description: | > + Drop blank line. > + The DCPU (DDR PHY Front End CPU) interfaces directly with the DDR PHY > + chip on Broadcom STB SoCs. An API exists for other agents to retrieve > + or set certain DDR PHY chip parameters by JEDEC. > + > + Different, incompatible versions of this API have been created over > + time. The API has changed for the some chips as development progressed > + and features were added or changed. > + > + We rely on the boot firmware (which already knows the API version > + required) to populate Device Tree with the corresponding compatible > + string. > + > properties: > compatible: > items: > + - enum: > + - brcm,dpfe-cpu-v1 > + - brcm,dpfe-cpu-v2 > + - brcm,dpfe-cpu-v3 > + - brcm,dpfe-cpu-v4 I don't see my comment resolved - except more unusual order of compatibles - and nothing in commit msg explains my previous concerns. I think my final comment was pretty clear yet ignored completely. There was no follow up: https://lore.kernel.org/all/3fff866f-fbe8-4d23-87f3-275380adf3d4@linaro.org/ so with ignored comments: NAK Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel