From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14DF8C10F13 for ; Tue, 16 Apr 2019 13:31:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7978205ED for ; Tue, 16 Apr 2019 13:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PwY2Ubjd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="phFwp9ix" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7978205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YYp18JRiJV59d/J4tYQcjDkaqp5/skoV/QwjreOkNRI=; b=PwY2UbjdDZeuMa6HbhEEDt+Tw dezuzYbWThaPaTiFtr1AqG4uOO7IjipDZWnun4GmLWakEyQ0HBQNx12JdjX8+rH1wjJumx1ND0ZFi LQXTGkMbFYhvWb4vtpn4Re/KOA5xImAFWKMlNB4vXr6JHMntGPVPM/PAvID1lp2vYNZOjHuUHO4B5 zhPwT4kMUoQbDu6MKVS3MkX64tmbQ1Okx/44ag+vFK2Xbx3rSzemRexX/hBVFjX6KBJ6o1a85Hx6I 88aPAPC9k4C+uXtcW0qes/WArYJJLPZDAZXcwcMo0qZg6LFcmPlAVRJ0yANxMP6yBPjsACjNb46TW e2quPvy6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGOAv-0007it-W4; Tue, 16 Apr 2019 13:31:01 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGOAt-0007iX-1x for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 13:31:00 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 16 Apr 2019 06:30:55 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 16 Apr 2019 06:30:58 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 16 Apr 2019 06:30:58 -0700 Received: from [10.24.45.163] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 16 Apr 2019 13:30:53 +0000 Subject: Re: [PATCH V2 02/16] PCI/PME: Export pcie_pme_disable_msi() API To: Thierry Reding References: <1554407683-31580-1-git-send-email-vidyas@nvidia.com> <1554407683-31580-3-git-send-email-vidyas@nvidia.com> <20190411101657.GF4633@ulmo> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: Date: Tue, 16 Apr 2019 19:00:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190411101657.GF4633@ulmo> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1555421455; bh=Buo3FKJ+OrKPu0SzaKomyODYyh2t364y6qnHcREIcTM=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=phFwp9ixooO6oat7hX8787Pmy7LSg3uM6tqnEr/wWRwtJPIgj4aBs2P2pNG8WM3Sd VkQ//rz1V5VxYK5/EFYU4PDFwf/63Y0NLsso3IqQol5fudRP/3uxGDkkWGM6KQKRDb Cyzjj4TADJN7v5TUzNxE6ozeNpZ2olO9tMq6KI1IiEw0yEBgumTTjQYNdZmKlyZIHh GXODKoobsEYu31iMv+PyUNPvwb91nwBIaG265OxucVfUDQpQ2YAz1YoyC9enJhRoHA ehHWES8jYk0AuW6zh0hDSOBwoHfkgMaCeMOMPI0Ntd7+vsndHL+pa9lFx4PkyqivJX VJr0yt2L56eeQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_063059_110659_8E495EAD X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, mperttunen@nvidia.com, mmaddireddy@nvidia.com, linux-pci@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, kthota@nvidia.com, kishon@ti.com, linux-tegra@vger.kernel.org, robh+dt@kernel.org, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/11/2019 3:46 PM, Thierry Reding wrote: > On Fri, Apr 05, 2019 at 01:24:29AM +0530, Vidya Sagar wrote: >> Export pcie_pme_disable_msi() API to enable drivers using this API be able to >> build as loadable modules >> >> Signed-off-by: Vidya Sagar >> --- >> Changes from [v1]: >> * This is a new patch in v2 series >> >> drivers/pci/pcie/pme.c | 6 ++++++ >> drivers/pci/pcie/portdrv.h | 5 +---- >> 2 files changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c >> index 54d593d10396..18e815c1e3c9 100644 >> --- a/drivers/pci/pcie/pme.c >> +++ b/drivers/pci/pcie/pme.c >> @@ -27,6 +27,12 @@ >> */ >> bool pcie_pme_msi_disabled; >> >> +void pcie_pme_disable_msi(void) >> +{ >> + pcie_pme_msi_disabled = true; >> +} >> +EXPORT_SYMBOL_GPL(pcie_pme_disable_msi); >> + >> static int __init pcie_pme_setup(char *str) >> { >> if (!strncmp(str, "nomsi", 5)) >> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h >> index 1d50dc58ac40..2be7b7e9a784 100644 >> --- a/drivers/pci/pcie/portdrv.h >> +++ b/drivers/pci/pcie/portdrv.h >> @@ -127,10 +127,7 @@ struct pci_dev; >> #ifdef CONFIG_PCIE_PME >> extern bool pcie_pme_msi_disabled; >> >> -static inline void pcie_pme_disable_msi(void) >> -{ >> - pcie_pme_msi_disabled = true; >> -} >> +void pcie_pme_disable_msi(void); >> >> static inline bool pcie_pme_no_msi(void) >> { > > Perhaps also export pcie_pme_no_msi()? That way you could get rid of the > extern declaration of the pcie_pme_msi_disabled variable and make it > static to drivers/pci/pcie/pme.c? Agree. I'll take care of this in V3 patch series. > > Thierry > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel