From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C5DDC433DF for ; Thu, 18 Jun 2020 12:41:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0DB320663 for ; Thu, 18 Jun 2020 12:41:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m86aJvH5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hnf18fDQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0DB320663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=albwwutTULaMQLKmiFf9g6QTsFmRfloYvx8Y/1s+9iA=; b=m86aJvH55ntAmIloKFEx50DQU TkFHm2gd1UK4W+nxgwfT/61dBj1mdrsxB1cL9A8OnbmFzYQYAgptfM6+/pX9oeBFqgfggB87TbHtF 4P/+BQ5oJZuKy3+XawCsGG/OjVlEWSNk0Y//uu/QFAHiFsujCop3EnlKTHd3zv5zyRPW3BsNsElbm 3kRYA3uRjT4M/4s8p8xsnWurnWuefysLxMGTF36tZKo51sIN23IhovAxGQYNlDQJPQwdsWe4sbd3v 5/IGZUNcsyAebAcCdDNSWRi/UZmIC4KX4tInz/LoNC/WknvNyhRYcBxW65/d4ZXM9bkhr5Zm6ELGX QIDu4R59Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jltrU-0002FU-LS; Thu, 18 Jun 2020 12:41:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jltrS-0002Eq-0o; Thu, 18 Jun 2020 12:41:43 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1FED20663; Thu, 18 Jun 2020 12:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592484101; bh=eJbZQP0xNHsWf9mN+hL/U5ulTsXIkdm9Muq9GcZ9Tow=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hnf18fDQZpQw+uU2EuqznUf8S5+8LXIsEcdu3cMYyCVnbqseEbstRF3Foj9NJaFqV cd2rRx9G71nz2N2DksMNqHGzFP1fOl1v34wM+tRYYWHlhDmMbABFk6UDyuhG6sJS7w 5JX7vkqYlau1RjMT1d029sotH6bt9MegLrmE0JaA= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jltrP-004A7y-Cd; Thu, 18 Jun 2020 13:41:39 +0100 MIME-Version: 1.0 Date: Thu, 18 Jun 2020 13:41:39 +0100 From: Marc Zyngier To: Hanks Chen Subject: Re: [PATCH 1/1] irqchip: Add config MTK_SYSIRQ and MTK_CIRQ In-Reply-To: <1592483471-14806-1-git-send-email-hanks.chen@mediatek.com> References: <1592483471-14806-1-git-send-email-hanks.chen@mediatek.com> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: hanks.chen@mediatek.com, tglx@linutronix.de, jason@lakedaemon.net, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com, cc.hwang@mediatek.com, loda.chou@mediatek.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_054142_105873_04A5B04D X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CC Hwang , Jason Cooper , wsd_upstream@mediatek.com, Loda Chou , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-18 13:31, Hanks Chen wrote: > Mediatek sysirq and cirq drivers as-is were bound together to the > config > of ARCH_MEDIATEK. These two drivers should be able to be configured > separately. For example, on new Mediatek mobile chips such as > Dimensity > 820, the sysirq driver is not used since the hardware module is > removed. > > Add two new configs to sysirq and cirq drivers. > - config MTK_SYSIRQ for the interrupt polarity controller driver: > sysirq > - config MTK_CIRQ for the low-power interrupt driver: cirq > > Signed-off-by: cc.hwang > Signed-off-by: Hanks Chen > --- > drivers/irqchip/Kconfig | 12 ++++++++++++ > drivers/irqchip/Makefile | 3 ++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 29fead2..cc9aa18 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -572,4 +572,16 @@ config LOONGSON_PCH_MSI > help > Support for the Loongson PCH MSI Controller. > > +config MTK_SYSIRQ > + tristate "Mediatek interrupt polarity controller" How do you expect this to work as a module? > + help > + Interrupt polarity controller driver to swap polarity for > + interrupts for Mediatek mobile chips. > + > +config MTK_CIRQ > + bool "Mediatek low-power interrupt controller" > + help > + Low-power interrupt controller driver to monitor IRQS > + in the sleep mode for Mediatek mobile chips. > + > endmenu > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index 133f9c4..30421d2 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -69,7 +69,8 @@ obj-$(CONFIG_BCM7120_L2_IRQ) += irq-bcm7120-l2.o > obj-$(CONFIG_BRCMSTB_L2_IRQ) += irq-brcmstb-l2.o > obj-$(CONFIG_KEYSTONE_IRQ) += irq-keystone.o > obj-$(CONFIG_MIPS_GIC) += irq-mips-gic.o > -obj-$(CONFIG_ARCH_MEDIATEK) += irq-mtk-sysirq.o irq-mtk-cirq.o > +obj-$(CONFIG_MTK_SYSIRQ) += irq-mtk-sysirq.o > +obj-$(CONFIG_MTK_CIRQ) += irq-mtk-cirq.o > obj-$(CONFIG_ARCH_DIGICOLOR) += irq-digicolor.o > obj-$(CONFIG_RENESAS_H8300H_INTC) += irq-renesas-h8300h.o > obj-$(CONFIG_RENESAS_H8S_INTC) += irq-renesas-h8s.o In general, this approach doesn't look right. As it stands, this is just breaking existing configurations Do you really expect users to know exactly which interrupt controllers their system is going to use? This seems like the wrong assumption. If you really want to save the handful of bytes these drivers take in your image, then add the relevant dependency information in Kconfig. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel