From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64B88EB64D8 for ; Wed, 14 Jun 2023 15:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ufG6bLmdBXpLvqst/HzS0KaTK+35/pv1rSQMbyHJIY=; b=C71QxzbRYX+zJ6 H/Slr4TsPtjWRYcwxfdUyNKQ5Y16aSxNkhO6Lx9dPOVRvr/4VoitFDSsjZjQQfNKwuEw6x391sjjg zLWO/MK/uOoYV1tZuwsR2E8EOJckXsRKnWTlfHOFHJ+T5Q1UcA6s2MIAAQURkgQZndqe2cCTQUpcW cJJ3duBy42Vouk+MS6Cgw0EBgx1rDVulAMJQFpMhOlbaeWyL6RTJK36UtxS7JB1Sb+74XMmysmKy2 /Edpsr2s9tGrtukCpDu6k6apA1ygkfX06MbByeCYBkkOa13suGvJ0/wpOcmyod7n1hADA1XrlEBxD 5er4fgw3h1tABsGhFRVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9SR6-00C4sg-2d; Wed, 14 Jun 2023 15:29:28 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9SR3-00C4rv-2m; Wed, 14 Jun 2023 15:29:27 +0000 Received: from nicolas-tpx395.localdomain (unknown [IPv6:2606:6d00:15:c623::7a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id ECEB36606F4F; Wed, 14 Jun 2023 16:29:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686756563; bh=EwpPaawJ0jLzVbGU6lbdNpBxv2dOVOqXbVeRLYmJrpM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SS6KFpNSUEQ21ypiewsTyRCcfKPYRTd9j+btkiu7fW2ZEtoPv3+Sw4tE3U1N4roxu qknkA2tBaWdP/oRSaW4//b5aNlUCIF33YpyaYA2RarM3YrjN+vDjyc5WRP9sRop13M vPo/8FIsNQbviU5npo5wU5WNZAN2kAmc6XsOKOmjY9IS0KzXwXjTm3ZdO2v61UpbCK 30J0OAnLOfZsNh8ha5BfnWBRMgnGtGHEvDAZPCx/k1mtDEuqfetVFw5H81X47zEY4Q wTQ4BaPR11ZCqq5FdYXJMmHB9kLIbUF8B+aQoZvBm90HQYEUAWO+4CrbnmnUSyM/sT erLZ8gjFCDSgw== Message-ID: Subject: Re: [PATCH 2/4] media: mediatek: vcodec: fix resource leaks in vdec_msg_queue_init() From: Nicolas Dufresne To: Dan Carpenter , Yunfei Dong Cc: Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Xiaoyong Lu , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Date: Wed, 14 Jun 2023 11:29:13 -0400 In-Reply-To: References: User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_082926_047035_85C3BE70 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpMZSBtZXJjcmVkaSAxNCBqdWluIDIwMjMgw6AgMTY6MDYgKzAzMDAsIERhbiBDYXJwZW50 ZXIgYSDDqWNyaXTCoDoKPiBJZiB3ZSBlbmNvdW50ZXIgYW55IGVycm9yIGluIHRoZSB2ZGVjX21z Z19xdWV1ZV9pbml0KCkgdGhlbiB3ZSBuZWVkCj4gdG8gc2V0ICJtc2dfcXVldWUtPndkbWFfYWRk ci5zaXplID0gMDsiLiAgTm9ybWFsbHksIHRoaXMgaXMgZG9uZQo+IGluc2lkZSB0aGUgdmRlY19t c2dfcXVldWVfZGVpbml0KCkgZnVuY3Rpb24uICBIb3dldmVyLCBpZiB0aGUKPiBmaXJzdCBjYWxs IHRvIGFsbG9jYXRlICZtc2dfcXVldWUtPndkbWFfYWRkciBmYWlscywgdGhlbiB0aGUKPiB2ZGVj X21zZ19xdWV1ZV9kZWluaXQoKSBmdW5jdGlvbiBpcyBhIG5vLW9wLiAgRm9yIHRoYXQgc2l0dWF0 aW9uLCBqdXN0Cj4gc2V0IHRoZSBzaXplIHRvIHplcm8gZXhwbGljaXRseSBhbmQgcmV0dXJuLgo+ IAo+IFRoZXJlIHdlcmUgdHdvIG90aGVyIGVycm9yIHBhdGhzIHdoaWNoIGRpZCBub3QgY2xlYW4g dXAgYmVmb3JlIHJldHVybmluZy4KPiBDaGFuZ2UgdGhvc2UgZXJyb3IgcGF0aHMgdG8gZ290byBt ZW1fYWxsb2NfZXJyLgo+IAo+IEZpeGVzOiBiMTk5ZmU0NmYzNWMgKCJtZWRpYTogbXRrLXZjb2Rl YzogQWRkIG1zZyBxdWV1ZSBmZWF0dXJlIGZvciBsYXQgYW5kIGNvcmUgYXJjaGl0ZWN0dXJlIikK PiBGaXhlczogMmY1ZDBhZWYzN2M2ICgibWVkaWE6IG1lZGlhdGVrOiB2Y29kZWM6IHN1cHBvcnQg c3RhdGVsZXNzIEFWMSBkZWNvZGVyIikKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxk YW4uY2FycGVudGVyQGxpbmFyby5vcmc+CgpUaGlzIGNoYW5nZSBsb29rcyBnb29kIHRvIG1lLCB0 aGFua3MgYWdhaW4gZm9yIHlvdXIgd29yay4KClJldmlld2VkLWJ5OiBOaWNvbGFzIER1ZnJlc25l IDxuaWNvbGFzLmR1ZnJlc25lQGNvbGxhYm9yYS5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL21lZGlh L3BsYXRmb3JtL21lZGlhdGVrL3Zjb2RlYy92ZGVjX21zZ19xdWV1ZS5jIHwgNSArKystLQo+ICAx IGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL21lZGlhdGVrL3Zjb2RlYy92ZGVjX21zZ19x dWV1ZS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tZWRpYXRlay92Y29kZWMvdmRlY19tc2df cXVldWUuYwo+IGluZGV4IDkyYWM4MmViNDQ0ZS4uYmUyNWQ1NjcxMmQ4IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVkaWF0ZWsvdmNvZGVjL3ZkZWNfbXNnX3F1ZXVlLmMK PiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL21lZGlhdGVrL3Zjb2RlYy92ZGVjX21zZ19x dWV1ZS5jCj4gQEAgLTMwNyw2ICszMDcsNyBAQCBpbnQgdmRlY19tc2dfcXVldWVfaW5pdChzdHJ1 Y3QgdmRlY19tc2dfcXVldWUgKm1zZ19xdWV1ZSwKPiAgCWVyciA9IG10a192Y29kZWNfbWVtX2Fs bG9jKGN0eCwgJm1zZ19xdWV1ZS0+d2RtYV9hZGRyKTsKPiAgCWlmIChlcnIpIHsKPiAgCQltdGtf djRsMl9lcnIoImZhaWxlZCB0byBhbGxvY2F0ZSB3ZG1hX2FkZHIgYnVmIik7Cj4gKwkJbXNnX3F1 ZXVlLT53ZG1hX2FkZHIuc2l6ZSA9IDA7Cj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAl9Cj4gIAlt c2dfcXVldWUtPndkbWFfcnB0cl9hZGRyID0gbXNnX3F1ZXVlLT53ZG1hX2FkZHIuZG1hX2FkZHI7 Cj4gQEAgLTMzOCwxNCArMzM5LDE0IEBAIGludCB2ZGVjX21zZ19xdWV1ZV9pbml0KHN0cnVjdCB2 ZGVjX21zZ19xdWV1ZSAqbXNnX3F1ZXVlLAo+ICAJCQllcnIgPSBtdGtfdmNvZGVjX21lbV9hbGxv YyhjdHgsICZsYXRfYnVmLT5yZF9tdl9hZGRyKTsKPiAgCQkJaWYgKGVycikgewo+ICAJCQkJbXRr X3Y0bDJfZXJyKCJmYWlsZWQgdG8gYWxsb2NhdGUgcmRfbXZfYWRkciBidWZbJWRdIiwgaSk7Cj4g LQkJCQlyZXR1cm4gLUVOT01FTTsKPiArCQkJCWdvdG8gbWVtX2FsbG9jX2VycjsKPiAgCQkJfQo+ ICAKPiAgCQkJbGF0X2J1Zi0+dGlsZV9hZGRyLnNpemUgPSBWREVDX0xBVF9USUxFX1NaOwo+ICAJ CQllcnIgPSBtdGtfdmNvZGVjX21lbV9hbGxvYyhjdHgsICZsYXRfYnVmLT50aWxlX2FkZHIpOwo+ ICAJCQlpZiAoZXJyKSB7Cj4gIAkJCQltdGtfdjRsMl9lcnIoImZhaWxlZCB0byBhbGxvY2F0ZSB0 aWxlX2FkZHIgYnVmWyVkXSIsIGkpOwo+IC0JCQkJcmV0dXJuIC1FTk9NRU07Cj4gKwkJCQlnb3Rv IG1lbV9hbGxvY19lcnI7Cj4gIAkJCX0KPiAgCQl9Cj4gIAoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK