From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945E8C2BB85 for ; Thu, 16 Apr 2020 13:44:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65AC92076D for ; Thu, 16 Apr 2020 13:44:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZJTrg/Ft"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NKaFl00p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65AC92076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vUWlQCSFZsBqrSK1Fj5m9AVakUyCMb/yX981oFku3Ro=; b=ZJTrg/FtBwmC14 iB3dHKgUPluDW9qUJHhq4Vy4VslMrsewUwTxfro7qqARBccgSj763dlhNIEeOcmVCaMKKSoxxLtiH 5f0OUQYFeSvExWjtPPMqfXmZKTsmlwSO2Mlu4/ZvLqX2+nfObWYusPlhrX10uY+GpzGphZigkdTXL AGviwonoBhJ4OLRvE/NL75ImON5pvwkkPSFlrpxXxBaE1sjoIUE0QuTUcI/v7aBnchNhBwblzgIWi rcrI74RBfRyeCYssg8L5nnpzAutmw5FdlJ+1g4jM6404doMpiTnVRTDYHpKIqYh6P3vHCx2JIajKx +SCQ2W2Iak5IYsIdXZIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP4om-0002UB-4j; Thu, 16 Apr 2020 13:44:36 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP4oi-0002CY-2F; Thu, 16 Apr 2020 13:44:33 +0000 Received: by mail-wm1-x342.google.com with SMTP id c195so2577804wme.1; Thu, 16 Apr 2020 06:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WnOLlJGWjKKU4l6KU86petvNf/KeuBQfP8LASQRqnt8=; b=NKaFl00peRLsJRd1TCpOYzHetW8sbRA+/HJn6nXHcphRgYoHcE2As4Skpd/c5OOtl3 aAJP6GhSIoz0w4NCFbSZJ6HKcTBmEX7IXKjNWRGHscVFHFO40s7l2Oij2g2owDoID0a5 7/75cQ6pZ1aQ52kQoT65AaH1sagq0kwsSQQsKV6iAsy2BwSQXEQu+AZUDJEATTyjsEvW /dQmoQ710BctBOzQRsQWEq7qIyYJgrGIrl24rfwI89EL6oev6W3DzRYRUHoGWtgMTglM 5DlQjWI5n+jybhbO+jO01+JAbMYihB8YdAnzppfOgx7wop42LLUkMnTRf0PV4zxzyq5i zrVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WnOLlJGWjKKU4l6KU86petvNf/KeuBQfP8LASQRqnt8=; b=O8V0tadVyb36mrMUnRQSXFC28KBbj5zNDxqxV7vUxwr7xBu/46HRhmj6KHPnstRr2P ikQcmLIc064d35CWHk7MQiui2Qnj6HBPEuQqVvyYJneoaFDX9ezYFpaLOtTFUBqYIZYx N+xSUVBji3IouEdtiwUqtduUc2LwmJSYbLtDMN82TYGjBbgyA3q0nkNjHAaC0WiTSr8v 4R02AQVFtJSrlskvnPJAIjrsAX+ycihwXlniKau3slCVS8RSza8Pn+7EJlIsCb23A8Ey I4K8DND/yWoo0GXMW9cXzO+KuwECHQl5agOpILHfATeOjYBOqz9ha0oi7P90+IIxtA8T FnGA== X-Gm-Message-State: AGi0PubQLMJNdoagiVpA1MziDzMxSyc0C0Q/44nJA2ZHHKnk7snCOQez FDlTKDbJJjFFqDDEmC8EsGg= X-Google-Smtp-Source: APiQypKHstkks+d7QKXlK1Kx2K4FOqpUNOov9QzJnGobXCUEc76Hs0tyB7U8aK6EB9CSGnwIDUH4vw== X-Received: by 2002:a7b:cd10:: with SMTP id f16mr5171636wmj.21.1587044668689; Thu, 16 Apr 2020 06:44:28 -0700 (PDT) Received: from [192.168.2.1] (ip51ccf9cd.speed.planet.nl. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id z18sm21457242wrw.41.2020.04.16.06.44.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2020 06:44:27 -0700 (PDT) Subject: Re: [PATCH 2/4] arm64: dts: rockchip: Add RGA support to the PX30 To: Paul Kocialkowski References: <20200416115047.233720-1-paul.kocialkowski@bootlin.com> <20200416115047.233720-3-paul.kocialkowski@bootlin.com> <478f0a8b-f819-62f4-83b8-27918c4c2431@gmail.com> <20200416132442.GI125838@aptenodytes> From: Johan Jonker Message-ID: Date: Thu, 16 Apr 2020 15:44:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200416132442.GI125838@aptenodytes> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_064432_111336_D041916C X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Rob Herring , Hans Verkuil , linux-rockchip@lists.infradead.org, Jacob Chen , Thomas Petazzoni , Mauro Carvalho Chehab , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/16/20 3:24 PM, Paul Kocialkowski wrote: > Hi, > > On Thu 16 Apr 20, 15:02, Johan Jonker wrote: >> Hi Paul, >> >> The conversion of rockchip-rga.txt to rockchip-rga.yaml by myself just >> has been approved by robh. > > Huh, I looked around for ongoing related work but missed it. > I'll definitely rebase on top of your series and use the yaml description > instead. Thanks! > >> Maybe place dts patches at the end of a patch serie. >> Could you include a &rga patch if your device is supported in mainline, >> so we can test with: >> make ARCH=arm64 dtbs_check >> DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-rga.yaml > > I tested with the PX30 EVB so I can surely add a node there if that turns > out necessary (see below). > >> Johan >> >> On 4/16/20 1:50 PM, Paul Kocialkowski wrote: >>> The PX30 features a RGA block: add the necessary node to support it. >>> >>> Signed-off-by: Paul Kocialkowski >>> --- >>> arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi >>> index 75908c587511..4bfbee9d4123 100644 >>> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi >>> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi >>> @@ -1104,6 +1104,17 @@ vopl_mmu: iommu@ff470f00 { >>> status = "disabled"; >>> }; >>> >>> + rga: rga@ff480000 { >>> + compatible = "rockchip,px30-rga"; >>> + reg = <0x0 0xff480000 0x0 0x10000>; >>> + interrupts = ; >>> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; >>> + clock-names = "aclk", "hclk", "sclk"; >>> + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; >>> + reset-names = "core", "axi", "ahb"; >>> + power-domains = <&power PX30_PD_VO>; >> >> status = "disabled"; > > As of 5.6, the rk3399 has the node enabled by default. Did that change? 'status' disappeared during review for rk3399 between v2 and v3, but doesn't mention the reason. If someone can give more info here? https://lore.kernel.org/lkml/1500101920-24039-5-git-send-email-jacob-chen@iotwrt.com/ https://lore.kernel.org/lkml/1501470460-12014-5-git-send-email-jacob-chen@iotwrt.com/ > > Since it's a standalone block that has no I/O dependency, I don't really see > the point of disabling it by default. Vop, hdmi and other video devices are also disabled. Follow the rest I think... > > What do you think? > > Cheers, > > Paul > >>> + }; >>> + >>> qos_gmac: qos@ff518000 { >>> compatible = "syscon"; >>> reg = <0x0 0xff518000 0x0 0x20>; >>> >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel