From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89201C433ED for ; Wed, 12 May 2021 14:42:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1439613BD for ; Wed, 12 May 2021 14:42:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1439613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X9hVcQ8x6a265eJHoRz7KXFzoyK+Cx+RdKg4kWvMPIA=; b=qQXPVYP5Pn0Sk/55ZHMDB6Swn ZN/f8fG6lDdetZUxNtcmd1t2sQ5GmkildoueWReWYkUS4vNKVdwBObLkDH4STrKGRPyiSoxI1/+nQ TDizZPPf8owgXM7o/t8NNQTw/wI9g0xL1sa5FrMhHoMrIO/lNgnn+3KL/WNHvCXX7qDJHqr1Hx+ef 3S+KSunwl+aabbgVhogutyV9imHyWbyV4hXH1fzX5SC/o1K6DXR4Ul9LRWFfAtm5pdNNDpIxoPAgb 389g5CX44gHaxZJ+HSRhxQmRpCRuXKXfOb4XmtSN5rS2oJv8q7Pp5o4npXXKdvruzSqItABusZchK q2Jnliqjg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgq20-0033cx-BT; Wed, 12 May 2021 14:40:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgq1x-0033cp-1B for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 14:40:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=macw3BDL8faEUX2+hz3d0uj9g4wFjuDGkLGJb2Vhpdw=; b=vxzNuFIMaelaJAoG1Fo3LFn9GB fKEC6VHI0r9OvWoUDKJoRe0D+Bs/6HxGd+rQWSRQ5LfpQ1TWwoxnvqLaA9OGk7COP4pDG8Jdnhh2l 8Ykj/kmafMZ+PNnxGIx405RgNhGV1+qsitGtTMwZwe/G/F2dLg+E9LUbWS1fD3Etn2Pey37o+0OJt ECeGLwDsbXZGuclVKdOGHrsam5hOZ0fBh/pve5qIB71AOmvXrgMYI6AwGbeYLaPcqz1u+Z7thLuPy lenfBE7jvfZYsmM7tS9pSvMJMjapqvnHR2A92Vj6NVI9ULx2jEFRL0Uv1GE2VvBOUgNsbY6Ir+2ts yhVHvwHQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgq1t-00ASFL-Tb for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 14:40:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 700561FB; Wed, 12 May 2021 07:39:59 -0700 (PDT) Received: from [10.57.81.122] (unknown [10.57.81.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 584EF3F718; Wed, 12 May 2021 07:39:57 -0700 (PDT) Subject: Re: [PATCH v1 2/3] perf arm-spe: Correct sample flags for dummy event To: Leo Yan , Arnaldo Carvalho de Melo , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Al Grant References: <20210429150100.282180-1-leo.yan@linaro.org> <20210429150100.282180-3-leo.yan@linaro.org> From: James Clark Message-ID: Date: Wed, 12 May 2021 17:39:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210429150100.282180-3-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_074006_080722_8E5DAAD8 X-CRM114-Status: GOOD ( 27.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/04/2021 18:00, Leo Yan wrote: > The dummy event is mainly used for mmap, the TIME sample is only needed > for per-cpu case so that the perf tool can rely on the correct timing > for parsing symbols. And the CPU sample is useless for mmap. > > This patch enables TIME sample for per-cpu mmap and doesn't enable CPU > sample. For later extension (e.g. support multiple AUX events), it sets > the dummy event when the condition "opts->full_auxtrace" is true. > > Signed-off-by: Leo Yan > --- > tools/perf/arch/arm64/util/arm-spe.c | 30 ++++++++++++++++------------ > 1 file changed, 17 insertions(+), 13 deletions(-) > > diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c > index 902e73a64184..f6eec0900604 100644 > --- a/tools/perf/arch/arm64/util/arm-spe.c > +++ b/tools/perf/arch/arm64/util/arm-spe.c > @@ -70,7 +70,6 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, > struct evsel *evsel, *arm_spe_evsel = NULL; > struct perf_cpu_map *cpus = evlist->core.cpus; > bool privileged = perf_event_paranoid_check(-1); > - struct evsel *tracking_evsel; > int err; > > sper->evlist = evlist; > @@ -126,18 +125,23 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, > evsel__set_sample_bit(arm_spe_evsel, CPU); > > /* Add dummy event to keep tracking */ > - err = parse_events(evlist, "dummy:u", NULL); > - if (err) > - return err; > - > - tracking_evsel = evlist__last(evlist); > - evlist__set_tracking_event(evlist, tracking_evsel); > - > - tracking_evsel->core.attr.freq = 0; > - tracking_evsel->core.attr.sample_period = 1; > - evsel__set_sample_bit(tracking_evsel, TIME); > - evsel__set_sample_bit(tracking_evsel, CPU); > - evsel__reset_sample_bit(tracking_evsel, BRANCH_STACK); > + if (opts->full_auxtrace) { > + struct evsel *tracking_evsel; Hi Leo, I know the "if (opts->full_auxtrace)" pattern is copied from other auxtrace files, but I don't think it does anything because there is this at the top of the function: if (!opts->full_auxtrace) return 0; The same applies for other usages of "full_auxtrace" in the same function. They are all always true. I'm also not sure if it's ever defined what full_auxtrace means. James > + > + err = parse_events(evlist, "dummy:u", NULL); > + if (err) > + return err; > + > + tracking_evsel = evlist__last(evlist); > + evlist__set_tracking_event(evlist, tracking_evsel); > + > + tracking_evsel->core.attr.freq = 0; > + tracking_evsel->core.attr.sample_period = 1; > + > + /* In per-cpu case, always need the time of mmap events etc */ > + if (!perf_cpu_map__empty(cpus)) > + evsel__set_sample_bit(tracking_evsel, TIME); > + } > > return 0; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel