From: ankgupta@codeaurora.org (Ankit Gupta)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] trace/events: add chip name and hwirq to irq entry tracepoint
Date: Tue, 23 Jun 2015 09:16:39 -0600 [thread overview]
Message-ID: <f4fcf5e480035d355525306fc8743bac.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1506231024250.4037@nanos>
> On Mon, 22 Jun 2015, Ankit Gupta wrote:
>
>> Add chip name and hw-irq number to the trace_irq_handler_entry()
>> tracepoint. When tracing interrupt events the chip-name and hw-irq
>> numbers are stable and known in advance. This makes them a better
>> choice as a filtering criteria for the trace buffer dump. On the
>> flipside, the os-irq numbers are dynamically allocated which makes
>> them difficult to use for the same purpose.
>>
>> Dump messages will look like:
>> ...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140
>
> I can't see the domain name being captured/printed in the code below.
>
>> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
>> + TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq,
>> + __get_str(name), show_chip_name(__entry->irq),
>> + show_hwirq(__entry->irq))
>> );
Thanks Thomas for your comment. Its actually printing a chipname and not
the domain. Will correct the dump message in the next patch. It will print
as follow.
...irq_handler_entry: irq=22 name=msm_serial0 Chip=GIC hwirq=140
>
> Thanks,
>
> tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm"
> in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-06-23 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 23:05 [PATCH v2] trace/events: add chip name and hwirq to irq entry tracepoint Ankit Gupta
2015-06-23 8:25 ` Thomas Gleixner
2015-06-23 15:16 ` Ankit Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fcf5e480035d355525306fc8743bac.squirrel@www.codeaurora.org \
--to=ankgupta@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).